Page MenuHomeFreeBSD
Differential D52594

if_gif: Use the MTU on the gif interface for the outgoing packets
Needs ReviewPublic
Actions

Authored by meta on Wed, Sep 17, 3:46 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Sep 26, 10:01 AM
Unknown Object (File)
Thu, Sep 25, 10:04 PM
Unknown Object (File)
Thu, Sep 25, 12:20 PM
Unknown Object (File)
Thu, Sep 18, 3:57 AM
Unknown Object (File)
Thu, Sep 18, 3:57 AM
Unknown Object (File)
Thu, Sep 18, 3:05 AM
Unknown Object (File)
Thu, Sep 18, 2:46 AM
Unknown Object (File)
Thu, Sep 18, 1:14 AM
View All 9 Files
Subscribers
glebius
imp
ivy
melifaro
ziaee

Details

Reviewers
zlei
ae
Group Reviewers
network
Summary

This is a revised version of D51866 to address review comments
and resolve conflicts after D51835.

As I mentioned in D51866 [1], I would like this changes to be included in
15.0-RELEASE. I worked on D51297 to ensure that the fix for bug 280736 would
be included in the release, as there has been no progress on D45854 for over
a year. Since this is a better approach for bug 280736, it should be included
as well.

Ongoing work can be seen on GitHub:
https://github.com/metalefty/freebsd-src/commits/gif/

[1] https://reviews.freebsd.org/D51866#1196328

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 67125
Build 64008: arc lint + arc unit

Event Timeline

meta created this revision.Wed, Sep 17, 3:46 PM
Herald added subscribers: ivy, ziaee, glebius and 2 others. · View Herald TranscriptWed, Sep 17, 3:46 PM
meta requested review of this revision.Wed, Sep 17, 3:46 PM
Harbormaster completed remote builds in B67125: Diff 162268.Wed, Sep 17, 3:46 PM
meta added a comment.Fri, Sep 19, 12:39 PM

This worked very well for me, both for EtherIP (Ethernet-ovet-IPv6) and IPIP (v6-over-v6).

zlei added a comment.Fri, Sep 19, 7:26 PM
In D52594#1201880, @meta wrote:

This worked very well for me, both for EtherIP (Ethernet-ovet-IPv6) and IPIP (v6-over-v6).

I'm preparing the tests. It appears good.

zlei added a comment.Sun, Sep 21, 5:07 PM

I'm going to firstly integrate part of this change, to be precisely, the if_bridge's MTU change behavior of adding if_gif(4) as a member interface.

Revision Contents
Changeset List

PathSize
sbin/
ifconfig/
14 lines
3 lines
share/
man/
man4/
79 lines
sys/
net/
7 lines
13 lines
3 lines
netinet/
3 lines
13 lines
1 line
netinet6/
17 lines
17 lines
1 line

Diff 162268

View Options

sbin/ifconfig/ifconfig.8

Loading...
View Options

sbin/ifconfig/ifgif.c

Loading...
View Options

share/man/man4/gif.4

Loading...
View Options

sys/net/if.c

Loading...
View Options

sys/net/if_bridge.c

Loading...
View Options

sys/net/if_gif.h

Loading...
View Options

sys/netinet/in_gif.c

Loading...
View Options

sys/netinet/ip_output.c

Loading...
View Options

sys/netinet/ip_var.h

Loading...
View Options

sys/netinet6/in6_gif.c

Loading...
View Options

sys/netinet6/ip6_output.c

Loading...
View Options

sys/netinet6/ip6_var.h

Loading...