Differential D51227

bridge: make 802.1ad (Q-in-Q) configurable
ClosedPublic
Actions

Authored by ivy on Jul 9 2025, 6:41 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Mon, Sep 22, 12:58 AM

	Unknown Object (File)
	Fri, Sep 12, 7:01 AM

	Unknown Object (File)
	Thu, Sep 11, 3:33 AM

	Unknown Object (File)
	Wed, Sep 10, 4:46 AM

	Unknown Object (File)
	Tue, Sep 9, 5:18 PM

	Unknown Object (File)
	Thu, Sep 4, 2:28 PM

	Unknown Object (File)
	Sep 1 2025, 1:56 PM

	Unknown Object (File)
	Aug 30 2025, 7:40 PM

View All 22 Files

Subscribers

pauamma_gundo.com

Details

Reviewers

des
kevans
p.mousavizadeh_protonmail.com
pauamma_gundo.com

Group Reviewers

network
manpages

Commits

rGd43ac3b76ef7: bridge: Make 802.1ad (Q-in-Q) configurable

Summary

Allowing tag stacking by default can permit VLAN-hopping attacks in
certain configurations. To mitigate this, disallow sending Q-in-Q
frames by default unless the new "qinq" option is enabled on the
interface. The bridge flag "defqinq" can be used to restore the
previous behaviour of allowing Q-in-Q on all interfaces.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 65330
Build 62213: arc lint + arc unit

Event Timeline

ivy created this revision.Jul 9 2025, 6:41 PM

Herald added subscribers: ziaee, glebius, melifaro and 2 others. · View Herald TranscriptJul 9 2025, 6:41 PM

ivy requested review of this revision.Jul 9 2025, 6:41 PM

Harbormaster completed remote builds in B65305: Diff 158232.Jul 9 2025, 6:41 PM

ivy added a parent revision: D51185: bridge.4: Improve VLAN documentation.Jul 9 2025, 6:42 PM

ivy added a reviewer: p.mousavizadeh_protonmail.com.

ivy added a reviewer: manpages.

ivy added a child revision: D51228: bridge: make vlanfilter a bridge flag.Jul 9 2025, 7:36 PM

With this typo fixed (either way) the manual page change appears consistent with the change summary.

share/man/man4/bridge.4
555	or maybe "not the interface receiving..."

This revision is now accepted and ready to land.Jul 10 2025, 12:42 AM

tyop fix

This revision now requires review to proceed.Jul 11 2025, 3:03 AM

Harbormaster completed remote builds in B65330: Diff 158295.Jul 11 2025, 3:03 AM

ivy added inline comments.Jul 11 2025, 3:04 AM

share/man/man4/bridge.4
555	to keep plural agreement i changed this to "the interface", which i think is what i meant to write originally.

kevans accepted this revision.Jul 31 2025, 2:34 PM

This revision is now accepted and ready to land.Jul 31 2025, 2:34 PM

Closed by commit rGd43ac3b76ef7: bridge: Make 802.1ad (Q-in-Q) configurable (authored by ivy). · Explain WhyAug 5 2025, 7:26 PM

This revision was automatically updated to reflect the committed changes.

ivy added a commit: rGd43ac3b76ef7: bridge: Make 802.1ad (Q-in-Q) configurable.

Revision Contents
Changeset List

Path

Size

sbin/

ifconfig/

18 lines

20 lines

share/

man/

man4/

42 lines

sys/

net/

24 lines

6 lines

tests/

sys/

net/

if_bridge_test.sh

36 lines

Diff 158295

sbin/ifconfig/ifbridge.c

Loading...

sbin/ifconfig/ifconfig.8

Loading...

share/man/man4/bridge.4

Loading...

sys/net/if_bridge.c

Loading...

sys/net/if_bridgevar.h

Loading...

tests/sys/net/if_bridge_test.sh

Loading...