Page MenuHomeFreeBSD

bridge: make vlanfilter a bridge flag
AbandonedPublic

Authored by ivy on Jul 9 2025, 7:36 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Oct 12, 6:09 PM
Unknown Object (File)
Sat, Oct 11, 11:15 AM
Unknown Object (File)
Sat, Oct 11, 11:15 AM
Unknown Object (File)
Sat, Oct 11, 3:14 AM
Unknown Object (File)
Sep 13 2025, 4:51 AM
Unknown Object (File)
Sep 12 2025, 2:18 AM
Unknown Object (File)
Sep 1 2025, 4:25 AM
Unknown Object (File)
Sep 1 2025, 4:23 AM

Details

Reviewers
des
kevans
Group Reviewers
network
Summary

vlanfilter was originally a per-interface flag to allow more flexible
configurations where some interfaces had VLAN filtering enabled and
some didn't. In practice, this just makes the configuration more
confusing without any real benefit.

Rename the defvlanfilter bridge flag to vlanfilter, make it enable
filtering unconditionally, and remove the vlanfilter interface flag.

Remove the magic that enabled VLAN filtering automatically when setting
filtering parameters on an interface, since it's now a one-time setting.
Instead, to avoid misconfiguration, don't allow PVID or VLAN access list
to be configured on an interface unless vlanfilter is enabled on the
bridge itself.

While here, add some more atf_checks to the bridge VLAN tests to
make debugging easier.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 65306
Build 62189: arc lint + arc unit