Add a new per-interface option "vlanproto", which can be either
"802.1q" (the default) or "802.1ad". This controls what type of
tag we attach to outgoing packets on the interface.
Details
Details
- Reviewers
des kevans pauamma_gundo.com - Group Reviewers
network manpages - Commits
- rGf94c370de6e7: bridge: Allow VLAN protocol to be configured
Diff Detail
Diff Detail
- Repository
- rG FreeBSD src repository
- Lint
Lint Skipped - Unit
Tests Skipped - Build Status
Buildable 65313 Build 62196: arc lint + arc unit
Event Timeline
Comment Actions
Other than this possible clarification, manual page change looks reasonable and consistent with the intent of the rest as stated in the summary.
| sbin/ifconfig/ifconfig.8 | ||
|---|---|---|
| 2766–2769 | Audience check: are expected readers of this expected to know 802.1q is VLAN and 802.1ad Q-in-Q? | |
| sbin/ifconfig/ifconfig.8 | ||
|---|---|---|
| 2766–2769 | i feel like anyone who needs this option will know what 802.1ad is, and people who don't know that can just ignore it. i'm not opposed to rewording it if anyone has a better suggestion, but i'd rather avoid being too verbose here as the manpage is already quite long. (there is more verbose documentation on this in D51185, and there's a pointer to that at the top of this section.) also, compare with the other vlanproto option which is used for vlan(4) devices; it uses more lines since it has a list, but it's otherwise about the same text. | |
Comment Actions
rename the option to "ifvlanproto" to avoid possible confusion with the
vlan(4) option of the same name.