Page MenuHomeFreeBSD
Differential D51182

bridge: be consistent about PVID terminology
ClosedPublic
Actions

Authored by ivy on Jul 6 2025, 6:34 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Jun 30, 10:17 PM
Unknown Object (File)
Sun, Jun 28, 9:55 PM
Unknown Object (File)
Sun, Jun 28, 1:51 PM
Unknown Object (File)
Sat, Jun 27, 7:50 AM
Unknown Object (File)
Tue, Jun 23, 1:32 PM
Unknown Object (File)
Mon, Jun 22, 11:29 PM
Unknown Object (File)
Mon, Jun 22, 11:02 PM
Unknown Object (File)
Mon, Jun 22, 4:06 PM
View All Files
Subscribers
ae
glebius
imp
melifaro

Details

Reviewers
des
kevans
zlei
markj
kp
Group Reviewers
network
Commits
rG4d281507f5f1: bridge: be consistent about PVID terminology
Summary

The PVID option is exposed to the user as 'untagged', but the API was
inconsistent on whether it's called 'untagged' or 'PVID'. Standardise
on calling it PVID everywhere in the code, since this is the 802.1Q
terminology.

Keep 'untagged' as the user-facing term since sysadmins are not network
admins and are often not familiar with the term PVID.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 65238
Build 62121: arc lint + arc unit

Event Timeline

ivy created this revision.Jul 6 2025, 6:34 PM
Herald added subscribers: glebius, melifaro, ae, imp. · View Herald TranscriptJul 6 2025, 6:34 PM
ivy requested review of this revision.Jul 6 2025, 6:34 PM
Harbormaster completed remote builds in B65238: Diff 158057.Jul 6 2025, 6:34 PM
ivy added a parent revision: D51181: bridge: exterr-ize.Jul 6 2025, 6:34 PM
ivy added a child revision: D51185: bridge.4: Improve VLAN documentation.Jul 6 2025, 8:24 PM
ivy updated this revision to Diff 159327.EditedJul 28 2025, 2:45 PM

rebase on main and move out of the bridge stack so this can be landed quicker.

Harbormaster completed remote builds in B65803: Diff 159327.Jul 28 2025, 2:45 PM
ivy removed a parent revision: D51181: bridge: exterr-ize.Jul 28 2025, 2:45 PM
ivy removed a child revision: D51185: bridge.4: Improve VLAN documentation.
ivy added reviewers: zlei, markj.
ivy added a reviewer: kp.Jul 28 2025, 3:47 PM
des added inline comments.Jul 28 2025, 4:59 PM
sys/net/if_bridge.c
260

”port port vlan identifier”?

ivy added inline comments.Jul 28 2025, 5:01 PM
sys/net/if_bridge.c
260

on the one hand i appreciate we should avoid "PIN number" constructs, but i wonder if it isn't useful to be somewhat explicit here.

perhaps "if PVID"?

ivy updated this revision to Diff 159346.Jul 28 2025, 5:06 PM

PIN number

Harbormaster completed remote builds in B65809: Diff 159346.Jul 28 2025, 5:06 PM
ivy updated this revision to Diff 159347.Jul 28 2025, 5:17 PM

remove the bif_pvid comment

it's obvious from what it is, since it has the type ether_vlanid_t and is
literally called "bif_pvid".

Harbormaster completed remote builds in B65810: Diff 159347.Jul 28 2025, 5:17 PM
ivy updated this revision to Diff 159348.Jul 28 2025, 5:23 PM

we have reached a compromise on the matter of PIN numbers

Harbormaster completed remote builds in B65811: Diff 159348.Jul 28 2025, 5:23 PM
This revision was not accepted when it landed; it landed in state Needs Review.Jul 28 2025, 5:27 PM
Closed by commit rG4d281507f5f1: bridge: be consistent about PVID terminology (authored by ivy). · Explain Why
This revision was automatically updated to reflect the committed changes.
ivy added a commit: rG4d281507f5f1: bridge: be consistent about PVID terminology.

Revision Contents
Changeset List

PathSize
sbin/
ifconfig/
16 lines
sys/
net/
28 lines
4 lines

Diff 158057

View Options

sbin/ifconfig/ifbridge.c

Loading...
View Options

sys/net/if_bridge.c

Loading...
View Options

sys/net/if_bridgevar.h

Loading...