Differential D50748

rsu: implement A-MPDU TX; add TODO items for further work
ClosedPublic
Actions

Authored by adrian on Jun 9 2025, 2:13 AM.

Tags

Referenced Files

	F140114836: D50748.id156698.diff
	Sat, Dec 20, 10:40 AM

	Unknown Object (File)
	Thu, Dec 18, 3:29 PM

	Unknown Object (File)
	Fri, Dec 12, 4:38 AM

	Unknown Object (File)
	Tue, Dec 9, 12:44 PM

	Unknown Object (File)
	Sat, Nov 22, 12:21 AM

	Unknown Object (File)
	Nov 2 2025, 11:04 AM

	Unknown Object (File)
	Oct 31 2025, 3:21 AM

	Unknown Object (File)
	Oct 28 2025, 5:34 AM

View All 53 Files

Subscribers

Details

Reviewers

None

Group Reviewers

Commits

rGb73f52a0344d: rsu: implement A-MPDU TX; add TODO items for further work

Summary

Enable A-MPDU TX by fixing the A-MPDU TX establish routine; always assign sequence numbers from net80211 (for now); and fix the descriptor programming.

Add TODO items around CAM allocation for keys, MAC ID stuff which we likely need to fix for working IBSS/AP behaviour, and whatever other bits and pieces I noticed.

Disable amsdu2ampdu, we can decap A-MSDU just fine in net80211, doubly so if we somehow get A-MSDU inside an A-MPDU.

I've tested / verified that A-MPDU TX and A-MPDU RX is correctly
established and functioning by using rtwn in monitor mode.

I used an old r92su linux out of tree driver for comparison.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 64716
Build 61600: arc lint + arc unit

Event Timeline

adrian created this revision.Jun 9 2025, 2:13 AM

Herald added a subscriber: imp. · View Herald TranscriptJun 9 2025, 2:13 AM

adrian requested review of this revision.Jun 9 2025, 2:13 AM

Harbormaster completed remote builds in B64716: Diff 156698.Jun 9 2025, 2:13 AM

adrian added a parent revision: D50747: run: enable seqno offload.Jun 9 2025, 2:13 AM

adrian edited parent revisions, added: D50749: rsu: enable seqno offload; removed: D50747: run: enable seqno offload.

adrian added a reviewer: wireless.Jun 9 2025, 2:17 AM

adrian added a project: wireless.

adrian added a child revision: D50771: usb: update wifi drivers to use IEEE80211_FEXT_SEQNO_OFFLOAD.Jun 10 2025, 4:25 AM

I have no idea about the internals of this driver; if you say it works go ahead:

Okayed by: bz

This revision was not accepted when it landed; it landed in state Needs Review.Sep 9 2025, 1:53 AM

Closed by commit rGb73f52a0344d: rsu: implement A-MPDU TX; add TODO items for further work (authored by adrian). · Explain Why

This revision was automatically updated to reflect the committed changes.

adrian added a commit: rGb73f52a0344d: rsu: implement A-MPDU TX; add TODO items for further work.

Revision Contents
Changeset List

Path

Size

sys/

dev/

usb/

wlan/

62 lines

9 lines

Diff 156698

sys/dev/usb/wlan/if_rsu.c

Loading...

sys/dev/usb/wlan/if_rsureg.h

Loading...