Differential D47692

device_pager: user iterators to free device pages
ClosedPublic
Actions

Authored by dougm on Nov 20 2024, 11:45 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Sat, May 23, 4:15 PM

	Unknown Object (File)
	Fri, May 22, 11:54 PM

	Unknown Object (File)
	Thu, May 7, 3:11 AM

	Unknown Object (File)
	Wed, May 6, 8:48 AM

	Unknown Object (File)
	Wed, May 6, 7:21 AM

	Unknown Object (File)
	Wed, May 6, 6:34 AM

	Unknown Object (File)
	Wed, May 6, 6:04 AM

	Unknown Object (File)
	Mon, May 4, 2:35 AM

Subscribers

ehem_freebsd_m5p.com

Details

Reviewers

kib
markj
andrew

Commits

rG38e3125d6df9: device_pager: user iterators to free device pages

Summary

Change cdev_mgtdev_page_free_page to take an iterator, rather than an object and page, so that removing the page from the object radix tree can take advantage of locality with iterators. Define a general-purpose function to free multiple pages, which can be used in several places.

Diff Detail

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

dougm created this revision.Nov 20 2024, 11:45 PM

Herald added a reviewer: andrew. · View Herald TranscriptNov 20 2024, 11:45 PM

Herald added subscribers: linuxkpi, ehem_freebsd_m5p.com, emaste. · View Herald Transcript

dougm requested review of this revision.Nov 20 2024, 11:45 PM

Fix typo in tegra_bo.c.

markj added inline comments.Nov 21 2024, 4:32 AM

sys/vm/device_pager.c
267
291	Looking at the callers of cdev_mgtdev_pager_free_pages(), I believe that in all cases the page count is simply the number of resident pages in the object. In that case, I would suggest simply iterating over all pages in the object and freeing them, rather than passing this count.

Drop length argument to cdev_mgtdev_pager_free_pages().

kib accepted this revision.Nov 21 2024, 10:34 AM

This revision is now accepted and ready to land.Nov 21 2024, 10:34 AM

Closed by commit rG38e3125d6df9: device_pager: user iterators to free device pages (authored by dougm). · Explain WhyNov 21 2024, 9:51 PM

This revision was automatically updated to reflect the committed changes.

dougm added a commit: rG38e3125d6df9: device_pager: user iterators to free device pages.

Herald added a subscriber: imp. · View Herald TranscriptNov 21 2024, 9:51 PM

Revision Contents
Changeset List

Path

Size

sys/

arm/

nvidia/

drm2/

6 lines

compat/

linuxkpi/

common/

src/

16 lines

dev/

drm2/

ttm/

20 lines

xen/

gntdev/

13 lines

privcmd/

14 lines

vm/

39 lines

3 lines

Diff 146789

sys/arm/nvidia/drm2/tegra_bo.c

Loading...

sys/compat/linuxkpi/common/src/linux_page.c

Loading...

sys/dev/drm2/ttm/ttm_bo_vm.c

Loading...

sys/dev/xen/gntdev/gntdev.c

Loading...

sys/dev/xen/privcmd/privcmd.c

Loading...

sys/vm/device_pager.c

Loading...

sys/vm/vm_pager.h

Loading...