Page MenuHomeFreeBSD

pfil: PFIL_PASS never frees the mbuf
ClosedPublic

Authored by kp on Jan 26 2024, 2:45 PM.
Tags
None
Referenced Files
F153734971: D43617.id.diff
Thu, Apr 23, 7:54 AM
F153728401: D43617.id.diff
Thu, Apr 23, 6:42 AM
F153667886: D43617.diff
Wed, Apr 22, 7:06 PM
Unknown Object (File)
Wed, Apr 22, 8:26 AM
Unknown Object (File)
Tue, Apr 21, 8:05 AM
Unknown Object (File)
Thu, Apr 9, 9:57 AM
Unknown Object (File)
Tue, Apr 7, 3:12 PM
Unknown Object (File)
Tue, Apr 7, 3:30 AM

Details

Summary

pfil hooks (i.e. firewalls) may pass, modify or free the mbuf passed
to them. (E.g. when rejecting a packet, or when gathering up packets
for reassembly).

If the hook returns PFIL_PASS the mbuf must still be present. Assert
this in pfil_mem_common() and ensure that ipfilter follows this
convention. pf and ipfw already did.
Similarly, if the hook returns PFIL_DROPPED or PFIL_CONSUMED the mbuf
must have been freed (or now be owned by the firewall for further
processing, like packet scheduling or reassembly).

This allows us to remove a few extraneous NULL checks.

Suggested by: tuexen
Sponsored by: Rubicon Communications, LLC ("Netgate")

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable