bhyve: Move some more amd64-specific drivers to their own subdir
ClosedPublic
Actions

usr.sbin/bhyve/snapshot.c
142	Hummm, this is fine for now. I suspect some of Gustav's other changes in flight for this stuff might remove the need for this as a hardcoded table anyway.

This revision is now accepted and ready to land.Jun 14 2023, 11:28 PM

corvink accepted this revision.Jun 15 2023, 5:57 AM

markj marked an inline comment as done.Jun 15 2023, 10:12 PM

markj added inline comments.

usr.sbin/bhyve/snapshot.c
142	Yes, this is ugly, but so is the table. Device model drivers should contain whatever metadata is needed for snapshots to work.

Rebase, handle review feedback.

This revision now requires review to proceed.Jun 15 2023, 10:13 PM

Harbormaster completed remote builds in B52094: Diff 123306.Jun 15 2023, 10:13 PM

corvink accepted this revision.Jun 16 2023, 5:31 AM

This revision is now accepted and ready to land.Jun 16 2023, 5:31 AM

jhb accepted this revision.Jun 16 2023, 11:28 PM

emaste accepted this revision.Jun 21 2023, 4:29 PM

Will you combine all of the move-amd64-files into one commit?

In D40551#951026, @emaste wrote:

Will you combine all of the move-amd64-files into one commit?

I could, but I wasn't specifically planning to. Do you have a preference?

In D40551#951037, @markj wrote:

I could, but I wasn't specifically planning to. Do you have a preference?

At first I saw only a couple of changes moving files and it seemed a bit odd, then I realized there's a dozen or so. Given that it's already split up like this I'd leave it alone rather than spending a lot more effort for little value.

Closed by commit rGf927afc1a6fe: bhyve: Move some more amd64-specific drivers to their own subdir (authored by markj). · Explain WhyOct 4 2023, 4:54 PM

This revision was automatically updated to reflect the committed changes.

markj added a commit: rGf927afc1a6fe: bhyve: Move some more amd64-specific drivers to their own subdir.

markj added a commit: rG71378e0ffa84: bhyve: Move some more amd64-specific drivers to their own subdir.Oct 11 2023, 1:25 PM