Page MenuHomeFreeBSD

bhyve: Move some more amd64-specific drivers to their own subdir
ClosedPublic

Authored by markj on Jun 14 2023, 9:52 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Feb 29, 4:47 AM
Unknown Object (File)
Dec 23 2023, 12:43 AM
Unknown Object (File)
Dec 11 2023, 4:33 AM
Unknown Object (File)
Dec 5 2023, 4:49 PM
Unknown Object (File)
Nov 27 2023, 8:28 AM
Unknown Object (File)
Nov 26 2023, 11:29 AM
Unknown Object (File)
Nov 22 2023, 8:42 PM
Unknown Object (File)
Nov 22 2023, 7:14 PM
Subscribers

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 52094
Build 48985: arc lint + arc unit

Event Timeline

markj requested review of this revision.Jun 14 2023, 9:52 PM
jhb added inline comments.
usr.sbin/bhyve/snapshot.c
142

Hummm, this is fine for now. I suspect some of Gustav's other changes in flight for this stuff might remove the need for this as a hardcoded table anyway.

This revision is now accepted and ready to land.Jun 14 2023, 11:28 PM
markj added inline comments.
usr.sbin/bhyve/snapshot.c
142

Yes, this is ugly, but so is the table. Device model drivers should contain whatever metadata is needed for snapshots to work.

markj marked an inline comment as done.

Rebase, handle review feedback.

This revision now requires review to proceed.Jun 15 2023, 10:13 PM
This revision is now accepted and ready to land.Jun 16 2023, 5:31 AM

Will you combine all of the move-amd64-files into one commit?

Will you combine all of the move-amd64-files into one commit?

I could, but I wasn't specifically planning to. Do you have a preference?

I could, but I wasn't specifically planning to. Do you have a preference?

At first I saw only a couple of changes moving files and it seemed a bit odd, then I realized there's a dozen or so. Given that it's already split up like this I'd leave it alone rather than spending a lot more effort for little value.