in netstack
AbandonedPublic
Actions

Authored by jhibbits on Jan 25 2023, 8:59 PM.

Details

Reviewers

glebius
shurd
melifaro

Group Reviewers

network
transport
iflib

Commits

rG3d0d5b21c9b2: IfAPI: Explicitly include <net/if_private.h> in netstack

Summary

In preparation of making if_t completely opaque outside of the netstack,
explicitly include the header. <net/if_var.h> will stop including the
header in the future.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 49233
Build 46123: arc lint + arc unit

Event Timeline

jhibbits created this revision.Jan 25 2023, 8:59 PM

Herald added a reviewer: shurd. · View Herald TranscriptJan 25 2023, 8:59 PM

Herald added a reviewer: transport. · View Herald Transcript

Herald added a reviewer: iflib. · View Herald Transcript

Herald added subscribers: donner, melifaro, farrokhi and 2 others. · View Herald Transcript

jhibbits requested review of this revision.Jan 25 2023, 8:59 PM

Harbormaster completed remote builds in B49233: Diff 115736.Jan 25 2023, 8:59 PM

melifaro accepted this revision as: melifaro.Jan 25 2023, 9:32 PM

glebius accepted this revision.Jan 31 2023, 4:44 PM

Have to close this somehow...

Closed by commit 3d0d5b21c9

jhibbits added a commit: rG3d0d5b21c9b2: IfAPI: Explicitly include <net/if_private.h> in netstack.Mar 23 2023, 1:05 PM

Revision Contents
Changeset List

Path

Size

sys/

net/

ifdi_if.m

1 line

ifq.c

1 line

net80211/

1 line

1 line

6 lines

1 line

1 line

1 line

1 line

1 line

1 line

1 line

1 line

1 line

1 line

1 line

netgraph/

netflow/

1 line

1 line

1 line

1 line

1 line

1 line

1 line

netinet/

1 line

1 line

1 line

1 line

1 line

1 line

1 line

1 line

1 line

1 line

1 line

1 line

1 line

1 line

1 line

1 line

1 line

netdump/

1 line

1 line

1 line

1 line

1 line

tcp_stacks/

rack_bbr_common.c

1 line

tcp_subr.c

1 line

toecore.c

1 line

netinet6/

1 line

1 line

1 line

1 line

1 line

1 line

1 line

1 line

1 line

1 line

1 line

1 line

1 line

1 line

1 line

2 lines

1 line

1 line

1 line

1 line

1 line

1 line

netipsec/

ipsec_input.c

1 line

netpfil/

ipfilter/

netinet/

ip_compat.h

1 line

ip_log.c

1 line

ipfw/

1 line

1 line

1 line

1 line

1 line

1 line

nat64/

nat64_translate.c

1 line

nptv6/

nptv6.c

1 line

pf/

1 line

1 line

1 line

1 line

1 line

Diff 115736

View Options

sys/net/ifdi_if.m

View Options

sys/net/ifq.c

View Options

sys/net80211/ieee80211.c

View Options

sys/net80211/ieee80211_adhoc.c

View Options

sys/net80211/ieee80211_ddb.c

View Options

sys/net80211/ieee80211_freebsd.c

View Options

sys/net80211/ieee80211_hostap.c

View Options

sys/net80211/ieee80211_input.c

View Options

sys/net80211/ieee80211_ioctl.c

View Options

sys/net80211/ieee80211_mesh.c

View Options

sys/net80211/ieee80211_output.c

View Options

sys/net80211/ieee80211_proto.c

View Options

sys/net80211/ieee80211_scan.c

View Options

sys/net80211/ieee80211_scan_sw.c

View Options

sys/net80211/ieee80211_sta.c

View Options

sys/net80211/ieee80211_wds.c

View Options

sys/netgraph/netflow/netflow.c

View Options

sys/netgraph/netflow/ng_netflow.c

View Options

sys/netgraph/ng_eiface.c

View Options

sys/netgraph/ng_ether.c

View Options

sys/netgraph/ng_gif.c

View Options

sys/netgraph/ng_iface.c

View Options

sys/netgraph/ng_source.c

View Options

sys/netinet/if_ether.c

View Options

sys/netinet/igmp.c

View Options

sys/netinet/in.c

View Options

sys/netinet/in_fib.c

View Options

sys/netinet/in_gif.c

View Options

sys/netinet/in_mcast.c

View Options

sys/netinet/in_pcb.c

View Options

sys/netinet/in_rmx.c

View Options

sys/netinet/ip_carp.c

View Options

sys/netinet/ip_divert.c

View Options

sys/netinet/ip_fastfwd.c

View Options

sys/netinet/ip_gre.c

View Options

sys/netinet/ip_icmp.c

View Options

sys/netinet/ip_input.c

View Options

sys/netinet/ip_mroute.c

View Options

sys/netinet/ip_output.c

View Options

sys/netinet/ip_reass.c

View Options

sys/netinet/netdump/netdump_client.c

View Options

sys/netinet/sctp_os_bsd.h

View Options

sys/netinet/tcp_lro.c

View Options

sys/netinet/tcp_offload.c

View Options

sys/netinet/tcp_ratelimit.c

View Options

sys/netinet/tcp_stacks/rack_bbr_common.c

View Options

sys/netinet/tcp_subr.c

View Options

sys/netinet/toecore.c

View Options

sys/netinet6/frag6.c

View Options

sys/netinet6/icmp6.c

View Options

sys/netinet6/in6.c

View Options

sys/netinet6/in6_fib.c

View Options

sys/netinet6/in6_gif.c

View Options

sys/netinet6/in6_ifattach.c

View Options

sys/netinet6/in6_mcast.c

View Options

sys/netinet6/in6_rmx.c

View Options

sys/netinet6/in6_src.c

View Options

sys/netinet6/ip6_fastfwd.c

View Options

sys/netinet6/ip6_forward.c

View Options

sys/netinet6/ip6_gre.c

View Options

sys/netinet6/ip6_mroute.c

View Options

sys/netinet6/ip6_output.c

View Options

sys/netinet6/mld6.c

View Options

sys/netinet6/nd6.h

View Options

sys/netinet6/nd6.c

View Options

sys/netinet6/nd6_nbr.c

View Options

sys/netinet6/nd6_rtr.c

View Options

sys/netinet6/raw_ip6.c

View Options

sys/netinet6/scope6.c

View Options

sys/netinet6/send.c

View Options

sys/netipsec/ipsec_input.c

View Options

sys/netpfil/ipfilter/netinet/ip_compat.h

View Options

sys/netpfil/ipfilter/netinet/ip_log.c

View Options

sys/netpfil/ipfw/ip_dn_io.c

View Options

sys/netpfil/ipfw/ip_fw2.c

View Options

sys/netpfil/ipfw/ip_fw_bpf.c

View Options

sys/netpfil/ipfw/ip_fw_iface.c

View Options

sys/netpfil/ipfw/ip_fw_log.c

View Options

sys/netpfil/ipfw/ip_fw_nat.c

View Options

sys/netpfil/ipfw/nat64/nat64_translate.c

View Options

sys/netpfil/ipfw/nptv6/nptv6.c

View Options

sys/netpfil/pf/if_pflog.c

View Options

sys/netpfil/pf/if_pfsync.c

View Options

sys/netpfil/pf/pf.c

View Options

sys/netpfil/pf/pf_if.c

View Options

IfAPI: Explicitly include <net/if_private.h> in netstackAbandonedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 115736

sys/net/ifdi_if.m

sys/net/ifq.c

sys/net80211/ieee80211.c

sys/net80211/ieee80211_adhoc.c

sys/net80211/ieee80211_ddb.c

sys/net80211/ieee80211_freebsd.c

sys/net80211/ieee80211_hostap.c

sys/net80211/ieee80211_input.c

sys/net80211/ieee80211_ioctl.c

sys/net80211/ieee80211_mesh.c

sys/net80211/ieee80211_output.c

sys/net80211/ieee80211_proto.c

sys/net80211/ieee80211_scan.c

sys/net80211/ieee80211_scan_sw.c

sys/net80211/ieee80211_sta.c

sys/net80211/ieee80211_wds.c

sys/netgraph/netflow/netflow.c

sys/netgraph/netflow/ng_netflow.c

sys/netgraph/ng_eiface.c

sys/netgraph/ng_ether.c

sys/netgraph/ng_gif.c

sys/netgraph/ng_iface.c

sys/netgraph/ng_source.c

sys/netinet/if_ether.c

sys/netinet/igmp.c

sys/netinet/in.c

sys/netinet/in_fib.c

sys/netinet/in_gif.c

sys/netinet/in_mcast.c

sys/netinet/in_pcb.c

sys/netinet/in_rmx.c

sys/netinet/ip_carp.c

sys/netinet/ip_divert.c

sys/netinet/ip_fastfwd.c

sys/netinet/ip_gre.c

sys/netinet/ip_icmp.c

sys/netinet/ip_input.c

sys/netinet/ip_mroute.c

sys/netinet/ip_output.c

sys/netinet/ip_reass.c

sys/netinet/netdump/netdump_client.c

sys/netinet/sctp_os_bsd.h

sys/netinet/tcp_lro.c

sys/netinet/tcp_offload.c

sys/netinet/tcp_ratelimit.c

sys/netinet/tcp_stacks/rack_bbr_common.c

sys/netinet/tcp_subr.c

sys/netinet/toecore.c

sys/netinet6/frag6.c

sys/netinet6/icmp6.c

sys/netinet6/in6.c

sys/netinet6/in6_fib.c

sys/netinet6/in6_gif.c

sys/netinet6/in6_ifattach.c

sys/netinet6/in6_mcast.c

sys/netinet6/in6_rmx.c

sys/netinet6/in6_src.c

sys/netinet6/ip6_fastfwd.c

sys/netinet6/ip6_forward.c

sys/netinet6/ip6_gre.c

sys/netinet6/ip6_mroute.c

sys/netinet6/ip6_output.c

sys/netinet6/mld6.c

sys/netinet6/nd6.h

sys/netinet6/nd6.c

sys/netinet6/nd6_nbr.c

sys/netinet6/nd6_rtr.c

sys/netinet6/raw_ip6.c

sys/netinet6/scope6.c

sys/netinet6/send.c

sys/netipsec/ipsec_input.c

sys/netpfil/ipfilter/netinet/ip_compat.h

sys/netpfil/ipfilter/netinet/ip_log.c

sys/netpfil/ipfw/ip_dn_io.c

IfAPI: Explicitly include <net/if_private.h> in netstack
AbandonedPublic
Actions

Revision Contents
Changeset List