stand: Make sure nobody has a NULL pointer for dv_cleanup
ClosedPublic
Actions

Authored by imp on Jul 25 2022, 8:32 PM.

Details

Reviewers

tsoome
kevans
manu

Group Reviewers

bhyve

Commits

rG538888eec5d7: stand: Make sure nobody has a NULL pointer for dv_cleanup
rGe98f952c8290: stand: Make sure nobody has a NULL pointer for dv_cleanup

Summary

dv_cleanup is specified almost everywhere. Use nullsys instead of NULL
to indicate 'do nothing'. Also, be consistent in trailing commas that
were missing before.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 46558
Build 43447: arc lint + arc unit

Event Timeline

imp created this revision.Jul 25 2022, 8:32 PM

Herald added a reviewer: manu. · View Herald TranscriptJul 25 2022, 8:32 PM

Herald added a reviewer: bhyve. · View Herald Transcript

Herald added subscribers: dab, bcran, rgrimes, delphij. · View Herald Transcript

imp requested review of this revision.Jul 25 2022, 8:32 PM

imp added a parent revision: D35912: stand: Add driver interface docs.

Harbormaster completed remote builds in B46558: Diff 108509.Jul 25 2022, 8:32 PM

imp added a child revision: D35914: stand: Change disk_fmtdev to take a struct devdesc *.Jul 25 2022, 8:32 PM

tsoome accepted this revision.Jul 25 2022, 8:34 PM

This revision is now accepted and ready to land.Jul 25 2022, 8:34 PM

Closed by commit rGe98f952c8290: stand: Make sure nobody has a NULL pointer for dv_cleanup (authored by imp). · Explain WhyJul 27 2022, 3:07 PM

This revision was automatically updated to reflect the committed changes.

imp added a commit: rGe98f952c8290: stand: Make sure nobody has a NULL pointer for dv_cleanup.

imp added a commit: rG538888eec5d7: stand: Make sure nobody has a NULL pointer for dv_cleanup.Jan 24 2023, 10:15 PM

Revision Contents
Changeset List

Path

Size

stand/

common/

md.c

1 line

vdisk.c

2 lines

efi/

libefi/

efihttp.c

2 lines

efinet.c

2 lines

efipart.c

6 lines

i386/

libi386/

biosdisk.c

6 lines

pxe.c

2 lines

kboot/

hostdisk.c

1 line

libofw/

ofw_disk.c

1 line

libsa/

zfs/

zfs.c

2 lines

userboot/

host.c

2 lines

Diff 108509

View Options

stand/common/md.c

View Options

stand/common/vdisk.c

View Options

stand/efi/libefi/efihttp.c

View Options

stand/efi/libefi/efinet.c

View Options

stand/efi/libefi/efipart.c

View Options

stand/i386/libi386/biosdisk.c

View Options

stand/i386/libi386/pxe.c

View Options

stand/kboot/hostdisk.c

View Options

stand/libofw/ofw_disk.c

View Options

stand/libsa/zfs/zfs.c

View Options

stand/userboot/userboot/host.c

stand: Make sure nobody has a NULL pointer for dv_cleanupClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 108509

stand/common/md.c

stand/common/vdisk.c

stand/efi/libefi/efihttp.c

stand/efi/libefi/efinet.c

stand/efi/libefi/efipart.c

stand/i386/libi386/biosdisk.c

stand/i386/libi386/pxe.c

stand/kboot/hostdisk.c

stand/libofw/ofw_disk.c

stand/libsa/zfs/zfs.c

stand/userboot/userboot/host.c

stand: Make sure nobody has a NULL pointer for dv_cleanup
ClosedPublic
Actions

Revision Contents
Changeset List