Page MenuHomeFreeBSD
Differential D35919

stand: Use devformat rather than disk_devfmt
ClosedPublic
Actions

Authored by imp on Jul 25 2022, 8:33 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, May 11, 8:23 PM
Unknown Object (File)
Wed, May 1, 1:10 PM
Unknown Object (File)
Wed, May 1, 1:09 PM
Unknown Object (File)
Wed, May 1, 1:09 PM
Unknown Object (File)
Wed, May 1, 1:09 PM
Unknown Object (File)
Wed, May 1, 6:11 AM
Unknown Object (File)
Apr 12 2024, 3:48 PM
Unknown Object (File)
Dec 20 2023, 7:58 AM
View All 27 Files
Subscribers
dab

Details

Reviewers
tsoome
kevans
manu
Commits
rGfe9661bce6a4: stand: Use devformat rather than disk_devfmt
rGec9f3e776f39: stand: Use devformat rather than disk_devfmt
Summary

Fix layering violation and use devformat to get the string
representation of the device to see if we're mounted yet or not. Remove
added include to pickup disk.h.

Sponsored by: Netflix

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

imp created this revision.Jul 25 2022, 8:33 PM
Herald added a reviewer: manu. · View Herald TranscriptJul 25 2022, 8:33 PM
Herald added a subscriber: dab. · View Herald Transcript
imp requested review of this revision.Jul 25 2022, 8:33 PM
Harbormaster completed remote builds in B46564: Diff 108515.Jul 25 2022, 8:33 PM
imp added a parent revision: D35918: stand: In geli, use devformat instead of disk_fmtdev.Jul 25 2022, 8:33 PM
imp added a child revision: D35920: stand: Remove unneeded include from geli.
tsoome accepted this revision.Jul 26 2022, 12:38 PM
This revision is now accepted and ready to land.Jul 26 2022, 12:38 PM
imp updated this revision to Diff 108656.Jul 28 2022, 4:58 PM

rebase

This revision now requires review to proceed.Jul 28 2022, 4:58 PM
Harbormaster completed remote builds in B46649: Diff 108656.Jul 28 2022, 4:58 PM
This revision was not accepted when it landed; it landed in state Needs Review.Aug 11 2022, 4:28 PM
Closed by commit rGec9f3e776f39: stand: Use devformat rather than disk_devfmt (authored by imp). · Explain Why
This revision was automatically updated to reflect the committed changes.
imp added a commit: rGec9f3e776f39: stand: Use devformat rather than disk_devfmt.
imp added a commit: rGfe9661bce6a4: stand: Use devformat rather than disk_devfmt.Jan 24 2023, 10:16 PM

Revision Contents
Changeset List

PathSize
stand/
libsa/
1 line
3 lines

Diff 109185

View Options

stand/libsa/Makefile

Loading...
View Options

stand/libsa/dosfs.c

Loading...