Page MenuHomeFreeBSD
Differential D35917

stand: Add disk_fmtdev for dv_fmtdev for all the disk devices
ClosedPublic
Actions

Authored by imp on Jul 25 2022, 8:33 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Jun 30, 10:10 PM
Unknown Object (File)
Mon, Jun 29, 6:29 PM
Unknown Object (File)
Sat, Jun 27, 5:18 PM
Unknown Object (File)
Mon, Jun 22, 5:24 PM
Unknown Object (File)
Tue, Jun 16, 9:29 AM
Unknown Object (File)
Mon, Jun 8, 6:26 AM
Unknown Object (File)
Jun 1 2026, 5:39 PM
Unknown Object (File)
Jun 1 2026, 1:04 PM
View All Files
Subscribers
bcran
dab
rgrimes

Details

Reviewers
tsoome
kevans
manu
Group Reviewers
bhyve
Commits
rGde252384c043: stand: Add disk_fmtdev for dv_fmtdev for all the disk devices
rGad759c73522e: stand: Add disk_fmtdev for dv_fmtdev for all the disk devices
Summary

All of the archsw fmtdev functions treat DEVT_DISK as a call to
disk_fmtdev. Set all disks' dv_fmtdev to disk_fmtdev so devformat
will return the same thing.

Sponsored by: Netflix

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

imp created this revision.Jul 25 2022, 8:33 PM
Herald added a reviewer: manu. · View Herald TranscriptJul 25 2022, 8:33 PM
Herald added a reviewer: bhyve. · View Herald Transcript
Herald added subscribers: dab, bcran, rgrimes. · View Herald Transcript
imp requested review of this revision.Jul 25 2022, 8:33 PM
Harbormaster completed remote builds in B46562: Diff 108513.Jul 25 2022, 8:33 PM
imp added a parent revision: D35916: stand: Add devformat to return formatted string for a device.Jul 25 2022, 8:33 PM
imp added a child revision: D35918: stand: In geli, use devformat instead of disk_fmtdev.
tsoome accepted this revision.Jul 26 2022, 12:27 PM
This revision is now accepted and ready to land.Jul 26 2022, 12:27 PM
imp updated this revision to Diff 108655.Jul 28 2022, 4:57 PM

rebase

This revision now requires review to proceed.Jul 28 2022, 4:57 PM
Harbormaster completed remote builds in B46648: Diff 108655.Jul 28 2022, 4:57 PM
This revision was not accepted when it landed; it landed in state Needs Review.Aug 11 2022, 4:28 PM
Closed by commit rGad759c73522e: stand: Add disk_fmtdev for dv_fmtdev for all the disk devices (authored by imp). · Explain Why
This revision was automatically updated to reflect the committed changes.
imp added a commit: rGad759c73522e: stand: Add disk_fmtdev for dv_fmtdev for all the disk devices.
imp added a commit: rGde252384c043: stand: Add disk_fmtdev for dv_fmtdev for all the disk devices.Jan 24 2023, 10:16 PM
imp mentioned this in D35918: stand: In geli, use devformat instead of disk_fmtdev.Oct 16 2024, 2:34 AM

Revision Contents
Changeset List

PathSize
stand/
common/
1 line
1 line
efi/
libefi/
1 line
i386/
libi386/
1 line
kboot/
2 lines
libofw/
3 lines
libsa/
geli/
3 lines
uboot/
1 line
usb/
storage/
1 line
userboot/
userboot/
1 line

Diff 109183

View Options

stand/common/md.c

Loading...
View Options

stand/common/vdisk.c

Loading...
View Options

stand/efi/libefi/efipart.c

Loading...
View Options

stand/i386/libi386/biosdisk.c

Loading...
View Options

stand/kboot/hostdisk.c

Loading...
View Options

stand/libofw/ofw_disk.c

Loading...
View Options

stand/libsa/geli/gelidev.c

Loading...
View Options

stand/uboot/uboot_disk.c

Loading...
View Options

stand/usb/storage/umass_loader.c

Loading...
View Options

stand/userboot/userboot/userboot_disk.c

Loading...