Tags

None

Referenced Files

	F142047411: D35928.id.diff
	Thu, Jan 15, 10:33 AM

	F142042816: D35928.diff
	Thu, Jan 15, 8:58 AM

	F142022405: D35928.id108604.diff
	Thu, Jan 15, 1:42 AM

	Unknown Object (File)
	Thu, Jan 8, 9:51 AM

	Unknown Object (File)
	Thu, Jan 8, 2:50 AM

	Unknown Object (File)
	Tue, Dec 30, 1:52 PM

	Unknown Object (File)
	Dec 15 2025, 1:39 AM

	Unknown Object (File)
	Dec 14 2025, 9:21 PM

View All Files

Subscribers

dab

Details

Reviewers

manu
tsoome
kevans

Commits

rG3f43420049bf: stand: tftp.c doesn't need bootinfo.h
rG60cb4f9a8e25: stand: tftp.c doesn't need bootinfo.h

Summary

tftp.c includes bootinfo.h, but doesn't need it. Remove it, and remove
the -Istand/common from CFALGS since that's the only reason we had it.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

imp created this revision.Jul 26 2022, 3:54 AM

Herald added a reviewer: manu. · View Herald TranscriptJul 26 2022, 3:54 AM

Herald added a subscriber: dab. · View Herald Transcript

imp requested review of this revision.Jul 26 2022, 3:54 AM

Harbormaster completed remote builds in B46574: Diff 108526.Jul 26 2022, 3:54 AM

imp added a parent revision: D35927: stand: i386_fmtdev can be reduced to devformat.Jul 26 2022, 3:55 AM

imp added reviewers: tsoome, kevans.Jul 26 2022, 3:59 AM

tsoome accepted this revision.Jul 26 2022, 12:32 PM

This revision is now accepted and ready to land.Jul 26 2022, 12:32 PM

Closed by commit rG60cb4f9a8e25: stand: tftp.c doesn't need bootinfo.h (authored by imp). · Explain WhyJul 27 2022, 3:07 PM

This revision was automatically updated to reflect the committed changes.

imp added a commit: rG60cb4f9a8e25: stand: tftp.c doesn't need bootinfo.h.

imp added a commit: rG3f43420049bf: stand: tftp.c doesn't need bootinfo.h.Jan 24 2023, 10:15 PM

stand: tftp.c doesn't need bootinfo.h
ClosedPublic
Actions

Details

Diff Detail

Event Timeline

Revision Contents
Changeset List

Diff 108604

stand/libsa/Makefile

stand/libsa/tftp.c

stand: tftp.c doesn't need bootinfo.hClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 108604

stand/libsa/Makefile

stand/libsa/tftp.c

stand: tftp.c doesn't need bootinfo.h
ClosedPublic
Actions

Revision Contents
Changeset List