Tags

None

Referenced Files

	F158018035: D35922.id.diff
	Wed, May 27, 1:15 PM

	F157980135: D35922.id108659.diff
	Wed, May 27, 2:59 AM

	Unknown Object (File)
	Tue, May 26, 2:56 AM

	Unknown Object (File)
	Tue, May 19, 9:33 AM

	Unknown Object (File)
	Mon, May 18, 9:56 PM

	Unknown Object (File)
	Mon, May 18, 7:37 PM

	Unknown Object (File)
	Sun, May 17, 11:45 PM

	Unknown Object (File)
	Fri, May 15, 11:11 AM

View All Files

Subscribers

dab

Details

Reviewers

tsoome
kevans
manu

Commits

rGec6d9023e56a: stand: Use devformat instead of disk_devfmt
rG0b3a4a588fb6: stand: Use devformat instead of disk_devfmt

Summary

Use devformat instead of disk_devfmt. This allows us to avoid knowing
the details of the device that's underneath us. Remove disk.h include
and the -I${LDRSRC} from the build of ufs.c since they are no longer
needed.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

imp created this revision.Jul 25 2022, 8:33 PM

Herald added a reviewer: manu. · View Herald TranscriptJul 25 2022, 8:33 PM

Herald added a subscriber: dab. · View Herald Transcript

imp requested review of this revision.Jul 25 2022, 8:33 PM

Harbormaster completed remote builds in B46567: Diff 108518.Jul 25 2022, 8:33 PM

imp added a parent revision: D35921: stand: Reduce number of files that need -I${LDRSRC}.Jul 25 2022, 8:33 PM

imp added a child revision: D35923: stand: For zfs, set dv_fmtdev to zfs_fmtdev.

rebase

Harbormaster completed remote builds in B46652: Diff 108659.Jul 28 2022, 4:58 PM

This revision was not accepted when it landed; it landed in state Needs Review.Aug 11 2022, 4:28 PM

Closed by commit rG0b3a4a588fb6: stand: Use devformat instead of disk_devfmt (authored by imp). · Explain Why

This revision was automatically updated to reflect the committed changes.

imp added a commit: rG0b3a4a588fb6: stand: Use devformat instead of disk_devfmt.

imp added a commit: rGec6d9023e56a: stand: Use devformat instead of disk_devfmt.Jan 24 2023, 10:16 PM

stand: Use devformat instead of disk_devfmt
ClosedPublic
Actions

Details

Diff Detail

Event Timeline

Revision Contents
Changeset List

Diff 109184

stand/libsa/Makefile

stand/libsa/ufs.c

stand: Use devformat instead of disk_devfmtClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 109184

stand/libsa/Makefile

stand/libsa/ufs.c

stand: Use devformat instead of disk_devfmt
ClosedPublic
Actions

Revision Contents
Changeset List