stand: Add dv_devfmt to return a string represenation of the device
ClosedPublic
Actions

Authored by imp on Jul 25 2022, 8:32 PM.

Details

Reviewers

tsoome
kevans
manu

Commits

rGe6cafedf0991: stand: Add dv_devfmt to return a string represenation of the device
rG4d4b1a298c84: stand: Add dv_devfmt to return a string represenation of the device

Summary

Add a new pointer, dv_devfmt, to allow devices to format themselves. We
will use this to simplify many of the fmtdev functions in the tree as
they are all almost the same, or all are isomorphic to each other.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

imp created this revision.Jul 25 2022, 8:32 PM

Herald added a reviewer: manu. · View Herald TranscriptJul 25 2022, 8:32 PM

Herald added a subscriber: dab. · View Herald Transcript

imp requested review of this revision.Jul 25 2022, 8:32 PM

Harbormaster completed remote builds in B46560: Diff 108511.Jul 25 2022, 8:32 PM

imp added a parent revision: D35914: stand: Change disk_fmtdev to take a struct devdesc *.Jul 25 2022, 8:32 PM

imp added a child revision: D35916: stand: Add devformat to return formatted string for a device.

tsoome added inline comments.Jul 25 2022, 10:13 PM

stand/libsa/stand.h
143	Is there more background for this specific size? I mean, we have DEV_NAMLEN + 10 chars in int + colon + NUL... asking because 128 bytes add up in text+data+bss of BIOS loader:)

imp added inline comments.Jul 25 2022, 10:40 PM

stand/libsa/stand.h
143	128 was used in a lot of places (see subsequent reviews) so I used that here. For disk devices, I don't see this ever being > diskXXXXsXXa: (so up to 10k disks, 100 partitions and maybe a bsd label for evilness). I'm not sure what a good limit is here, but in most loaders, this will just be 128 bytes once in the devformat static buffer.