Page MenuHomeFreeBSD
Differential D35927

stand: i386_fmtdev can be reduced to devformat
ClosedPublic
Actions

Authored by imp on Jul 25 2022, 8:34 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Nov 25, 12:33 PM
Unknown Object (File)
Nov 4 2025, 10:45 PM
Unknown Object (File)
Nov 4 2025, 11:27 AM
Unknown Object (File)
Nov 3 2025, 2:15 AM
Unknown Object (File)
Nov 3 2025, 1:47 AM
Unknown Object (File)
Nov 2 2025, 11:03 AM
Unknown Object (File)
Oct 29 2025, 6:43 AM
Unknown Object (File)
Oct 28 2025, 11:09 AM
View All Files
Subscribers
dab

Details

Reviewers
tsoome
kevans
manu
Commits
rG1c68ec6c69b5: stand: i386_fmtdev can be reduced to devformat
rG362322294045: stand: i386_fmtdev can be reduced to devformat
Summary

devformat produces the same output as i386_fmtdev, so just use it to
reduce on the dependencies.

Sponsored by: Netflix

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

imp created this revision.Jul 25 2022, 8:34 PM
Herald added a reviewer: manu. · View Herald TranscriptJul 25 2022, 8:34 PM
Herald added a subscriber: dab. · View Herald Transcript
imp requested review of this revision.Jul 25 2022, 8:34 PM
Harbormaster completed remote builds in B46572: Diff 108523.Jul 25 2022, 8:34 PM
imp added a parent revision: D35926: stand: uboot_fmtdev can be reduced to devformat.Jul 25 2022, 8:35 PM
imp added a child revision: D35928: stand: tftp.c doesn't need bootinfo.h.Jul 26 2022, 3:55 AM
tsoome accepted this revision.Jul 26 2022, 12:30 PM
This revision is now accepted and ready to land.Jul 26 2022, 12:30 PM
imp updated this revision to Diff 108665.Jul 28 2022, 5:00 PM

redo based on review feedback

This revision now requires review to proceed.Jul 28 2022, 5:00 PM
Harbormaster completed remote builds in B46658: Diff 108665.Jul 28 2022, 5:01 PM
This revision was not accepted when it landed; it landed in state Needs Review.Aug 11 2022, 4:28 PM
Closed by commit rG362322294045: stand: i386_fmtdev can be reduced to devformat (authored by imp). · Explain Why
This revision was automatically updated to reflect the committed changes.
imp added a commit: rG362322294045: stand: i386_fmtdev can be reduced to devformat.
imp added a commit: rG1c68ec6c69b5: stand: i386_fmtdev can be reduced to devformat.Jan 24 2023, 10:16 PM

Revision Contents
Changeset List

PathSize
stand/
i386/
libi386/
4 lines
2 lines
27 lines
loader/
4 lines

Diff 109191

View Options

stand/i386/libi386/bootinfo32.c

Loading...
View Options

stand/i386/libi386/bootinfo64.c

Loading...
View Options

stand/i386/libi386/devicename.c

Loading...
View Options

stand/i386/loader/main.c

Loading...