Page MenuHomeFreeBSD
Differential D58391

rc.subr: Fix premature return from wait_for_pids
ClosedPublic
Actions

Authored by des on Jul 22 2026, 8:18 AM.
Tags
None
Referenced Files
F171270193: D58391.diff
Thu, Sep 10, 12:27 AM
Unknown Object (File)
Sun, Sep 6, 1:27 PM
Unknown Object (File)
Sat, Sep 5, 12:08 PM
Unknown Object (File)
Sat, Sep 5, 8:32 AM
Unknown Object (File)
Fri, Sep 4, 3:48 PM
Unknown Object (File)
Fri, Sep 4, 12:53 AM
Unknown Object (File)
Thu, Sep 3, 11:57 PM
Unknown Object (File)
Thu, Sep 3, 10:42 PM
View All 100 Files
Subscribers
imp
markj

Details

Reviewers
dch
feld
markj
Group Reviewers
Klara
Commits
rG934fde21fa2b: rc.subr: Fix premature return from wait_for_pids
rG237ab146975b: rc.subr: Fix premature return from wait_for_pids
rG356d0b79cf6f: rc.subr: Fix premature return from wait_for_pids
Summary

Use pwait's new -r option to wait until the target processes have not
only terminated, but also been reaped.

PR: 293183
MFC after: 1 week
Sponsored by: Klara, Inc.
Sponsored by: NetApp, Inc.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

des created this revision.Jul 22 2026, 8:18 AM
Herald added a subscriber: imp. · View Herald TranscriptJul 22 2026, 8:18 AM
des requested review of this revision.Jul 22 2026, 8:18 AM
Harbormaster completed remote builds in B74998: Diff 182440.Jul 22 2026, 8:18 AM
des added a parent revision: D58314: pwait: Optionally wait until process is reaped.Jul 22 2026, 8:19 AM
des updated this revision to Diff 182442.Jul 22 2026, 8:28 AM

add a note in UPDATING

Harbormaster completed remote builds in B75000: Diff 182442.Jul 22 2026, 8:28 AM
markj accepted this revision as: markj.Jul 23 2026, 4:03 PM
markj added a subscriber: markj.

Should this have a Fixes: tag?

Maybe we should provide a backwards compat shim which checks whether the installed pwait supports -r and falls back to something else if not. I'm not sure if it's worth it.

UPDATING
34

I don't know what "fastboot" means, maybe write "use fastboot(8)" to be a bit more explicit.

This revision is now accepted and ready to land.Jul 23 2026, 4:03 PM
des marked an inline comment as done.Jul 23 2026, 4:41 PM
des updated this revision to Diff 182546.Jul 23 2026, 5:48 PM

rf

This revision now requires review to proceed.Jul 23 2026, 5:48 PM
Harbormaster completed remote builds in B75051: Diff 182546.Jul 23 2026, 5:48 PM
des updated this revision to Diff 182668.Jul 25 2026, 12:36 PM

simplify test

Harbormaster completed remote builds in B75121: Diff 182668.Jul 25 2026, 12:36 PM
des mentioned this in D58314: pwait: Optionally wait until process is reaped.Jul 26 2026, 9:38 AM
This revision was not accepted when it landed; it landed in state Needs Review.Jul 27 2026, 10:17 AM
Closed by commit rG356d0b79cf6f: rc.subr: Fix premature return from wait_for_pids (authored by des). · Explain Why
This revision was automatically updated to reflect the committed changes.
des added a commit: rG356d0b79cf6f: rc.subr: Fix premature return from wait_for_pids.
des added a commit: rG237ab146975b: rc.subr: Fix premature return from wait_for_pids.Aug 3 2026, 11:39 AM
des added a commit: rG934fde21fa2b: rc.subr: Fix premature return from wait_for_pids.

Revision Contents
Changeset List

PathSize
12 lines
libexec/
rc/
4 lines
tests/
20 lines

Diff 182770

View Options

UPDATING

Loading...
View Options

libexec/rc/rc.subr

Loading...
View Options

libexec/rc/tests/rc_subr_test.sh

Loading...