Paths

Table of Contentst

Differential D58386

pwait: Add a SIGINFO handler
ClosedPublic
Actions

Authored by des on Tue, Jul 21, 8:19 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Mon, Aug 10, 10:12 AM

	Unknown Object (File)
	Mon, Aug 10, 9:46 AM

	Unknown Object (File)
	Mon, Aug 10, 9:35 AM

	Unknown Object (File)
	Mon, Aug 10, 12:38 AM

	Unknown Object (File)
	Sun, Aug 9, 5:21 PM

	Unknown Object (File)
	Sun, Aug 9, 2:04 PM

	Unknown Object (File)
	Sun, Aug 9, 9:30 AM

	Unknown Object (File)
	Sun, Aug 9, 9:20 AM

View All 64 Files

Subscribers

Details

Reviewers

kib
kevans
markj

Group Reviewers

Commits

rG19723c77825e: pwait: Add a SIGINFO handler
rG236794f7c229: pwait: Add a SIGINFO handler
rGeddd8aa99ca8: pwait: Add a SIGINFO handler

Summary

On SIGINFO, print a space-separated list or remaining processes to
standard error.

MFC after: 1 week
Sponsored by: Klara, Inc.
Sponsored by: NetApp, Inc.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

des created this revision.Tue, Jul 21, 8:19 PM

Herald added a subscriber: imp. · View Herald TranscriptTue, Jul 21, 8:19 PM

des requested review of this revision.Tue, Jul 21, 8:19 PM

Harbormaster completed remote builds in B74990: Diff 182420.Tue, Jul 21, 8:19 PM

des added a child revision: D58385: pwait: Test the new -r option.Tue, Jul 21, 8:19 PM

kib accepted this revision.Wed, Jul 22, 1:17 AM

This revision is now accepted and ready to land.Wed, Jul 22, 1:17 AM

des edited the summary of this revision. (Show Details)Wed, Jul 22, 8:16 AM

update documentation

This revision now requires review to proceed.Wed, Jul 22, 8:17 AM

Herald added a subscriber: ziaee. · View Herald TranscriptWed, Jul 22, 8:17 AM

Harbormaster completed remote builds in B74996: Diff 182438.Wed, Jul 22, 8:17 AM

markj accepted this revision.Thu, Jul 23, 3:44 PM

This revision is now accepted and ready to land.Thu, Jul 23, 3:44 PM

des added a reviewer: Klara.Thu, Jul 23, 5:50 PM

use kevent() instead of a signal handler

This revision now requires review to proceed.Sat, Jul 25, 12:57 PM

Harbormaster completed remote builds in B75123: Diff 182671.Sat, Jul 25, 12:57 PM

kib added inline comments.Sat, Jul 25, 9:21 PM

bin/pwait/pwait.c
248	This is unreliable. We activate the signal knotes before even checking for the fact that the signal could be ignored. This allows more than one signal events to be lumped together. I think that the existing mechanism is better.

des added inline comments.Sun, Jul 26, 9:33 AM

bin/pwait/pwait.c
248	So what does the event look like if two signals are delivered simultaneously? The exiting mechanism was unfixably unreliable because there is no `pkevent()` so it was possible for `SIGINFO` to be delivered outside the `kevent()` call and be missed until after the next one returned.

kib added inline comments.Mon, Jul 27, 12:06 AM

bin/pwait/pwait.c
248	No, I was wrong. there is per-signal knotes. The knote list is shared with the EVFILT_PROC filter, but individual signals are counted separately. So for curproc, using the EVFILT_SIGNAL should be fine.

des marked 2 inline comments as done.Mon, Jul 27, 10:14 AM

This revision was not accepted when it landed; it landed in state Needs Review.Mon, Jul 27, 10:17 AM

Closed by commit rGeddd8aa99ca8: pwait: Add a SIGINFO handler (authored by des). · Explain Why

This revision was automatically updated to reflect the committed changes.

des added a commit: rGeddd8aa99ca8: pwait: Add a SIGINFO handler.

des added a commit: rG236794f7c229: pwait: Add a SIGINFO handler.Mon, Aug 3, 11:39 AM

des added a commit: rG19723c77825e: pwait: Add a SIGINFO handler.

Revision Contents
Changeset List

Path

Size

bin/

pwait/

13 lines

36 lines

Diff 182769

bin/pwait/pwait.1

Loading...

bin/pwait/pwait.c

Loading...