Page MenuHomeFreeBSD
Differential D48991

ObsoleteFiles.inc: Remove test debug file from wrong dir
ClosedPublic
Actions

Authored by jlduran on Thu, Feb 13, 3:41 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Feb 17, 7:42 AM
Unknown Object (File)
Thu, Feb 13, 3:49 PM
Subscribers
imp

Details

Reviewers
emaste
des
Commits
rGb6490ad408d0: ObsoleteFiles.inc: Remove test debug file from wrong dir
rG24d3fd31f805: ObsoleteFiles.inc: Remove test debug file from wrong dir
rGe159dcc37e6f: ObsoleteFiles.inc: Remove test debug file from wrong dir
Summary

Reported by: des
Fixes: 88d448ec815c ("mk: Move vm stack test debug symbols")

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

jlduran created this revision.Thu, Feb 13, 3:41 PM
Herald added a subscriber: imp. · View Herald TranscriptThu, Feb 13, 3:41 PM
jlduran requested review of this revision.Thu, Feb 13, 3:41 PM
Harbormaster completed remote builds in B62424: Diff 150963.Thu, Feb 13, 3:41 PM
jlduran edited the summary of this revision. (Show Details)Thu, Feb 13, 3:43 PM
emaste added a comment.Thu, Feb 13, 3:49 PM

Didn't notice this and submitted D48992 -- I'll close that one

emaste accepted this revision.Thu, Feb 13, 3:50 PM
emaste added inline comments.
ObsoleteFiles.inc
54

I'm not sure there's much value in putting this one with a new date header, it could just be added as a fix for the existing entry

This revision is now accepted and ready to land.Thu, Feb 13, 3:50 PM
emaste mentioned this in D48992: ObsoleteFiles.inc: Remove test debug file from wrong dir.Thu, Feb 13, 3:51 PM
des requested changes to this revision.Thu, Feb 13, 3:53 PM
des added inline comments.
ObsoleteFiles.inc
55

Just move this down to line 61 and drop the added comment

This revision now requires changes to proceed.Thu, Feb 13, 3:53 PM
jlduran updated this revision to Diff 150965.Thu, Feb 13, 3:56 PM

Address suggestions

Harbormaster completed remote builds in B62425: Diff 150965.Thu, Feb 13, 3:56 PM
jlduran edited the summary of this revision. (Show Details)Thu, Feb 13, 3:57 PM
emaste accepted this revision.Thu, Feb 13, 3:58 PM
jlduran retitled this revision from mk: Add missing obsolete file to ObsoleteFiles.inc: Remove test debug file from wrong dir.Thu, Feb 13, 3:58 PM
jlduran added a comment.Thu, Feb 13, 4:03 PM

MFC after: 3 days

jlduran marked 2 inline comments as done.Thu, Feb 13, 4:16 PM
des accepted this revision.Thu, Feb 13, 5:02 PM
This revision is now accepted and ready to land.Thu, Feb 13, 5:02 PM
Closed by commit rGe159dcc37e6f: ObsoleteFiles.inc: Remove test debug file from wrong dir (authored by jlduran). · Explain WhyThu, Feb 13, 5:06 PM
This revision was automatically updated to reflect the committed changes.
jlduran added a commit: rGe159dcc37e6f: ObsoleteFiles.inc: Remove test debug file from wrong dir.
jlduran added a commit: rG24d3fd31f805: ObsoleteFiles.inc: Remove test debug file from wrong dir.Sun, Feb 16, 4:16 AM
jlduran added a commit: rGb6490ad408d0: ObsoleteFiles.inc: Remove test debug file from wrong dir.

Revision Contents
Changeset List

PathSize
1 line

Diff 150983

View Options

ObsoleteFiles.inc

Loading...