kernel: Make some compiling time constant const
ClosedPublic
Actions

Authored by zlei on May 17 2024, 10:00 AM.

Details

Reviewers

imp
emaste
mjg
des
andrew
manu

Commits

rG356be1348dac: kernel: Make some compile time constant variables const

Summary

While reviewing D44760 I realized that the kernel version and some other
variables are generated by sys/conf/newvers.sh at compiling time. Given they
are not subjected to change, make them constant.

No functional change intended.

MFC after: ???

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

zlei created this revision.May 17 2024, 10:00 AM

Herald added a reviewer: andrew. · View Herald TranscriptMay 17 2024, 10:00 AM

Herald added a reviewer: andrew. · View Herald Transcript

Herald added a reviewer: manu. · View Herald Transcript

Herald added subscribers: riscv, olce, jhibbits, delphij. · View Herald Transcript

zlei requested review of this revision.May 17 2024, 10:00 AM

zlei added inline comments.May 17 2024, 10:05 AM

sys/conf/newvers.sh
321	Strictly these are KBI changes. But if we have never promised that those compile time constants can be altered by 3rd party modules, then this change is safe to MFC.

@khng I think with this change even shadowing those global variables can be easily caught.

Rebased to latest main.

Some has been committed separately.

7412517f2947 init_main: Sprinkle const qualifiers where appropriate
e2357561b949 FreeBSD: Add const qualifier to members of struct opensolaris_utsname
68c890b4433d linux(4): Add const qualifier to the value parameter of function handle_string()
92f2a4c820fe compat_freebsd4: Add const qualifier to the local variable s inside function freebsd4_uname()