Page MenuHomeFreeBSD
Differential D44760

fbt: Fix compiler warnings in CDDL fbt sources.
AcceptedPublic
Actions

Authored by khng on Apr 12 2024, 7:51 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Oct 15, 7:33 AM
Unknown Object (File)
Wed, Oct 15, 7:33 AM
Unknown Object (File)
Tue, Oct 14, 9:21 PM
Unknown Object (File)
Thu, Oct 2, 1:51 AM
Unknown Object (File)
Tue, Sep 30, 3:27 AM
Unknown Object (File)
Tue, Sep 30, 3:22 AM
Unknown Object (File)
Mon, Sep 29, 11:21 PM
Unknown Object (File)
Mon, Sep 29, 11:51 AM
View All Files
Subscribers
imp
markj
zlei

Details

Reviewers
markj
Summary

Mark unused arguments.

Avoid shadowing global variables.

Void cast the return of functions where the return value is
intentionally being ignored.

Handle signed/unsigned mismatches.

Obtained from: Juniper Networks, Inc.
MFC after: 1 week

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 57061
Build 53949: arc lint + arc unit

Event Timeline

khng created this revision.Apr 12 2024, 7:51 PM
Herald added a subscriber: imp. · View Herald TranscriptApr 12 2024, 7:51 PM
khng requested review of this revision.Apr 12 2024, 7:51 PM
Harbormaster completed remote builds in B57061: Diff 136954.Apr 12 2024, 7:51 PM
zlei added subscribers: markj, zlei.Apr 18 2024, 12:07 PM
zlei added inline comments.
sys/cddl/dev/fbt/fbt.c
442

The global var version is defined as extern char version[]; in sys/sys/system.h, and the implementation is generated by sys/conf/newvers.sh .

Since the global one has a different type char [], I think the shadowing should be easily caught by modern compilers.

PS: I'd prefer the shorter one ver rather than vers. The latter sounds like multiple version[s].

907

The parameter name should be unsigned. No idea why it was defined as int.
@markj
Do you have any clues ?

markj accepted this revision.Apr 18 2024, 3:32 PM
markj added inline comments.
sys/cddl/dev/fbt/fbt.c
907

I don't know offhand why it's signed. I can't see any (ab)use of that property.

Really the parameter should be size_t.

This revision is now accepted and ready to land.Apr 18 2024, 3:32 PM
zlei mentioned this in D45227: kernel: Make some compiling time constant const.May 17 2024, 10:00 AM
zlei mentioned this in rG356be1348dac: kernel: Make some compile time constant variables const.Aug 30 2024, 10:28 AM
zlei mentioned this in rG497f577f460b: kernel: Make some compile time constant variables const.Sep 20 2024, 10:05 AM
zlei mentioned this in rGe38f24446f09: kernel: Make some compile time constant variables const.Sep 21 2024, 4:19 AM

Revision Contents
Changeset List

PathSize
sys/
cddl/
dev/
fbt/
50 lines

Diff 136954

View Options

sys/cddl/dev/fbt/fbt.c

Loading...