Page MenuHomeFreeBSD
Differential D37209

tcp_rack: Add a manual page
ClosedPublic
Actions

Authored by gbe on Oct 29 2022, 7:49 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Oct 29, 4:07 AM
Unknown Object (File)
Sun, Oct 26, 5:12 PM
Unknown Object (File)
Sat, Oct 25, 5:45 PM
Unknown Object (File)
Wed, Oct 22, 11:06 PM
Unknown Object (File)
Thu, Oct 9, 12:31 PM
Unknown Object (File)
Thu, Oct 9, 12:30 PM
Unknown Object (File)
Thu, Oct 9, 12:30 PM
Unknown Object (File)
Thu, Oct 9, 12:30 PM
View All Files
Subscribers
imp
pauamma_gundo.com

Details

Reviewers
tuexen
rrs
pauamma_gundo.com
Group Reviewers
manpages
Commits
rGb1bcde8605fa: tcp_rack: Add a manual page
rGbdbc05bea995: tcp_rack: Add a manual page
Summary
  • Add a manual page for tcp_rack(4)
  • Link it in tcp(4) and tcp_bbr(4)

MFC after: 2 weeks

Test Plan

mandoc output review and mandoc '-Tlint' checks

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 48093
Build 44980: arc lint + arc unit

Event Timeline

gbe created this revision.Oct 29 2022, 7:49 PM
Herald added a subscriber: imp. · View Herald TranscriptOct 29 2022, 7:49 PM
gbe requested review of this revision.Oct 29 2022, 7:49 PM
Harbormaster completed remote builds in B48089: Diff 112387.Oct 29 2022, 7:49 PM
pauamma_gundo.com requested changes to this revision.Oct 29 2022, 10:16 PM
pauamma_gundo.com added a subscriber: pauamma_gundo.com.
pauamma_gundo.com added inline comments.
share/man/man4/tcp_rack.4
34

Also, "stack" feels wrong to me since this is about a module, not all of TCP, whether TCP is a stack by itself regardless. If not "module", maybe "algorithm"?

40

Is it a driver?

46

See above re "stack".

102

The variables below are in net.inet.tcp.rack, not net.inet.tcp.bbr.

This revision now requires changes to proceed.Oct 29 2022, 10:16 PM
gbe updated this revision to Diff 112401.Oct 30 2022, 7:32 AM
  • Some Corrections
Harbormaster completed remote builds in B48093: Diff 112401.Oct 30 2022, 7:32 AM
gbe marked 2 inline comments as done.Oct 30 2022, 7:33 AM

Mark some inline comments as done.

gbe updated this revision to Diff 112667.Nov 6 2022, 10:04 AM
  • Reword sentence
Harbormaster completed remote builds in B48181: Diff 112667.Nov 6 2022, 10:04 AM
gbe updated this revision to Diff 112668.Nov 6 2022, 10:07 AM
gbe marked an inline comment as done.
  • Reword sentence
Harbormaster completed remote builds in B48182: Diff 112668.Nov 6 2022, 10:07 AM
gbe marked an inline comment as done.Nov 6 2022, 10:07 AM

Address comments

share/man/man4/tcp_rack.4
34

"Stack" is more common word in this field, since we already have WITH_EXTRA_TCP_STACKS and so on.

pauamma_gundo.com accepted this revision.Nov 6 2022, 12:52 PM
This revision is now accepted and ready to land.Nov 6 2022, 12:52 PM
Closed by commit rGbdbc05bea995: tcp_rack: Add a manual page (authored by gbe). · Explain WhyNov 7 2022, 11:29 AM
This revision was automatically updated to reflect the committed changes.
gbe added a commit: rGbdbc05bea995: tcp_rack: Add a manual page.
gbe added a commit: rGb1bcde8605fa: tcp_rack: Add a manual page.Nov 21 2022, 7:22 AM

Revision Contents
Changeset List

PathSize
share/
man/
man4/
1 line
3 lines
5 lines
159 lines

Diff 112401

View Options

share/man/man4/Makefile

Loading...
View Options

share/man/man4/tcp.4

Loading...
View Options

share/man/man4/tcp_bbr.4

Loading...
View Options

share/man/man4/tcp_rack.4

Loading...