Page MenuHomeFreeBSD

man: Install more man pages unconditionally
ClosedPublic

Authored by fernape on Jul 4 2021, 4:34 PM.

Details

Summary

Add more manual pages which were not spotted previously in 0a0f7486413c147d56808b38055c40c64cff61f5

Reported by: ceri@
MFH: 4 weeks

Test Plan

make in share/man/man[589] and check the relevant manual pages are installed

Diff Detail

Repository
R10 FreeBSD src repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

If I unterstand this patch correctly it fix issues mostly on non amd64 architectures, and it will have no effect on amd64?

If I unterstand this patch correctly it fix issues mostly on non amd64 architectures, and it will have no effect on amd64?

Yes, the two man pages are always installed in amd64. This will install them in other architectures too. I admit this is hard to test. I don't have anything else than amd64.

Do you think we can move forward with this?

Do you think we can move forward with this?

Sure. I cannot test the patch myself because I have only amd64 machines. But it looks ok.

This revision was not accepted when it landed; it landed in state Needs Review.Aug 6 2021, 4:39 PM
This revision was automatically updated to reflect the committed changes.

Do you think we can move forward with this?

Sure. I cannot test the patch myself because I have only amd64 machines. But it looks ok.

Thanks for the comments, though!