man: Install more man pages unconditionally
ClosedPublic
Actions

Authored by fernape on Jul 4 2021, 4:34 PM.

Details

Reviewers

ceri
wosch

Commits

rGe6379a2c9546: man: Install more man pages unconditionally

Summary

Add more manual pages which were not spotted previously in 0a0f7486413c147d56808b38055c40c64cff61f5

Reported by: ceri@
MFH: 4 weeks

Test Plan

make in share/man/man[589] and check the relevant manual pages are installed

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

fernape created this revision.Jul 4 2021, 4:34 PM

Herald added a subscriber: imp. · View Herald TranscriptJul 4 2021, 4:34 PM

fernape requested review of this revision.Jul 4 2021, 4:34 PM

Harbormaster completed remote builds in B40261: Diff 91720.Jul 4 2021, 4:34 PM

If I unterstand this patch correctly it fix issues mostly on non amd64 architectures, and it will have no effect on amd64?

In D31018#701700, @wosch wrote:

If I unterstand this patch correctly it fix issues mostly on non amd64 architectures, and it will have no effect on amd64?

Yes, the two man pages are always installed in amd64. This will install them in other architectures too. I admit this is hard to test. I don't have anything else than amd64.

Do you think we can move forward with this?

In D31018#708622, @fernape wrote:

Do you think we can move forward with this?

Sure. I cannot test the patch myself because I have only amd64 machines. But it looks ok.

This revision was not accepted when it landed; it landed in state Needs Review.Aug 6 2021, 4:39 PM

Closed by commit rGe6379a2c9546: man: Install more man pages unconditionally (authored by fernape). · Explain Why

This revision was automatically updated to reflect the committed changes.

fernape added a commit: rGe6379a2c9546: man: Install more man pages unconditionally.

In D31018#708665, @wosch wrote:

In D31018#708622, @fernape wrote:

Do you think we can move forward with this?

Sure. I cannot test the patch myself because I have only amd64 machines. But it looks ok.