Page MenuHomeFreeBSD

regulator: Add manpage this framework
ClosedPublic

Authored by manu on Jun 14 2021, 4:36 PM.

Diff Detail

Repository
R10 FreeBSD src repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

manu requested review of this revision.Jun 14 2021, 4:36 PM
manu created this revision.
kp added inline comments.
share/man/man9/regulator.9
95

disables/decrements/frees?

102

increments?

108

decrements?

115

"This ensures the regulator..."?

116

"that has previously been enabled by ..."?

Couple of nits.

share/man/man9/regulator.9
85

This return code is repeated several times. Maybe a section on common return codes isn't bad?

125

I think s/is drought/is being drawn/ here. drought is weather where there's little water for a long time...
or '...too much current draw' is another form that I've seen.

128

I don't think micro-volts is hyphenated, but rather is just one word.

otherwise LGTM

share/man/man9/regulator.9
93

and it returns ENOENT if ofw property doesn't exist . The one can use this for detection optional regulator properties ( to distinguish property presence from other errors).

116

it returns EBUSY if any other consumer have it actually enabled (thus if regulator is shared and other driver have it enabled).

This revision is now accepted and ready to land.Jun 19 2021, 8:21 AM
This revision now requires review to proceed.Jun 19 2021, 8:37 AM
This revision is now accepted and ready to land.Jun 19 2021, 8:38 AM
This revision was automatically updated to reflect the committed changes.