Page MenuHomeFreeBSD

Use thunks for compat ioctls using struct ifgroupreq.
ClosedPublic

Authored by jhb on Apr 21 2021, 5:36 PM.

Details

Summary

Obtained from: CheriBSD
Sponsored by: DARPA

Diff Detail

Repository
rG FreeBSD src repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

jhb requested review of this revision.Apr 21 2021, 5:36 PM
This revision is now accepted and ready to land.Apr 21 2021, 8:58 PM
sys/net/if.c
2853

Why the change in {} is needed?

sys/net/if.c
2853

For the local 'ifgr' variable.

sys/net/if.c
2853

Ok, why is this one-time used variable needed? I mean, you can add ->ifgr_group to the cast expression and for me it is easier to understand.

sys/net/if.c
2853

Ah, this was matching the original code before the addition of ifgr_group_get(). I can make it do it without a local variable though.

jhb marked 2 inline comments as done.May 4 2021, 6:23 PM
This revision now requires review to proceed.May 4 2021, 6:26 PM
kib added inline comments.
sys/net/if.c
2848–2849

Since you change around these lines, you could also introduce your preferred way to write it

error = if_addgroup(ifp, ...);
if (error != 0)
     return (error);

I am fine either way.

2868–2869

Same there.

This revision is now accepted and ready to land.May 4 2021, 8:45 PM
jhb marked 2 inline comments as done.May 5 2021, 9:03 PM
jhb added inline comments.
sys/net/if.c
2848–2849

I almost did, so this prod is enough for me to fix it. Thanks.