Page MenuHomeFreeBSD

ed (Ed Schouten)
User

Projects

User Details

User Since
Sep 28 2014, 1:01 PM (207 w, 2 d)

Recent Activity

Sat, Sep 15

ed added a comment to D17083: Alter the prototype of qsort_r(3) to match glibc..

Antoine just gave me the results for an exp-run with this change applied: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=231256

Sat, Sep 15, 8:36 AM

Thu, Sep 13

ed committed rP479692: lang/ruby2[345]: Improve qsort_r() detection.
lang/ruby2[345]: Improve qsort_r() detection
Thu, Sep 13, 7:26 PM
ed closed D17157: lang/ruby2[345]: Improve qsort_r() detection.
Thu, Sep 13, 7:26 PM
ed created D17157: lang/ruby2[345]: Improve qsort_r() detection.
Thu, Sep 13, 7:17 PM

Mon, Sep 10

ed added a comment to D17040: Enable WITHOUT_INET* WITHOUT_CRYPT WITHOUT_OPENSSL, WITHOUT_FILE.

@ed can we get this added to the CI work load as a once a week type run? IIRC it takes a 16 core machine about 3 days to run build_option_survey.sh

Mon, Sep 10, 5:07 PM
ed added a comment to D17083: Alter the prototype of qsort_r(3) to match glibc..

Hi Conrad,

Mon, Sep 10, 8:21 AM

Sun, Sep 9

ed added reviewers for D17083: Alter the prototype of qsort_r(3) to match glibc.: cem, jilles.
Sun, Sep 9, 8:14 AM
ed added a comment to D17083: Alter the prototype of qsort_r(3) to match glibc..

It looks like I'm quite the forgetful person. In D9169, cem@ tried to solve the same thing. Eventually he abandoned the idea, because we weren't able to accurately implement the __generic() matching to filter out bad calls.

Sun, Sep 9, 8:14 AM
ed updated the diff for D17083: Alter the prototype of qsort_r(3) to match glibc..

Add logic to explictly make old calls to qsort_r(3) fail.

Sun, Sep 9, 6:03 AM
ed added a comment to D17083: Alter the prototype of qsort_r(3) to match glibc..

It's a fair point you two are making: with the change I sent out, code that calls qsort_r() in the existing way will compile without any warnings/errors. This is why I've just changed my patch to add some logic to stdlib.h and libkern.h to detect bad calls, similar to how we dealt with the dirname() / basename() transition (libgen.h). Calls to qsort_r() with the comparator as the last argument will fail explictly.

Sun, Sep 9, 6:03 AM

Sat, Sep 8

ed created D17083: Alter the prototype of qsort_r(3) to match glibc..
Sat, Sep 8, 10:20 PM

Mon, Sep 3

ed created D16999: net/uriparser: Upgrade to 0.8.6..
Mon, Sep 3, 6:39 AM

Sat, Sep 1

ed abandoned D14250: [net/uriparser] Update to v0.8.5..

Uriparser 0.8.6 has been released in the meantime.

Sat, Sep 1, 2:52 PM

Mon, Aug 27

ed committed rS338334: MFC r336086:.
MFC r336086:
Mon, Aug 27, 7:33 AM

Aug 2 2018

ed accepted D16561: Free rights in truncated control messages..

Looks good. Thanks a lot for working on this!

Aug 2 2018, 6:14 AM

Jul 15 2018

ed committed rS336304: MFC r336060:.
MFC r336060:
Jul 15 2018, 1:50 PM

Jul 8 2018

ed committed rS336086: Use the FQDN in the newsyslog log message when RFC 5424 is enabled..
Use the FQDN in the newsyslog log message when RFC 5424 is enabled.
Jul 8 2018, 10:08 AM

Jul 7 2018

ed committed rS336060: Allow the use of slashes in process names of RFC 3164 formatted messages..
Allow the use of slashes in process names of RFC 3164 formatted messages.
Jul 7 2018, 11:54 AM
ed committed rS336059: MFC r335862:.
MFC r335862:
Jul 7 2018, 11:39 AM
ed committed rS336058: MFC r335861:.
MFC r335861:
Jul 7 2018, 11:39 AM

Jul 2 2018

ed committed rS335862: Document that syslogd -v has no effect when RFC 5424 mode is enabled..
Document that syslogd -v has no effect when RFC 5424 mode is enabled.
Jul 2 2018, 11:02 AM
ed committed rS335861: Restore the order in which RFC 3164 messages with fac/pri are formatted..
Restore the order in which RFC 3164 messages with fac/pri are formatted.
Jul 2 2018, 10:57 AM

Jun 28 2018

ed committed rS335761: MFC r335565:.
MFC r335565:
Jun 28 2018, 12:55 PM

Jun 25 2018

ed committed rS335613: Fix spelling of "reclamation"..
Fix spelling of "reclamation".
Jun 25 2018, 6:57 AM

Jun 22 2018

ed committed rS335565: Still parse messages that don't contain an RFC 3164 timestamp..
Still parse messages that don't contain an RFC 3164 timestamp.
Jun 22 2018, 8:53 PM

Jun 21 2018

ed committed rS335492: MFC r335314:.
MFC r335314:
Jun 21 2018, 4:12 PM

Jun 18 2018

ed committed rS335314: Fix bad logic in iovlist_truncate()..
Fix bad logic in iovlist_truncate().
Jun 18 2018, 6:01 AM

Jun 13 2018

ed committed rS335059: MFC r309925, r309931, r309933, r310035, r310278, r310310, r310311,.
MFC r309925, r309931, r309933, r310035, r310278, r310310, r310311,
Jun 13 2018, 1:41 PM

Apr 20 2018

ed accepted D15021: Wakup applications with shutdown on listen sockets (stable/11 version).
Apr 20 2018, 1:54 PM

Apr 15 2018

ed committed rS332511: Use proper alphabetic sorting of options..
Use proper alphabetic sorting of options.
Apr 15 2018, 8:44 AM
ed committed rS332510: Add RFC 5424 syslog message output to syslogd..
Add RFC 5424 syslog message output to syslogd.
Apr 15 2018, 8:34 AM
ed closed D15011: Add RFC 5424 syslog message output to syslogd..
Apr 15 2018, 8:34 AM

Apr 12 2018

ed added a comment to D15011: Add RFC 5424 syslog message output to syslogd..

Ben: any final thoughts before I commit this?

Apr 12 2018, 9:22 AM

Apr 9 2018

ed updated the diff for D15011: Add RFC 5424 syslog message output to syslogd..

Process woodsb02's feedback.

Apr 9 2018, 8:08 PM
ed added a comment to D15011: Add RFC 5424 syslog message output to syslogd..

Hi Ben,

Apr 9 2018, 8:08 PM

Apr 8 2018

ed added inline comments to D15011: Add RFC 5424 syslog message output to syslogd..
Apr 8 2018, 4:06 PM
ed updated the diff for D15011: Add RFC 5424 syslog message output to syslogd..

Process feedback from kib@.

Apr 8 2018, 4:04 PM
ed updated the diff for D15011: Add RFC 5424 syslog message output to syslogd..

Don't conditionalize the addition of the pointer.

Apr 8 2018, 2:32 PM
ed updated the diff for D15011: Add RFC 5424 syslog message output to syslogd..

Always show the <PRI>VERSION. Don't let it depend on LogFacPri.

Apr 8 2018, 2:23 PM
ed created D15011: Add RFC 5424 syslog message output to syslogd..
Apr 8 2018, 7:40 AM

Apr 7 2018

ed committed rS332165: Fix enough warnings that we can build syslogd on all targets at WARNS=6..
Fix enough warnings that we can build syslogd on all targets at WARNS=6.
Apr 7 2018, 9:04 AM

Apr 6 2018

ed committed rS332118: Push RFC 5424 message format from logmsg() into fprintlog()..
Push RFC 5424 message format from logmsg() into fprintlog().
Apr 6 2018, 5:17 PM
ed committed rS332111: Remove some places where error messages are prefixed with "syslogd"..
Remove some places where error messages are prefixed with "syslogd".
Apr 6 2018, 4:26 PM
ed committed rS332110: Properly respect the passed in hostname for RFC 5424 messages..
Properly respect the passed in hostname for RFC 5424 messages.
Apr 6 2018, 4:24 PM
ed abandoned D14951: Let syslog(3) use RFC 5424..

Oops! Accidentally used the wrong differential revision in the commit message. This was committed as r332100.

Apr 6 2018, 1:05 PM
ed committed rD51538: Document __FreeBSD_version 1200061..
Document __FreeBSD_version 1200061.
Apr 6 2018, 1:05 PM
ed committed rS332100: Let syslog(3) use RFC 5424..
Let syslog(3) use RFC 5424.
Apr 6 2018, 1:01 PM
ed committed rS332099: Add RFC 5424 syslog message parsing to syslogd..
Add RFC 5424 syslog message parsing to syslogd.
Apr 6 2018, 12:57 PM
ed closed D14926: Add RFC 5424 syslog message parsing to syslogd..
Apr 6 2018, 12:57 PM

Apr 5 2018

ed added a comment to D14926: Add RFC 5424 syslog message parsing to syslogd..

Hi Ben,

Apr 5 2018, 12:38 PM

Apr 4 2018

ed updated the diff for D14951: Let syslog(3) use RFC 5424..

Make the scope of what is affected a bit more explicit.

Apr 4 2018, 5:16 PM
ed added a comment to D14951: Let syslog(3) use RFC 5424..

Thanks for your input, Kostik. What do you think about this version?

Apr 4 2018, 4:20 PM
ed updated the diff for D14951: Let syslog(3) use RFC 5424..

Extend the UPDATING note.

Apr 4 2018, 4:20 PM
ed updated the diff for D14951: Let syslog(3) use RFC 5424..

Add a note to UPDATING regarding this change.

Apr 4 2018, 8:54 AM
ed added a comment to D14951: Let syslog(3) use RFC 5424..
In D14951#314438, @ed wrote:

There are some alternatives, such as syslog-ng and rsyslog. Documentation indicates that these also support RFC 5424 properly. I will, however, check this to be sure.

Apr 4 2018, 8:29 AM

Apr 3 2018

ed updated the diff for D14951: Let syslog(3) use RFC 5424..

Process feedback provided by kib@.

Apr 3 2018, 8:47 PM
ed added a comment to D14951: Let syslog(3) use RFC 5424..

Hi Kostik,

Apr 3 2018, 8:47 PM
ed created D14951: Let syslog(3) use RFC 5424..
Apr 3 2018, 5:30 PM
ed updated the diff for D14926: Add RFC 5424 syslog message parsing to syslogd..

Make minor changes based on woodsb02's feedback.

Apr 3 2018, 7:30 AM
ed added inline comments to D14926: Add RFC 5424 syslog message parsing to syslogd..
Apr 3 2018, 7:29 AM

Apr 2 2018

ed updated the diff for D14926: Add RFC 5424 syslog message parsing to syslogd..

Respect RemoteAddDate (-T) for RFC 5424 messages.

Apr 2 2018, 4:09 PM
ed added inline comments to D14926: Add RFC 5424 syslog message parsing to syslogd..
Apr 2 2018, 2:54 PM
ed updated the diff for D14926: Add RFC 5424 syslog message parsing to syslogd..

Process the excellent feedback given by woodsb02@. Thanks!

Apr 2 2018, 2:54 PM

Apr 1 2018

ed updated the diff for D14926: Add RFC 5424 syslog message parsing to syslogd..

Add explicit buffer size to parsemsg_remove_unsafe_characters().

Apr 1 2018, 8:42 PM
ed updated the summary of D14926: Add RFC 5424 syslog message parsing to syslogd..
Apr 1 2018, 8:14 PM
ed added a reviewer for D14926: Add RFC 5424 syslog message parsing to syslogd.: woodsb02.
Apr 1 2018, 7:34 PM
ed added reviewers for D14926: Add RFC 5424 syslog message parsing to syslogd.: hrs, sobomax.
Apr 1 2018, 6:38 PM
ed created D14926: Add RFC 5424 syslog message parsing to syslogd..
Apr 1 2018, 6:30 PM

Mar 24 2018

ed accepted D12785: New gets_s(3) stdio function.

Looks good to me. Thanks!

Mar 24 2018, 8:03 AM

Mar 12 2018

ed accepted D14674: Use the stack for temporary storage in OTIOCCONS..
Mar 12 2018, 9:56 PM

Feb 9 2018

ed updated the diff for D14250: [net/uriparser] Update to v0.8.5..

While there, make use of GitHub instead of SourceForge.

Feb 9 2018, 7:30 PM
ed updated the diff for D14250: [net/uriparser] Update to v0.8.5..

Revert unnecessary changs to other ports.

Feb 9 2018, 7:08 PM

Feb 7 2018

ed created D14250: [net/uriparser] Update to v0.8.5..
Feb 7 2018, 6:58 PM

Jan 30 2018

ed committed rP460378: Upgrade all CloudABI components to their latest upstream versions..
Upgrade all CloudABI components to their latest upstream versions.
Jan 30 2018, 9:12 AM
ed closed D14076: Upgrade all CloudABI components to their latest upstream versions..
Jan 30 2018, 9:12 AM

Jan 27 2018

ed created D14076: Upgrade all CloudABI components to their latest upstream versions..
Jan 27 2018, 6:54 PM

Jan 19 2018

ed added a comment to D13975: Add info about c99 designationed initializers..

Is there a need to describe how these should be formatted? Can we place multiple initializers on one line, or should they all be placed on a separate one? Tabs before the = to align them?

Jan 19 2018, 10:26 AM

Jan 18 2018

ed committed rS328127: MFC r327560:.
MFC r327560:
Jan 18 2018, 1:43 PM

Jan 17 2018

ed closed D13951: Upgrade bddsolve to version 1.04..
Jan 17 2018, 2:28 PM
ed committed rP459258: Upgrade bddsolve to version 1.04..
Upgrade bddsolve to version 1.04.
Jan 17 2018, 2:28 PM
ed created D13951: Upgrade bddsolve to version 1.04..
Jan 17 2018, 12:14 PM

Jan 7 2018

ed committed rS327684: Use mallocarray(9) in CloudABI kernel code where possible..
Use mallocarray(9) in CloudABI kernel code where possible.
Jan 7 2018, 10:39 PM

Jan 6 2018

ed committed rP458292: sysutils/cloudabi-utils: Upgrade to upstream version 0.36..
sysutils/cloudabi-utils: Upgrade to upstream version 0.36.
Jan 6 2018, 9:22 PM
ed closed D13786: sysutils/cloudabi-utils: Upgrade to upstream version 0.36..
Jan 6 2018, 9:22 PM
ed created D13786: sysutils/cloudabi-utils: Upgrade to upstream version 0.36..
Jan 6 2018, 9:16 PM

Jan 4 2018

ed committed rS327560: Allow timed waits with relative timeouts on locks and condvars..
Allow timed waits with relative timeouts on locks and condvars.
Jan 4 2018, 9:58 PM

Dec 28 2017

ed accepted D13670: Make dtraceall loadable again on arm64.
Dec 28 2017, 9:39 PM

Dec 21 2017

ed committed rS327057: Make truss work for CloudABI executables on i386..
Make truss work for CloudABI executables on i386.
Dec 21 2017, 9:22 AM

Dec 20 2017

ed committed rS327022: Make truss(8) work for 32-bit CloudABI executables on ARM64..
Make truss(8) work for 32-bit CloudABI executables on ARM64.
Dec 20 2017, 1:13 PM

Dec 16 2017

ed committed rS326911: Make truss(8) work for i686-unknown-cloudabi binaries on FreeBSD/amd64..
Make truss(8) work for i686-unknown-cloudabi binaries on FreeBSD/amd64.
Dec 16 2017, 7:40 PM
ed committed rS326910: libsysdecode: Add a new ABI type, SYSDECODE_ABI_CLOUDABI32..
libsysdecode: Add a new ABI type, SYSDECODE_ABI_CLOUDABI32.
Dec 16 2017, 7:38 PM
ed closed D13516: Make truss(8) work for i686-unknown-cloudabi binaries on FreeBSD/amd64..
Dec 16 2017, 7:38 PM
ed created D13516: Make truss(8) work for i686-unknown-cloudabi binaries on FreeBSD/amd64..
Dec 16 2017, 6:19 PM

Dec 10 2017

ed committed rS326743: MFC r326228 and r326229:.
MFC r326228 and r326229:
Dec 10 2017, 12:25 PM

Dec 8 2017

ed committed rS326719: Remove basename_r(3)..
Remove basename_r(3).
Dec 8 2017, 10:06 PM
ed committed rS326681: MFC r326420:.
MFC r326420:
Dec 8 2017, 5:57 AM

Dec 3 2017

ed added a comment to D13311: Make COMPAT_FREEBSD32 part of GENERIC on arm64..

Hi Andrew,

Dec 3 2017, 7:30 PM
ed closed D13311: Make COMPAT_FREEBSD32 part of GENERIC on arm64..
Dec 3 2017, 7:26 PM
ed committed rS326501: Make COMPAT_FREEBSD32 part of GENERIC on arm64..
Make COMPAT_FREEBSD32 part of GENERIC on arm64.
Dec 3 2017, 7:26 PM

Dec 1 2017

ed committed rS326423: Eliminate the last user of basename_r() in the base system..
Eliminate the last user of basename_r() in the base system.
Dec 1 2017, 10:26 AM