ed (Ed Schouten)
User

Projects

User Details

User Since
Sep 28 2014, 1:01 PM (195 w, 1 d)

Recent Activity

Today

ed committed rS335613: Fix spelling of "reclamation"..
Fix spelling of "reclamation".
Mon, Jun 25, 6:57 AM

Fri, Jun 22

ed committed rS335565: Still parse messages that don't contain an RFC 3164 timestamp..
Still parse messages that don't contain an RFC 3164 timestamp.
Fri, Jun 22, 8:53 PM

Thu, Jun 21

ed committed rS335492: MFC r335314:.
MFC r335314:
Thu, Jun 21, 4:12 PM

Mon, Jun 18

ed committed rS335314: Fix bad logic in iovlist_truncate()..
Fix bad logic in iovlist_truncate().
Mon, Jun 18, 6:01 AM

Wed, Jun 13

ed committed rS335059: MFC r309925, r309931, r309933, r310035, r310278, r310310, r310311,.
MFC r309925, r309931, r309933, r310035, r310278, r310310, r310311,
Wed, Jun 13, 1:41 PM

Apr 20 2018

ed accepted D15021: Wakup applications with shutdown on listen sockets (stable/11 version).
Apr 20 2018, 1:54 PM

Apr 15 2018

ed committed rS332511: Use proper alphabetic sorting of options..
Use proper alphabetic sorting of options.
Apr 15 2018, 8:44 AM
ed committed rS332510: Add RFC 5424 syslog message output to syslogd..
Add RFC 5424 syslog message output to syslogd.
Apr 15 2018, 8:34 AM
ed closed D15011: Add RFC 5424 syslog message output to syslogd..
Apr 15 2018, 8:34 AM

Apr 12 2018

ed added a comment to D15011: Add RFC 5424 syslog message output to syslogd..

Ben: any final thoughts before I commit this?

Apr 12 2018, 9:22 AM

Apr 9 2018

ed updated the diff for D15011: Add RFC 5424 syslog message output to syslogd..

Process woodsb02's feedback.

Apr 9 2018, 8:08 PM
ed added a comment to D15011: Add RFC 5424 syslog message output to syslogd..

Hi Ben,

Apr 9 2018, 8:08 PM

Apr 8 2018

ed added inline comments to D15011: Add RFC 5424 syslog message output to syslogd..
Apr 8 2018, 4:06 PM
ed updated the diff for D15011: Add RFC 5424 syslog message output to syslogd..

Process feedback from kib@.

Apr 8 2018, 4:04 PM
ed updated the diff for D15011: Add RFC 5424 syslog message output to syslogd..

Don't conditionalize the addition of the pointer.

Apr 8 2018, 2:32 PM
ed updated the diff for D15011: Add RFC 5424 syslog message output to syslogd..

Always show the <PRI>VERSION. Don't let it depend on LogFacPri.

Apr 8 2018, 2:23 PM
ed created D15011: Add RFC 5424 syslog message output to syslogd..
Apr 8 2018, 7:40 AM

Apr 7 2018

ed committed rS332165: Fix enough warnings that we can build syslogd on all targets at WARNS=6..
Fix enough warnings that we can build syslogd on all targets at WARNS=6.
Apr 7 2018, 9:04 AM

Apr 6 2018

ed committed rS332118: Push RFC 5424 message format from logmsg() into fprintlog()..
Push RFC 5424 message format from logmsg() into fprintlog().
Apr 6 2018, 5:17 PM
ed committed rS332111: Remove some places where error messages are prefixed with "syslogd"..
Remove some places where error messages are prefixed with "syslogd".
Apr 6 2018, 4:26 PM
ed committed rS332110: Properly respect the passed in hostname for RFC 5424 messages..
Properly respect the passed in hostname for RFC 5424 messages.
Apr 6 2018, 4:24 PM
ed abandoned D14951: Let syslog(3) use RFC 5424..

Oops! Accidentally used the wrong differential revision in the commit message. This was committed as r332100.

Apr 6 2018, 1:05 PM
ed committed rD51538: Document __FreeBSD_version 1200061..
Document __FreeBSD_version 1200061.
Apr 6 2018, 1:05 PM
ed committed rS332100: Let syslog(3) use RFC 5424..
Let syslog(3) use RFC 5424.
Apr 6 2018, 1:01 PM
ed committed rS332099: Add RFC 5424 syslog message parsing to syslogd..
Add RFC 5424 syslog message parsing to syslogd.
Apr 6 2018, 12:57 PM
ed closed D14926: Add RFC 5424 syslog message parsing to syslogd..
Apr 6 2018, 12:57 PM

Apr 5 2018

ed added a comment to D14926: Add RFC 5424 syslog message parsing to syslogd..

Hi Ben,

Apr 5 2018, 12:38 PM

Apr 4 2018

ed updated the diff for D14951: Let syslog(3) use RFC 5424..

Make the scope of what is affected a bit more explicit.

Apr 4 2018, 5:16 PM
ed added a comment to D14951: Let syslog(3) use RFC 5424..

Thanks for your input, Kostik. What do you think about this version?

Apr 4 2018, 4:20 PM
ed updated the diff for D14951: Let syslog(3) use RFC 5424..

Extend the UPDATING note.

Apr 4 2018, 4:20 PM
ed updated the diff for D14951: Let syslog(3) use RFC 5424..

Add a note to UPDATING regarding this change.

Apr 4 2018, 8:54 AM
ed added a comment to D14951: Let syslog(3) use RFC 5424..
In D14951#314438, @ed wrote:

There are some alternatives, such as syslog-ng and rsyslog. Documentation indicates that these also support RFC 5424 properly. I will, however, check this to be sure.

Apr 4 2018, 8:29 AM

Apr 3 2018

ed updated the diff for D14951: Let syslog(3) use RFC 5424..

Process feedback provided by kib@.

Apr 3 2018, 8:47 PM
ed added a comment to D14951: Let syslog(3) use RFC 5424..

Hi Kostik,

Apr 3 2018, 8:47 PM
ed created D14951: Let syslog(3) use RFC 5424..
Apr 3 2018, 5:30 PM
ed updated the diff for D14926: Add RFC 5424 syslog message parsing to syslogd..

Make minor changes based on woodsb02's feedback.

Apr 3 2018, 7:30 AM
ed added inline comments to D14926: Add RFC 5424 syslog message parsing to syslogd..
Apr 3 2018, 7:29 AM

Apr 2 2018

ed updated the diff for D14926: Add RFC 5424 syslog message parsing to syslogd..

Respect RemoteAddDate (-T) for RFC 5424 messages.

Apr 2 2018, 4:09 PM
ed added inline comments to D14926: Add RFC 5424 syslog message parsing to syslogd..
Apr 2 2018, 2:54 PM
ed updated the diff for D14926: Add RFC 5424 syslog message parsing to syslogd..

Process the excellent feedback given by woodsb02@. Thanks!

Apr 2 2018, 2:54 PM

Apr 1 2018

ed updated the diff for D14926: Add RFC 5424 syslog message parsing to syslogd..

Add explicit buffer size to parsemsg_remove_unsafe_characters().

Apr 1 2018, 8:42 PM
ed updated the summary of D14926: Add RFC 5424 syslog message parsing to syslogd..
Apr 1 2018, 8:14 PM
ed added a reviewer for D14926: Add RFC 5424 syslog message parsing to syslogd.: woodsb02.
Apr 1 2018, 7:34 PM
ed added reviewers for D14926: Add RFC 5424 syslog message parsing to syslogd.: hrs, sobomax.
Apr 1 2018, 6:38 PM
ed created D14926: Add RFC 5424 syslog message parsing to syslogd..
Apr 1 2018, 6:30 PM

Mar 24 2018

ed accepted D12785: New gets_s(3) stdio function.

Looks good to me. Thanks!

Mar 24 2018, 8:03 AM

Mar 12 2018

ed accepted D14674: Use the stack for temporary storage in OTIOCCONS..
Mar 12 2018, 9:56 PM

Feb 9 2018

ed updated the diff for D14250: [net/uriparser] Update to v0.8.5..

While there, make use of GitHub instead of SourceForge.

Feb 9 2018, 7:30 PM
ed updated the diff for D14250: [net/uriparser] Update to v0.8.5..

Revert unnecessary changs to other ports.

Feb 9 2018, 7:08 PM

Feb 7 2018

ed created D14250: [net/uriparser] Update to v0.8.5..
Feb 7 2018, 6:58 PM

Jan 30 2018

ed committed rP460378: Upgrade all CloudABI components to their latest upstream versions..
Upgrade all CloudABI components to their latest upstream versions.
Jan 30 2018, 9:12 AM
ed closed D14076: Upgrade all CloudABI components to their latest upstream versions..
Jan 30 2018, 9:12 AM

Jan 27 2018

ed created D14076: Upgrade all CloudABI components to their latest upstream versions..
Jan 27 2018, 6:54 PM

Jan 19 2018

ed added a comment to D13975: Add info about c99 designationed initializers..

Is there a need to describe how these should be formatted? Can we place multiple initializers on one line, or should they all be placed on a separate one? Tabs before the = to align them?

Jan 19 2018, 10:26 AM

Jan 18 2018

ed committed rS328127: MFC r327560:.
MFC r327560:
Jan 18 2018, 1:43 PM

Jan 17 2018

ed closed D13951: Upgrade bddsolve to version 1.04..
Jan 17 2018, 2:28 PM
ed committed rP459258: Upgrade bddsolve to version 1.04..
Upgrade bddsolve to version 1.04.
Jan 17 2018, 2:28 PM
ed created D13951: Upgrade bddsolve to version 1.04..
Jan 17 2018, 12:14 PM

Jan 7 2018

ed committed rS327684: Use mallocarray(9) in CloudABI kernel code where possible..
Use mallocarray(9) in CloudABI kernel code where possible.
Jan 7 2018, 10:39 PM

Jan 6 2018

ed committed rP458292: sysutils/cloudabi-utils: Upgrade to upstream version 0.36..
sysutils/cloudabi-utils: Upgrade to upstream version 0.36.
Jan 6 2018, 9:22 PM
ed closed D13786: sysutils/cloudabi-utils: Upgrade to upstream version 0.36..
Jan 6 2018, 9:22 PM
ed created D13786: sysutils/cloudabi-utils: Upgrade to upstream version 0.36..
Jan 6 2018, 9:16 PM

Jan 4 2018

ed committed rS327560: Allow timed waits with relative timeouts on locks and condvars..
Allow timed waits with relative timeouts on locks and condvars.
Jan 4 2018, 9:58 PM

Dec 28 2017

ed accepted D13670: Make dtraceall loadable again on arm64.
Dec 28 2017, 9:39 PM

Dec 21 2017

ed committed rS327057: Make truss work for CloudABI executables on i386..
Make truss work for CloudABI executables on i386.
Dec 21 2017, 9:22 AM

Dec 20 2017

ed committed rS327022: Make truss(8) work for 32-bit CloudABI executables on ARM64..
Make truss(8) work for 32-bit CloudABI executables on ARM64.
Dec 20 2017, 1:13 PM

Dec 16 2017

ed committed rS326911: Make truss(8) work for i686-unknown-cloudabi binaries on FreeBSD/amd64..
Make truss(8) work for i686-unknown-cloudabi binaries on FreeBSD/amd64.
Dec 16 2017, 7:40 PM
ed committed rS326910: libsysdecode: Add a new ABI type, SYSDECODE_ABI_CLOUDABI32..
libsysdecode: Add a new ABI type, SYSDECODE_ABI_CLOUDABI32.
Dec 16 2017, 7:38 PM
ed closed D13516: Make truss(8) work for i686-unknown-cloudabi binaries on FreeBSD/amd64..
Dec 16 2017, 7:38 PM
ed created D13516: Make truss(8) work for i686-unknown-cloudabi binaries on FreeBSD/amd64..
Dec 16 2017, 6:19 PM

Dec 10 2017

ed committed rS326743: MFC r326228 and r326229:.
MFC r326228 and r326229:
Dec 10 2017, 12:25 PM

Dec 8 2017

ed committed rS326719: Remove basename_r(3)..
Remove basename_r(3).
Dec 8 2017, 10:06 PM
ed committed rS326681: MFC r326420:.
MFC r326420:
Dec 8 2017, 5:57 AM

Dec 3 2017

ed added a comment to D13311: Make COMPAT_FREEBSD32 part of GENERIC on arm64..

Hi Andrew,

Dec 3 2017, 7:30 PM
ed closed D13311: Make COMPAT_FREEBSD32 part of GENERIC on arm64..
Dec 3 2017, 7:26 PM
ed committed rS326501: Make COMPAT_FREEBSD32 part of GENERIC on arm64..
Make COMPAT_FREEBSD32 part of GENERIC on arm64.
Dec 3 2017, 7:26 PM

Dec 1 2017

ed committed rS326423: Eliminate the last user of basename_r() in the base system..
Eliminate the last user of basename_r() in the base system.
Dec 1 2017, 10:26 AM
ed committed rS326420: Add an mlink for cloudabi32(4)..
Add an mlink for cloudabi32(4).
Dec 1 2017, 5:57 AM
ed added inline comments to D13311: Make COMPAT_FREEBSD32 part of GENERIC on arm64..
Dec 1 2017, 5:55 AM
ed updated the diff for D13311: Make COMPAT_FREEBSD32 part of GENERIC on arm64..

Use a different description that fits within 80 columns.

Dec 1 2017, 5:55 AM

Nov 30 2017

ed created D13311: Make COMPAT_FREEBSD32 part of GENERIC on arm64..
Nov 30 2017, 6:18 PM
ed abandoned D13249: Port cloudabi32.ko to FreeBSD/arm64..
Nov 30 2017, 6:00 PM
ed committed rS326406: Port cloudabi32.ko to FreeBSD/arm64..
Port cloudabi32.ko to FreeBSD/arm64.
Nov 30 2017, 5:59 PM

Nov 26 2017

ed created D13249: Port cloudabi32.ko to FreeBSD/arm64..
Nov 26 2017, 3:30 PM
ed committed rS326230: Add a Saved Process Status Register bit for AArch32 execution mode..
Add a Saved Process Status Register bit for AArch32 execution mode.
Nov 26 2017, 2:56 PM
ed closed D13148: Add a Saved Process Status Register bit for AArch32 execution mode..
Nov 26 2017, 2:56 PM · arm64, ARM
ed updated the diff for D13148: Add a Saved Process Status Register bit for AArch32 execution mode..

Rebase.

Nov 26 2017, 2:55 PM · arm64, ARM
ed committed rS326229: Correct some more places where TO_PTR() should be used..
Correct some more places where TO_PTR() should be used.
Nov 26 2017, 2:54 PM
ed committed rS326228: Use TO_PTR() to convert integers to pointers..
Use TO_PTR() to convert integers to pointers.
Nov 26 2017, 2:46 PM
ed added a comment to D13148: Add a Saved Process Status Register bit for AArch32 execution mode..

Maybe you're referring to switching between 64-bit and 32-bit code without going through EL1 first. This is explicitly documented as unsupported.

No, from memory it was an incorrect check the value passed to the kernel from userspace was wrong. I did make sure we have a check on signal return, however for it to work we need to check M[4] is set correctly. With this change the user could change this bit.

Nov 26 2017, 2:36 PM · arm64, ARM
ed updated the diff for D13148: Add a Saved Process Status Register bit for AArch32 execution mode..

Don't allow PSR_AARCH32 to be set in sigreturn().

Nov 26 2017, 2:35 PM · arm64, ARM
ed committed rS326227: Make 32-bit system calls end up in svc_handler()..
Make 32-bit system calls end up in svc_handler().
Nov 26 2017, 2:28 PM
ed closed D13146: Make 32-bit system calls end up in svc_handler()..
Nov 26 2017, 2:28 PM · arm64, ARM
ed added a comment to D13146: Make 32-bit system calls end up in svc_handler()..

Considering that there is no need to split up this into two code paths for 32-bit/64-bit at least for what I'm trying to achieve, would you mind if I went ahead, committing this change as is? Once this change and D13148 land, I can work towards getting the sysent for cloudabi32 committed.

Nov 26 2017, 12:44 PM · arm64, ARM

Nov 25 2017

ed committed rP454898: Bump CloudABI to v0.18..
Bump CloudABI to v0.18.
Nov 25 2017, 9:49 PM
ed closed D13241: Bump CloudABI to v0.18..
Nov 25 2017, 9:49 PM
ed created D13241: Bump CloudABI to v0.18..
Nov 25 2017, 9:09 PM
ed added inline comments to D12785: New gets_s(3) stdio function.
Nov 25 2017, 8:29 PM

Nov 24 2017

ed committed rS326167: Pick the right vDSO file/linker flags when building cloudabi32.ko on ARM64..
Pick the right vDSO file/linker flags when building cloudabi32.ko on ARM64.
Nov 24 2017, 2:02 PM
ed closed D13145: Set CP15BEN in SCTLR to make memory barriers work in 32-bit mode..
Nov 24 2017, 1:52 PM · arm64, ARM