ed (Ed Schouten)
User

Projects

User Details

User Since
Sep 28 2014, 1:01 PM (172 w, 2 d)

Recent Activity

Sun, Jan 7

ed committed rS327684: Use mallocarray(9) in CloudABI kernel code where possible..
Use mallocarray(9) in CloudABI kernel code where possible.
Sun, Jan 7, 10:39 PM

Sat, Jan 6

ed committed rP458292: sysutils/cloudabi-utils: Upgrade to upstream version 0.36..
sysutils/cloudabi-utils: Upgrade to upstream version 0.36.
Sat, Jan 6, 9:22 PM
ed closed D13786: sysutils/cloudabi-utils: Upgrade to upstream version 0.36..
Sat, Jan 6, 9:22 PM
ed created D13786: sysutils/cloudabi-utils: Upgrade to upstream version 0.36..
Sat, Jan 6, 9:16 PM

Thu, Jan 4

ed committed rS327560: Allow timed waits with relative timeouts on locks and condvars..
Allow timed waits with relative timeouts on locks and condvars.
Thu, Jan 4, 9:58 PM

Thu, Dec 28

ed accepted D13670: Make dtraceall loadable again on arm64.
Thu, Dec 28, 9:39 PM

Thu, Dec 21

ed committed rS327057: Make truss work for CloudABI executables on i386..
Make truss work for CloudABI executables on i386.
Thu, Dec 21, 9:22 AM

Wed, Dec 20

ed committed rS327022: Make truss(8) work for 32-bit CloudABI executables on ARM64..
Make truss(8) work for 32-bit CloudABI executables on ARM64.
Wed, Dec 20, 1:13 PM

Dec 16 2017

ed committed rS326911: Make truss(8) work for i686-unknown-cloudabi binaries on FreeBSD/amd64..
Make truss(8) work for i686-unknown-cloudabi binaries on FreeBSD/amd64.
Dec 16 2017, 7:40 PM
ed committed rS326910: libsysdecode: Add a new ABI type, SYSDECODE_ABI_CLOUDABI32..
libsysdecode: Add a new ABI type, SYSDECODE_ABI_CLOUDABI32.
Dec 16 2017, 7:38 PM
ed closed D13516: Make truss(8) work for i686-unknown-cloudabi binaries on FreeBSD/amd64..
Dec 16 2017, 7:38 PM
ed created D13516: Make truss(8) work for i686-unknown-cloudabi binaries on FreeBSD/amd64..
Dec 16 2017, 6:19 PM

Dec 10 2017

ed committed rS326743: MFC r326228 and r326229:.
MFC r326228 and r326229:
Dec 10 2017, 12:25 PM

Dec 8 2017

ed committed rS326719: Remove basename_r(3)..
Remove basename_r(3).
Dec 8 2017, 10:06 PM
ed committed rS326681: MFC r326420:.
MFC r326420:
Dec 8 2017, 5:57 AM

Dec 3 2017

ed added a comment to D13311: Make COMPAT_FREEBSD32 part of GENERIC on arm64..

Hi Andrew,

Dec 3 2017, 7:30 PM
ed closed D13311: Make COMPAT_FREEBSD32 part of GENERIC on arm64..
Dec 3 2017, 7:26 PM
ed committed rS326501: Make COMPAT_FREEBSD32 part of GENERIC on arm64..
Make COMPAT_FREEBSD32 part of GENERIC on arm64.
Dec 3 2017, 7:26 PM

Dec 1 2017

ed committed rS326423: Eliminate the last user of basename_r() in the base system..
Eliminate the last user of basename_r() in the base system.
Dec 1 2017, 10:26 AM
ed committed rS326420: Add an mlink for cloudabi32(4)..
Add an mlink for cloudabi32(4).
Dec 1 2017, 5:57 AM
ed added inline comments to D13311: Make COMPAT_FREEBSD32 part of GENERIC on arm64..
Dec 1 2017, 5:55 AM
ed updated the diff for D13311: Make COMPAT_FREEBSD32 part of GENERIC on arm64..

Use a different description that fits within 80 columns.

Dec 1 2017, 5:55 AM

Nov 30 2017

ed created D13311: Make COMPAT_FREEBSD32 part of GENERIC on arm64..
Nov 30 2017, 6:18 PM
ed abandoned D13249: Port cloudabi32.ko to FreeBSD/arm64..
Nov 30 2017, 6:00 PM
ed committed rS326406: Port cloudabi32.ko to FreeBSD/arm64..
Port cloudabi32.ko to FreeBSD/arm64.
Nov 30 2017, 5:59 PM

Nov 26 2017

ed created D13249: Port cloudabi32.ko to FreeBSD/arm64..
Nov 26 2017, 3:30 PM
ed committed rS326230: Add a Saved Process Status Register bit for AArch32 execution mode..
Add a Saved Process Status Register bit for AArch32 execution mode.
Nov 26 2017, 2:56 PM
ed closed D13148: Add a Saved Process Status Register bit for AArch32 execution mode..
Nov 26 2017, 2:56 PM · arm64, ARM
ed updated the diff for D13148: Add a Saved Process Status Register bit for AArch32 execution mode..

Rebase.

Nov 26 2017, 2:55 PM · arm64, ARM
ed committed rS326229: Correct some more places where TO_PTR() should be used..
Correct some more places where TO_PTR() should be used.
Nov 26 2017, 2:54 PM
ed committed rS326228: Use TO_PTR() to convert integers to pointers..
Use TO_PTR() to convert integers to pointers.
Nov 26 2017, 2:46 PM
ed added a comment to D13148: Add a Saved Process Status Register bit for AArch32 execution mode..

Maybe you're referring to switching between 64-bit and 32-bit code without going through EL1 first. This is explicitly documented as unsupported.

No, from memory it was an incorrect check the value passed to the kernel from userspace was wrong. I did make sure we have a check on signal return, however for it to work we need to check M[4] is set correctly. With this change the user could change this bit.

Nov 26 2017, 2:36 PM · arm64, ARM
ed updated the diff for D13148: Add a Saved Process Status Register bit for AArch32 execution mode..

Don't allow PSR_AARCH32 to be set in sigreturn().

Nov 26 2017, 2:35 PM · arm64, ARM
ed committed rS326227: Make 32-bit system calls end up in svc_handler()..
Make 32-bit system calls end up in svc_handler().
Nov 26 2017, 2:28 PM
ed closed D13146: Make 32-bit system calls end up in svc_handler()..
Nov 26 2017, 2:28 PM · arm64, ARM
ed added a comment to D13146: Make 32-bit system calls end up in svc_handler()..

Considering that there is no need to split up this into two code paths for 32-bit/64-bit at least for what I'm trying to achieve, would you mind if I went ahead, committing this change as is? Once this change and D13148 land, I can work towards getting the sysent for cloudabi32 committed.

Nov 26 2017, 12:44 PM · arm64, ARM

Nov 25 2017

ed committed rP454898: Bump CloudABI to v0.18..
Bump CloudABI to v0.18.
Nov 25 2017, 9:49 PM
ed closed D13241: Bump CloudABI to v0.18..
Nov 25 2017, 9:49 PM
ed created D13241: Bump CloudABI to v0.18..
Nov 25 2017, 9:09 PM
ed added inline comments to D12785: New gets_s(3) stdio function.
Nov 25 2017, 8:29 PM

Nov 24 2017

ed committed rS326167: Pick the right vDSO file/linker flags when building cloudabi32.ko on ARM64..
Pick the right vDSO file/linker flags when building cloudabi32.ko on ARM64.
Nov 24 2017, 2:02 PM
ed closed D13145: Set CP15BEN in SCTLR to make memory barriers work in 32-bit mode..
Nov 24 2017, 1:52 PM · arm64, ARM
ed committed rS326166: Set CP15BEN in SCTLR to make memory barriers work in 32-bit mode..
Set CP15BEN in SCTLR to make memory barriers work in 32-bit mode.
Nov 24 2017, 1:52 PM
ed closed D13144: Add rudimentary support for building FreeBSD/arm64 with COMPAT_FREEBSD32..
Nov 24 2017, 1:51 PM · arm64, ARM
ed committed rS326165: Add rudimentary support for building FreeBSD/arm64 with COMPAT_FREEBSD32..
Add rudimentary support for building FreeBSD/arm64 with COMPAT_FREEBSD32.
Nov 24 2017, 1:51 PM
ed committed rS326145: Don't let cpu_set_syscall_retval() clobber exec_setregs()..
Don't let cpu_set_syscall_retval() clobber exec_setregs().
Nov 24 2017, 7:35 AM
ed closed D13180: Don't let cpu_set_syscall_retval() clobber exec_setregs()..
Nov 24 2017, 7:35 AM

Nov 21 2017

ed removed a reviewer for D8133: abort in srandomdev if kern.arandom sysctl fails: ed.
Nov 21 2017, 9:44 PM
ed removed a reviewer for D9979: Fix a use-after-free in systat: ed.
Nov 21 2017, 9:43 PM
ed removed a reviewer for D9996: Fix a memory leak in ccdconfig: ed.
Nov 21 2017, 9:43 PM
ed removed a reviewer for D10073: Fix memory leak in memcontrol: ed.
Nov 21 2017, 9:43 PM
ed removed a reviewer for D10311: apply style(9) to strstr and memmem obtained from musl: ed.
Nov 21 2017, 9:43 PM
ed removed a reviewer for D12380: correct cap_rights_* varargs use: ed.
Nov 21 2017, 9:42 PM
ed removed a reviewer for D11918: Fix vt(4)'s response to Device Status Report escape sequences: ed.
Nov 21 2017, 9:41 PM
ed abandoned D12456: Update the BSD Vision article to reflect what was discussed at the DevSummit..
Nov 21 2017, 9:40 PM
ed committed rS326075: Import the latest CloudABI definitions, v0.18..
Import the latest CloudABI definitions, v0.18.
Nov 21 2017, 8:46 PM
ed updated the diff for D13180: Don't let cpu_set_syscall_retval() clobber exec_setregs()..

Revert changes to cpu_set_upcall().

Nov 21 2017, 4:36 PM
ed added a comment to D13180: Don't let cpu_set_syscall_retval() clobber exec_setregs()..

Kostik, I see there are also some places where we set td_retval from within cpu_set_upcall(). That should be unnecessary altogether, right? Even without this change, we don't end up calling cpu_set_syscall_retval() after thread creation....

Nov 21 2017, 3:57 PM
ed added a comment to D13180: Don't let cpu_set_syscall_retval() clobber exec_setregs()..
In D13180#274501, @kib wrote:

I do not see changes for e.g. sparc64 where exec_setregs() also sets td_retval.

Nov 21 2017, 3:48 PM
ed updated the diff for D13180: Don't let cpu_set_syscall_retval() clobber exec_setregs()..

We can also remove td_retval handling in the thread initialization.

Nov 21 2017, 3:47 PM
ed updated the diff for D13180: Don't let cpu_set_syscall_retval() clobber exec_setregs()..

Remove dead code from sparc64. Spotted by kib@.

Nov 21 2017, 3:45 PM
ed added a comment to D13180: Don't let cpu_set_syscall_retval() clobber exec_setregs()..
In D13180#274429, @kib wrote:

Note my comment at the return() in do_execve().

Nov 21 2017, 10:10 AM
ed updated the diff for D13180: Don't let cpu_set_syscall_retval() clobber exec_setregs()..

Document why we return EJUSTRETURN in do_execve().

Nov 21 2017, 10:06 AM
ed updated the diff for D13180: Don't let cpu_set_syscall_retval() clobber exec_setregs()..

Remove a stale comment regarding regs <-> retval.

Nov 21 2017, 9:48 AM
ed updated the diff for D13180: Don't let cpu_set_syscall_retval() clobber exec_setregs()..

Make sure sure this comment doesn't contain a typo.

Nov 21 2017, 9:47 AM
ed updated the diff for D13180: Don't let cpu_set_syscall_retval() clobber exec_setregs()..

Take a look at all kern_execve() call sites. Fix up linux_common_execve().

Nov 21 2017, 9:42 AM
ed added inline comments to D13180: Don't let cpu_set_syscall_retval() clobber exec_setregs()..
Nov 21 2017, 9:39 AM
ed updated the diff for D13180: Don't let cpu_set_syscall_retval() clobber exec_setregs()..

Process kib@'s feedback. Thanks!

Nov 21 2017, 9:39 AM
ed created D13180: Don't let cpu_set_syscall_retval() clobber exec_setregs()..
Nov 21 2017, 7:15 AM

Nov 19 2017

ed added a comment to D13148: Add a Saved Process Status Register bit for AArch32 execution mode..
In D13148#273913, @ed wrote:

This would be benign, right? For the kernel, it is irrelevant whether user space sets or clears this flag. Just like NZCV, etc.

I'm not sure how the kernel would handle userspace changing between 64 and 32 bit code.

Nov 19 2017, 7:45 PM · arm64, ARM
ed added a comment to D13148: Add a Saved Process Status Register bit for AArch32 execution mode..

This will allow userspace to switch between AArch64 and AArch32 via sigreturn. sys_sigreturn has checks on the PSR bits to ensure they are safe to install that this will break.

Nov 19 2017, 12:49 PM · arm64, ARM
ed added a comment to D13146: Make 32-bit system calls end up in svc_handler()..

I split the syncronous exception out into a new handler in my compat32 patch as it allows further sanity checks, e.g. that the kernel thinks the current process should be in 32-bit mode.

Nov 19 2017, 12:45 PM · arm64, ARM
ed added a comment to D13145: Set CP15BEN in SCTLR to make memory barriers work in 32-bit mode..

Are we expecting to run armv6 code, or should we just support armv7?

Nov 19 2017, 12:40 PM · arm64, ARM
ed added inline comments to D13144: Add rudimentary support for building FreeBSD/arm64 with COMPAT_FREEBSD32..
Nov 19 2017, 12:40 PM · arm64, ARM
ed updated the summary of D13144: Add rudimentary support for building FreeBSD/arm64 with COMPAT_FREEBSD32..
Nov 19 2017, 12:39 PM · arm64, ARM
ed updated the diff for D13144: Add rudimentary support for building FreeBSD/arm64 with COMPAT_FREEBSD32..

Announce armv7 instead of armv6.

Nov 19 2017, 12:39 PM · arm64, ARM

Nov 18 2017

ed added inline comments to D13144: Add rudimentary support for building FreeBSD/arm64 with COMPAT_FREEBSD32..
Nov 18 2017, 7:35 PM · arm64, ARM
ed added inline comments to D13144: Add rudimentary support for building FreeBSD/arm64 with COMPAT_FREEBSD32..
Nov 18 2017, 7:34 PM · arm64, ARM
ed added projects to D13148: Add a Saved Process Status Register bit for AArch32 execution mode.: ARM, arm64.
Nov 18 2017, 7:29 PM · arm64, ARM
ed created D13148: Add a Saved Process Status Register bit for AArch32 execution mode..
Nov 18 2017, 7:28 PM · arm64, ARM
ed added projects to D13146: Make 32-bit system calls end up in svc_handler().: ARM, arm64.
Nov 18 2017, 6:51 PM · arm64, ARM
ed removed projects from D13143: Make rtld use read(2) instead of mmap(2) for ELF headers: arm64, ARM.
Nov 18 2017, 6:51 PM
ed added projects to D13143: Make rtld use read(2) instead of mmap(2) for ELF headers: ARM, arm64.
Nov 18 2017, 6:51 PM
ed created D13146: Make 32-bit system calls end up in svc_handler()..
Nov 18 2017, 1:17 PM · arm64, ARM
ed created D13145: Set CP15BEN in SCTLR to make memory barriers work in 32-bit mode..
Nov 18 2017, 1:10 PM · arm64, ARM
ed created D13144: Add rudimentary support for building FreeBSD/arm64 with COMPAT_FREEBSD32..
Nov 18 2017, 1:03 PM · arm64, ARM

Nov 15 2017

ed committed rS325858: MFC r324727 and r325555:.
MFC r324727 and r325555:
Nov 15 2017, 3:56 PM

Nov 12 2017

ed committed rP454091: devel/cloudabi and sysutils/cloudabi-utils: Upgrade to v0.17 and v0.35..
devel/cloudabi and sysutils/cloudabi-utils: Upgrade to v0.17 and v0.35.
Nov 12 2017, 10:14 PM
ed closed D13052: devel/cloudabi and sysutils/cloudabi-utils: Upgrade to v0.17 and v0.35..
Nov 12 2017, 10:14 PM

Nov 11 2017

ed created D13052: devel/cloudabi and sysutils/cloudabi-utils: Upgrade to v0.17 and v0.35..
Nov 11 2017, 11:02 PM

Nov 8 2017

ed committed rS325555: Upgrade to CloudABI v0.17..
Upgrade to CloudABI v0.17.
Nov 8 2017, 2:22 PM

Nov 2 2017

ed added a comment to D12785: New gets_s(3) stdio function.

Looks a lot better. Thanks!

Nov 2 2017, 4:02 PM

Nov 1 2017

ed added a comment to D12785: New gets_s(3) stdio function.
In D12785#267382, @cy wrote:

The gets_s() has been separated out into a different file.

Would it be better to svn copy & update or a new file from scratch?

Nov 1 2017, 8:02 AM

Oct 29 2017

ed committed rP453138: Update CloudABI related packages to the latest upstream versions..
Update CloudABI related packages to the latest upstream versions.
Oct 29 2017, 9:34 PM
ed closed D12751: Update CloudABI related packages to the latest upstream versions..
Oct 29 2017, 9:34 PM

Oct 25 2017

ed added inline comments to D12785: New gets_s(3) stdio function.
Oct 25 2017, 8:10 PM
ed added a comment to D12785: New gets_s(3) stdio function.

I'm personally not a fan of the *_s() functions. That said, we've already added some others to the base system, so there's probably no turning back.

Oct 25 2017, 7:21 AM

Oct 21 2017

ed created D12751: Update CloudABI related packages to the latest upstream versions..
Oct 21 2017, 7:15 PM

Oct 18 2017

ed committed rS324727: Import the latest CloudABI definitions, version 0.16..
Import the latest CloudABI definitions, version 0.16.
Oct 18 2017, 7:23 PM

Oct 14 2017

ed added a comment to D12667: Guard offsetof.

What about making the macros identical? That way there is no need for a guard. s/field/member/

Oct 14 2017, 9:23 AM