Page MenuHomeFreeBSD

Add COM3 and COM4 to bhyve guests
ClosedPublic

Authored by otis on Jan 17 2021, 11:57 AM.

Details

Summary

While working on different project with bhyve (in particular, on SmartOS-based product), we ran into a situation where we needed all 4 COM ports inside a bhyve guest.

This patch adds them, it has already been tested in SmartOS.

Authored by Jan Poctavek <janci@binaryparadise.com>

Diff Detail

Repository
R10 FreeBSD src repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

otis requested review of this revision.Jan 17 2021, 11:57 AM
otis created this revision.
otis edited the summary of this revision. (Show Details)

Update the diff to be against FreeBSD. Previously it was against illumos.

Looks good to my eye, but I'd feel better with a nod from one of the main bhyve developers

This revision is now accepted and ready to land.Jan 17 2021, 5:50 PM
  • Fix manual page to mention com1 .. com4
This revision now requires review to proceed.Jan 17 2021, 11:11 PM
grehan added a subscriber: grehan.

Change looks useful, thanks.

usr.sbin/bhyve/bhyve.8
156–157

Should be 'through' based on usage in other man pages.

This revision is now accepted and ready to land.Jan 17 2021, 11:16 PM
0mp requested changes to this revision.Jan 17 2021, 11:17 PM
0mp added a subscriber: 0mp.
0mp added inline comments.
usr.sbin/bhyve/bhyve.8
156–157
This revision now requires changes to proceed.Jan 17 2021, 11:17 PM
usr.sbin/bhyve/bhyve.8
156–157

Exactly. Our automated proofreader igor does not like "thru" apparently.

This revision is now accepted and ready to land.Jan 18 2021, 1:22 PM
This revision was automatically updated to reflect the committed changes.