op (Oliver Pinter)
User

Projects

User Details

User Since
May 10 2014, 7:44 PM (180 w, 14 h)

Recent Activity

Yesterday

op abandoned D3848: follow up the latest stack-protector-strong changes in libc too.
Sat, Oct 21, 1:58 PM
op abandoned D3043: _FORTIFY_SOURCE support.
Sat, Oct 21, 1:58 PM · fortify source

Thu, Sep 28

op added reviewers for D12534: Interactive installer (auto zfs + mbr) fails to add zpool_cache_* to loader.conf: emaste, dteske, nwhitehorn.
Thu, Sep 28, 9:57 PM

Aug 29 2017

op added inline comments to D12099: Add minimal kernel runtime for UBSAN.
Aug 29 2017, 12:05 PM

Jan 3 2017

op added a comment to D9036: bump check for PMC architecture in hwpmc core.

(When the diff got a positive review, please commit them.)

Jan 3 2017, 11:26 PM
op retitled D9036: bump check for PMC architecture in hwpmc core from bump check for PMC architecture check in hwpmc core to bump check for PMC architecture in hwpmc core.
Jan 3 2017, 11:25 PM
op retitled D9036: bump check for PMC architecture in hwpmc core from to bump check for PMC architecture check in hwpmc core.
Jan 3 2017, 11:25 PM

Dec 12 2016

op updated the diff for D8734: HBSD: fix long standing issue in bsdconfig's keymap selection.
Dec 12 2016, 7:29 AM

Dec 11 2016

op updated the diff for D8734: HBSD: fix long standing issue in bsdconfig's keymap selection.

Make it more readable and consistent.

Dec 11 2016, 11:42 PM
op updated the diff for D8734: HBSD: fix long standing issue in bsdconfig's keymap selection.

Updated diff.

Dec 11 2016, 2:18 PM
op retitled D8750: prefix addresses with 0x in x86/acpica/srat.c from to prefix addresses with 0x in x86/acpica/srat.c.
Dec 11 2016, 1:53 PM

Dec 10 2016

op added reviewers for D8734: HBSD: fix long standing issue in bsdconfig's keymap selection: trasz, ed, nwhitehorn.
Dec 10 2016, 2:50 PM

Dec 8 2016

op retitled D8734: HBSD: fix long standing issue in bsdconfig's keymap selection from to HBSD: fix long standing issue in bsdconfig's keymap selection.
Dec 8 2016, 10:38 PM

Nov 25 2016

op added reviewers for D8640: Update tcsh to 6.20.00: mp, emaste.
Nov 25 2016, 8:23 PM

Nov 10 2016

op set the repository for D8486: increase UCODE_SIZE_MAX from 32kB to 4MB in sys/dev/cpuctl/cpuctl.c to allow microcode update on Intel 6th+ gen CPUs to rS FreeBSD src repository.
Nov 10 2016, 11:27 PM
op updated the diff for D8486: increase UCODE_SIZE_MAX from 32kB to 4MB in sys/dev/cpuctl/cpuctl.c to allow microcode update on Intel 6th+ gen CPUs.

Updated the limit to 4MB as proposed by kib@.

Nov 10 2016, 11:26 PM

Nov 9 2016

op updated D8486: increase UCODE_SIZE_MAX from 32kB to 4MB in sys/dev/cpuctl/cpuctl.c to allow microcode update on Intel 6th+ gen CPUs.
Nov 9 2016, 9:14 PM
op retitled D8486: increase UCODE_SIZE_MAX from 32kB to 4MB in sys/dev/cpuctl/cpuctl.c to allow microcode update on Intel 6th+ gen CPUs from increase UCODE_SIZE_MAX from 32kB to 128kb in sys/dev/cpuctl/cpuctl.c to allow microcode update on Intel 6th+ gen CPUs to increase UCODE_SIZE_MAX from 32kB to 128kB in sys/dev/cpuctl/cpuctl.c to allow microcode update on Intel 6th+ gen CPUs.
Nov 9 2016, 9:14 PM
op retitled D8486: increase UCODE_SIZE_MAX from 32kB to 4MB in sys/dev/cpuctl/cpuctl.c to allow microcode update on Intel 6th+ gen CPUs from to increase UCODE_SIZE_MAX from 32kB to 128kb in sys/dev/cpuctl/cpuctl.c to allow microcode update on Intel 6th+ gen CPUs.
Nov 9 2016, 9:12 PM

Nov 4 2016

op added a comment to D8175: add superio driver.

Seems like it successfully attaches:

Nov 4 2016, 8:50 PM
op accepted D8176: vidcontrol: improve error handling in vt(4) font loading.
Nov 4 2016, 8:18 PM
op added a reviewer for D8176: vidcontrol: improve error handling in vt(4) font loading: op.
Nov 4 2016, 8:14 PM

Oct 8 2016

op added a comment to D8160: Fix potential use-after free in taskqueue_drain_all.

Please commit this patch, this fixes FreeBSD PR 209580.

Oct 8 2016, 12:38 PM

Aug 7 2016

op updated subscribers of D7431: fix kernel panic on 10-STABLE when running setrlimit_test with INVARIANTS enabled kernel.
Aug 7 2016, 12:11 PM
op retitled D7431: fix kernel panic on 10-STABLE when running setrlimit_test with INVARIANTS enabled kernel from to fix kernel panic on 10-STABLE when running setrlimit_test with INVARIANTS enabled kernel.
Aug 7 2016, 12:09 PM

Aug 6 2016

op updated D7430: fix tar's test builds with WITH_TESTS= in src.conf.
Aug 6 2016, 6:43 PM
op updated D7430: fix tar's test builds with WITH_TESTS= in src.conf.
Aug 6 2016, 6:43 PM
op added reviewers for D7430: fix tar's test builds with WITH_TESTS= in src.conf: jmmv, jmg.
Aug 6 2016, 6:05 PM
op added a reviewer for D7430: fix tar's test builds with WITH_TESTS= in src.conf: bapt.
Aug 6 2016, 6:04 PM
op retitled D7430: fix tar's test builds with WITH_TESTS= in src.conf from to fix tar's test builds with WITH_TESTS= in src.conf.
Aug 6 2016, 6:03 PM

Aug 1 2016

op added a comment to D3848: follow up the latest stack-protector-strong changes in libc too.

Sure, I plan to find time for check them. Thanks for the reminder.

Aug 1 2016, 10:19 PM

Mar 28 2016

op accepted D5708: simplify compile-time default keyboard map generation.

Tested with these settings:

Mar 28 2016, 7:14 PM

Mar 23 2016

op added a comment to D5660: Check for negative lengths in m_pulldown.

And add adrian@, gnn@ and glebius@ as reviewer?

Mar 23 2016, 12:15 AM
op added a comment to D5660: Check for negative lengths in m_pulldown.

Could you please reupload the patch with bigger context? git diff -U9999 for example?

Mar 23 2016, 12:14 AM

Mar 22 2016

op added a comment to D5708: simplify compile-time default keyboard map generation.

Looks good to me, but not yet tested (I will at weekend.).

Mar 22 2016, 11:23 PM

Mar 11 2016

op added inline comments to D5603: ASLR.
Mar 11 2016, 11:51 PM

Feb 19 2016

op added inline comments to D5245: PVS Static Analysis.
Feb 19 2016, 9:33 PM

Feb 18 2016

op added a comment to D5263: document some ACPI related sysctl.

Adrian, could you please commit this change to HEAD?

Feb 18 2016, 11:38 PM
op added a comment to D4235: fix 10-STABLE build on 11-CURRENT after mklocale and colldef removal .

Is there any chance to get this or similar changes before the 10.3 released?

Feb 18 2016, 12:56 AM
op added a reviewer for D4235: fix 10-STABLE build on 11-CURRENT after mklocale and colldef removal : glebius.
Feb 18 2016, 12:54 AM

Feb 12 2016

op added a comment to D5263: document some ACPI related sysctl.

Sponsored by HardenedBSD.

Feb 12 2016, 4:45 PM
op retitled D5263: document some ACPI related sysctl from to document some ACPI related sysctl.
Feb 12 2016, 4:45 PM

Feb 5 2016

op added a comment to D3162: e1000/em/igb: Update em to 7.6.1, update igb to 2.5.3..

Cool! Thank you very much guys!

Feb 5 2016, 5:23 PM

Jan 31 2016

op added a comment to D3162: e1000/em/igb: Update em to 7.6.1, update igb to 2.5.3..

Hello guys!

Jan 31 2016, 1:06 PM

Jan 26 2016

op added a comment to D3162: e1000/em/igb: Update em to 7.6.1, update igb to 2.5.3..

Btw, when I'm there, is from the Intel side any plan to bring in to the tree newer wireless drivers drivers too?

Jan 26 2016, 9:45 PM
op added a comment to D3162: e1000/em/igb: Update em to 7.6.1, update igb to 2.5.3..

Cool! Working fine with the following chips:

Jan 26 2016, 9:42 PM
op added a comment to D3162: e1000/em/igb: Update em to 7.6.1, update igb to 2.5.3..

I will test the patch now.

Jan 26 2016, 8:40 PM
op added a comment to D3162: e1000/em/igb: Update em to 7.6.1, update igb to 2.5.3..

I have an i219-V (not working) and an i211-at (working) adapter on my mobo (gigabyte h170n-wifi) , so feel free to ping me if you have a working or testable patch.

Jan 26 2016, 1:09 AM

Jan 15 2016

op retitled D4235: fix 10-STABLE build on 11-CURRENT after mklocale and colldef removal from fix 10-STABLE build on 11-CURRENT after recent locales changes to fix 10-STABLE build on 11-CURRENT after mklocale and colldef removal .
Jan 15 2016, 5:32 PM
op added a comment to D4235: fix 10-STABLE build on 11-CURRENT after mklocale and colldef removal .

Is there any chance to get this patch into 10.3? As you have said, it would be nice to remove these programs from 11-CURRENT.

Jan 15 2016, 5:31 PM

Jan 10 2016

op added a comment to D3204: Fix loading files twice..

This patch is required to 10-STABLE? You marked this as MFC after 1 month, but this was never MFCd back.

Jan 10 2016, 12:36 PM
op updated subscribers of D3204: Fix loading files twice..
Jan 10 2016, 12:33 PM
op updated subscribers of D3204: Fix loading files twice..
Jan 10 2016, 12:33 PM

Dec 30 2015

op updated subscribers of D4593: Implement a stripped down version of GELI (AES-XTS and AES-CBC only) in gptboot and gptzfsboot.
Dec 30 2015, 10:57 PM

Nov 23 2015

op added a comment to D4233: libxo: add missing error check after xo_parse_args in netstat.

Could you please commit the patch, if the diff fine?

Nov 23 2015, 6:58 PM

Nov 21 2015

op added a comment to D4235: fix 10-STABLE build on 11-CURRENT after mklocale and colldef removal .

Yes. We (HardenedBSD) already have this patch and working fine: https://github.com/HardenedBSD/hardenedBSD-stable/commit/1f4dbf94d059b9fd43944f73c890c94bedfbe6de

Nov 21 2015, 2:06 PM

Nov 20 2015

op retitled D4235: fix 10-STABLE build on 11-CURRENT after mklocale and colldef removal from to fix 10-STABLE build on 11-CURRENT after recent locales changes.
Nov 20 2015, 8:42 PM
op added a comment to D3933: Add /boot/entropy at install time, and be more careful with permissions.

Any update on this change?

Nov 20 2015, 4:06 PM
op updated D4233: libxo: add missing error check after xo_parse_args in netstat.
Nov 20 2015, 2:02 PM
op retitled D4233: libxo: add missing error check after xo_parse_args in netstat from to libxo: add missing error check after xo_parse_args in netstat.
Nov 20 2015, 2:02 PM
op updated subscribers of D3935: Convert vmstat to use libxo.
Nov 20 2015, 11:16 AM

Oct 19 2015

op added a comment to D3933: Add /boot/entropy at install time, and be more careful with permissions.
In D3933#81711, @jmg wrote:
  • add /boot/entropy to install generation.. Also, be extra careful
  • add quotes around the $i for more space protection..

    I have done a basic test, and this looks good, I'll commit shortly..
Oct 19 2015, 9:42 AM
op added a comment to D3933: Add /boot/entropy at install time, and be more careful with permissions.
In D3933#81686, @markm wrote:

This was on my TODO list. I wish I'd known it was this simple!

Oct 19 2015, 9:39 AM

Oct 8 2015

op added a reviewer for D3848: follow up the latest stack-protector-strong changes in libc too: jlh.
Oct 8 2015, 9:17 PM
op updated subscribers of D3848: follow up the latest stack-protector-strong changes in libc too.
Oct 8 2015, 8:53 PM
op updated D3848: follow up the latest stack-protector-strong changes in libc too.
Oct 8 2015, 8:52 PM
op added a dependent revision for D3463: Adopt higher level of stack protection.: D3848: follow up the latest stack-protector-strong changes in libc too.
Oct 8 2015, 8:52 PM · security
op added a dependency for D3848: follow up the latest stack-protector-strong changes in libc too: D3463: Adopt higher level of stack protection..
Oct 8 2015, 8:52 PM
op retitled D3848: follow up the latest stack-protector-strong changes in libc too from to follow up the latest stack-protector-strong changes in libc too.
Oct 8 2015, 8:51 PM

Oct 2 2015

op added inline comments to D3781: simplify the motd updating script.
Oct 2 2015, 4:24 PM
op updated the diff for D3781: simplify the motd updating script.

update one missing place

Oct 2 2015, 11:55 AM
op retitled D3781: simplify the motd updating script from to simplify the motd updating script.
Oct 2 2015, 11:53 AM

Sep 27 2015

op added a comment to D3001: Activate relro and bindnow in build system.
In D3001#77191, @pfg wrote:
In D3001#77190, @kib wrote:
In D3001#77189, @pfg wrote:

Private code can still disable relro, but I see your point.

Nevertheless, it still will be interesting to see, through the exp-run, how ports react to having relro by default.

You would only see a half of the interesting things, at best. Another half happens at runtime, which cannot be tested by an exp-run.

The toolchain will certainly be runtime tested, and some ports have testing targets.

I am also running it on my box. The question is .. what would be affected? Is there any particular port I should check?

Sep 27 2015, 7:50 PM

Sep 21 2015

op added a comment to D3565: Per-Process PS_STRINGS, USRSTACK, shared_object_base, and sigcode_base.
In D3565#74326, @kib wrote:

Anything like this patch can only be considered if your 'aslr' implementation is ever found acceptable. Until it is not, the patch only adds bloat.

Sep 21 2015, 12:15 PM · HardenedBSD
op added a reviewer for D3565: Per-Process PS_STRINGS, USRSTACK, shared_object_base, and sigcode_base: adrian.
Sep 21 2015, 11:26 AM · HardenedBSD
op abandoned D2954: Fix the is_procstack expression in vm_map_growstack(...)..

This patch is committed as r285046 by kib.

Sep 21 2015, 11:25 AM
op closed D2953: Do not calculate the stack's bottom address twice..

Committed, close.

Sep 21 2015, 10:53 AM
op abandoned D2960: on i386 USRSTACK points one page below the VM_MAXUSER_ADDRESS.

This was superseded with D2971, so close them.

Sep 21 2015, 10:52 AM
op abandoned D3455: [7/N] FORTIFY_SOURCE: add stdio.h related fortified functions: __f{gets,read,write}_chk, __{,v}s{,n}printf_chk.
Sep 21 2015, 10:50 AM · fortify source
op abandoned D3454: [6/N] FORTIFY_SOURCE: add sys/stat.h related fortified functions: __umask_chk.
Sep 21 2015, 10:50 AM · fortify source
op abandoned D3453: [5/N] FORTIFY_SOURCE: add sys/socket.h related fortified functions: __recvfrom_chk.
Sep 21 2015, 10:50 AM · fortify source
op abandoned D3452: [4/N] FORTIFY_SOURCE: add sys/poll.h related fortified functions: __poll_chk and __ppoll_chk.
Sep 21 2015, 10:49 AM · fortify source
op abandoned D3450: [3/N] FORTIFY_SOURCE: disable the FORTIFY_SOURCE on programs, which depends on libstand or knowly not compiles with FORTIFTY_SOURCE.
Sep 21 2015, 10:49 AM · fortify source
op abandoned D3449: [2/N] FORTIFY_SOURCE: #undef _FORTIFY_SOURCE to avoid infinite recursion.
Sep 21 2015, 10:49 AM · fortify source
op abandoned D3448: [1/N] FORTIFY_SOURCE: basic requirements and framework.
Sep 21 2015, 10:49 AM · fortify source

Aug 28 2015

op added a comment to D3001: Activate relro and bindnow in build system.
In D3001#72044, @pfg wrote:

Just an opinion ...
Going for the "partial" relro (without bindnow) seems like an obvious win.

Agreed. Would it be a good idea to have bindnow as a WITH_* flag that defaults to off?

Aug 28 2015, 6:30 PM

Aug 23 2015

op added a comment to D3463: Adopt higher level of stack protection..

We should investigate that the -fstack-protector-strong triggers the same as -fstack-protector-all:

Aug 23 2015, 12:07 PM · security
op added a comment to D3463: Adopt higher level of stack protection..
Aug 23 2015, 12:03 PM · security

Aug 21 2015

op added a dependent revision for D3454: [6/N] FORTIFY_SOURCE: add sys/stat.h related fortified functions: __umask_chk: D3455: [7/N] FORTIFY_SOURCE: add stdio.h related fortified functions: __f{gets,read,write}_chk, __{,v}s{,n}printf_chk.
Aug 21 2015, 10:35 PM · fortify source
op added a dependency for D3455: [7/N] FORTIFY_SOURCE: add stdio.h related fortified functions: __f{gets,read,write}_chk, __{,v}s{,n}printf_chk: D3454: [6/N] FORTIFY_SOURCE: add sys/stat.h related fortified functions: __umask_chk.
Aug 21 2015, 10:35 PM · fortify source
op retitled D3455: [7/N] FORTIFY_SOURCE: add stdio.h related fortified functions: __f{gets,read,write}_chk, __{,v}s{,n}printf_chk from to [7/N] FORTIFY_SOURCE: add stdio.h related fortified functions: __f{gets,read,write}_chk, __{,v}s{,n}printf_chk.
Aug 21 2015, 10:35 PM · fortify source
op retitled D3454: [6/N] FORTIFY_SOURCE: add sys/stat.h related fortified functions: __umask_chk from add sys/stat.h related fortified functions: __umask_chk to [6/N] FORTIFY_SOURCE: add sys/stat.h related fortified functions: __umask_chk.
Aug 21 2015, 10:11 PM · fortify source
op added a dependency for D3454: [6/N] FORTIFY_SOURCE: add sys/stat.h related fortified functions: __umask_chk: D3453: [5/N] FORTIFY_SOURCE: add sys/socket.h related fortified functions: __recvfrom_chk.
Aug 21 2015, 10:10 PM · fortify source
op added a dependent revision for D3453: [5/N] FORTIFY_SOURCE: add sys/socket.h related fortified functions: __recvfrom_chk: D3454: [6/N] FORTIFY_SOURCE: add sys/stat.h related fortified functions: __umask_chk.
Aug 21 2015, 10:10 PM · fortify source
op retitled D3454: [6/N] FORTIFY_SOURCE: add sys/stat.h related fortified functions: __umask_chk from to add sys/stat.h related fortified functions: __umask_chk.
Aug 21 2015, 10:10 PM · fortify source
op added a dependency for D3453: [5/N] FORTIFY_SOURCE: add sys/socket.h related fortified functions: __recvfrom_chk: D3452: [4/N] FORTIFY_SOURCE: add sys/poll.h related fortified functions: __poll_chk and __ppoll_chk.
Aug 21 2015, 9:51 PM · fortify source
op added a dependent revision for D3452: [4/N] FORTIFY_SOURCE: add sys/poll.h related fortified functions: __poll_chk and __ppoll_chk: D3453: [5/N] FORTIFY_SOURCE: add sys/socket.h related fortified functions: __recvfrom_chk.
Aug 21 2015, 9:51 PM · fortify source
op retitled D3453: [5/N] FORTIFY_SOURCE: add sys/socket.h related fortified functions: __recvfrom_chk from to [5/N] FORTIFY_SOURCE: add sys/socket.h related fortified functions: __recvfrom_chk.
Aug 21 2015, 9:50 PM · fortify source
op added a dependent revision for D3448: [1/N] FORTIFY_SOURCE: basic requirements and framework: D3452: [4/N] FORTIFY_SOURCE: add sys/poll.h related fortified functions: __poll_chk and __ppoll_chk.
Aug 21 2015, 9:35 PM · fortify source
op added dependencies for D3452: [4/N] FORTIFY_SOURCE: add sys/poll.h related fortified functions: __poll_chk and __ppoll_chk: D3450: [3/N] FORTIFY_SOURCE: disable the FORTIFY_SOURCE on programs, which depends on libstand or knowly not compiles with FORTIFTY_SOURCE, D3449: [2/N] FORTIFY_SOURCE: #undef _FORTIFY_SOURCE to avoid infinite recursion, D3448: [1/N] FORTIFY_SOURCE: basic requirements and framework.
Aug 21 2015, 9:35 PM · fortify source