libxo: add missing error check after xo_parse_args in netstat
ClosedPublic
Actions

Authored by op on Nov 20 2015, 2:02 PM.

Details

Reviewers

sjg
ume

Commits

rS291247: Add missing error check after xo_parse_args() in netstat(8).

Summary

Before this fix:

op@opn ~> netstat --libxo=J
netstat: unknown libxo option value: 'J'
netstat: kvm not available: /dev/mem: Permission denied

After the fix applied:

op@opn ~> netstat --libxo=J
netstat: unknown libxo option value: 'J'

Obtained-from: HardenedBSD

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

op updated this revision to Diff 10377.Nov 20 2015, 2:02 PM

op retitled this revision from to libxo: add missing error check after xo_parse_args in netstat.

op updated this object.

op edited the test plan for this revision. (Show Details)

op added reviewers: ume, sjg.

op set the repository for this revision to rS FreeBSD src repository - subversion.

op added a subscriber: pfg.

Herald added a subscriber: imp. · View Herald TranscriptNov 20 2015, 2:02 PM

op updated this object.Nov 20 2015, 2:02 PM

It seems good to me.

Could you please commit the patch, if the diff fine?

Closed by commit rS291247: Add missing error check after xo_parse_args() in netstat(8). (authored by ume). · Explain WhyNov 24 2015, 11:08 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

head/

usr.bin/

netstat/

main.c

2 lines

Diff 10465

View Options

head/usr.bin/netstat/main.c

libxo: add missing error check after xo_parse_args in netstatClosedPublicActions