Page MenuHomeFreeBSD
Differential D4233

libxo: add missing error check after xo_parse_args in netstat
ClosedPublic
Actions

Authored by op on Nov 20 2015, 2:02 PM.
Tags
None
Referenced Files
F156596191: D4233.id10465.diff
Thu, May 14, 11:36 PM
F156586409: D4233.id10377.diff
Thu, May 14, 9:32 PM
F156576220: D4233.id.diff
Thu, May 14, 7:22 PM
Unknown Object (File)
Mon, May 11, 7:43 PM
Unknown Object (File)
Mon, May 11, 4:07 AM
Unknown Object (File)
Thu, Apr 30, 7:37 AM
Unknown Object (File)
Thu, Apr 23, 3:59 AM
Unknown Object (File)
Tue, Apr 21, 9:01 AM
View All Files
Subscribers
imp
pfg

Details

Reviewers
sjg
ume
Commits
rS291247: Add missing error check after xo_parse_args() in netstat(8).
Summary

Before this fix:

op@opn ~> netstat --libxo=J
netstat: unknown libxo option value: 'J'
netstat: kvm not available: /dev/mem: Permission denied

After the fix applied:

op@opn ~> netstat --libxo=J
netstat: unknown libxo option value: 'J'

Obtained-from: HardenedBSD

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

op updated this revision to Diff 10377.Nov 20 2015, 2:02 PM
op retitled this revision from to libxo: add missing error check after xo_parse_args in netstat.
op updated this object.
op edited the test plan for this revision. (Show Details)
op added reviewers: ume, sjg.
op set the repository for this revision to rS FreeBSD src repository - subversion.
op added a subscriber: pfg.
Herald added a subscriber: imp. · View Herald TranscriptNov 20 2015, 2:02 PM
op updated this object.Nov 20 2015, 2:02 PM
ume edited edge metadata.Nov 20 2015, 2:30 PM

It seems good to me.

op added a comment.Nov 23 2015, 6:58 PM

Could you please commit the patch, if the diff fine?

Closed by commit rS291247: Add missing error check after xo_parse_args() in netstat(8). (authored by ume). · Explain WhyNov 24 2015, 11:08 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
head/
usr.bin/
netstat/
2 lines

Diff 10465

View Options

head/usr.bin/netstat/main.c

Loading...