HBSD: fix long standing issue in bsdconfig's keymap selection Since the translation to vt as terminal emulator, the keymaps files path has changed and this change does not get followed in bsdconfig. This implicates boot time warnings about a wrong keymap file, what is very confusing for the new users and for me too, so initialize the default keymaps search path depending on terminal type. Sponsored-by: HardenedBSD Signed-off-by: Oliver Pinter <oliver.pinter@hardenedbsd.org>
Details
Details
Diff Detail
Diff Detail
- Repository
- rS FreeBSD src repository - subversion
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
Comment Actions
Looks good to me otherwise.
| usr.sbin/bsdconfig/console/keymap | ||
|---|---|---|
| 312 ↗ | (On Diff #22812) | It is remarkable to see the quotes omitted where they may be useful (around the substitution), and placed where they are definitely optional. (Occurs two times.) |
| usr.sbin/bsdconfig/console/keymap | ||
|---|---|---|
| 312 ↗ | (On Diff #22812) | To be internally consistent with the rest of this file, please put a single space after the left-paren and before the right-paren. E.g., $(sysctl ...) => $( sysctl ... ) Also, what Jilles said. |
| usr.sbin/bsdconfig/share/keymap.subr | ||
| 42 ↗ | (On Diff #22812) | Same thing here as line 312 of console/keymap; add whitespace and quotes |
| usr.sbin/bsdconfig/console/keymap | ||
|---|---|---|
| 312 ↗ | (On Diff #22812) | Using wrong comparison operator; -ne should be != % sh -c '[ foo -ne bar ]' |
| usr.sbin/bsdconfig/share/keymap.subr | ||
| 42 ↗ | (On Diff #22812) | Using the wrong comparison operator; -ne is for numeric comparison, != is for string comparison |