Page MenuHomeFreeBSD

simplify compile-time default keyboard map generation
ClosedPublic

Authored by emaste on Mar 22 2016, 8:33 PM.

Details

Summary

In rS296926 the -P <path> option was added to kbdcontrol, in order to simplify building compile-time default keymaps. Make kbdcontrol a build tool to use the new -P support.

PR: 193865

Diff Detail

Repository
rS FreeBSD src repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

emaste updated this revision to Diff 14528.Mar 22 2016, 8:33 PM
emaste retitled this revision from to simplify compile-time default keyboard map generation.
emaste updated this object.
emaste edited the test plan for this revision. (Show Details)
emaste added reviewers: bdrewery, op.
op edited edge metadata.Mar 22 2016, 11:23 PM

Looks good to me, but not yet tested (I will at weekend.).

Btw, other architectures are not affected?
Or would not be better to move the generation of this file to the generic config rather then keeping them in arch specific files?

op accepted this revision.Mar 28 2016, 7:14 PM
op edited edge metadata.

Tested with these settings:

  • built SC kernel on VT kernel:
makeoptions KBDMUX_DFLT_KEYMAP="us.pc-ctrl"
makeoptions UKBD_DFLT_KEYMAP="us.pc-ctrl"
makeoptions ATKBD_DFLT_KEYMAP="us.pc-ctrl"
  • built VT kernel on SC kernel:
makeoptions KBDMUX_DFLT_KEYMAP="us.ctrl"
makeoptions UKBD_DFLT_KEYMAP="us.ctrl"
makeoptions ATKBD_DFLT_KEYMAP="us.ctrl"
  • built VT kernel on VT kernel:
makeoptions KBDMUX_DFLT_KEYMAP="us.ctrl"
makeoptions UKBD_DFLT_KEYMAP="us.ctrl"
makeoptions ATKBD_DFLT_KEYMAP="us.ctrl"

Btw, it would be nice to MFC this change to 10-STABLE too.

This revision is now accepted and ready to land.Mar 28 2016, 7:14 PM
This revision was automatically updated to reflect the committed changes.

Btw, it would be nice to MFC this change to 10-STABLE too.

Yes, I intend to bring in an updated version of the kbdmux keymap change, and merge all of the kbdmap changes to stable/10 in a while.