Differential D57909

libfetch: Apply timeout to connection attempts
ClosedPublic
Actions

Authored by des on Jun 27 2026, 3:45 PM.

Tags

None

Referenced Files

	F164533464: D57909.diff
	Sat, Aug 1, 9:42 PM

	Unknown Object (File)
	Mon, Jul 27, 5:54 AM

	Unknown Object (File)
	Sat, Jul 25, 4:59 PM

	Unknown Object (File)
	Sat, Jul 25, 1:46 PM

	Unknown Object (File)
	Sat, Jul 25, 6:07 AM

	Unknown Object (File)
	Fri, Jul 24, 11:51 PM

	Unknown Object (File)
	Thu, Jul 23, 1:26 PM

	Unknown Object (File)
	Wed, Jul 22, 1:28 PM

Subscribers

Details

Reviewers

bapt
op

Commits

rG74a92173dc61: libfetch: Apply timeout to connection attempts
rGad7a1446c1e6: libfetch: Apply timeout to connection attempts
rG848f360c8f9a: libfetch: Apply timeout to connection attempts

Summary

Mark the socket non-blocking before connecting and poll for completion,
applying fetchTimeout if set.

MFC after: 1 week

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

des created this revision.Jun 27 2026, 3:45 PM

Herald added a subscriber: imp. · View Herald TranscriptJun 27 2026, 3:45 PM

des requested review of this revision.Jun 27 2026, 3:45 PM

Harbormaster completed remote builds in B74331: Diff 180823.Jun 27 2026, 3:45 PM

des added a child revision: D57910: libfetch: Document fetchTimeout.Jun 27 2026, 3:46 PM

des added a child revision: D57911: fetch: Stop setting an alarm.Jun 27 2026, 3:46 PM

op accepted this revision.Wed, Jul 8, 11:37 AM

This revision is now accepted and ready to land.Wed, Jul 8, 11:37 AM

Closed by commit rG848f360c8f9a: libfetch: Apply timeout to connection attempts (authored by des). · Explain WhyMon, Jul 13, 6:46 AM

This revision was automatically updated to reflect the committed changes.

des added a commit: rG848f360c8f9a: libfetch: Apply timeout to connection attempts.

des added a commit: rGad7a1446c1e6: libfetch: Apply timeout to connection attempts.Tue, Jul 21, 5:04 PM

des added a commit: rG74a92173dc61: libfetch: Apply timeout to connection attempts.

Revision Contents
Changeset List

Path

Size

lib/

libfetch/

47 lines

Diff 181880

lib/libfetch/common.c

Loading...