bump check for PMC architecture in hwpmc core
ClosedPublic
Actions

Authored by op on Jan 3 2017, 11:25 PM.

Details

Reviewers

kib
jhb
rrs

Commits

rS311224: Fix PMC architecture check to handle later IPAs including Skylake

Summary

This fixes the hwpmcs on Intel i7-6700 CPU.

Before this fix on hwpmc module load, we got this error message:

[82] hwpc_core: unknown PMC architecture: 4
[82] hwpmc: SOFT/16/64/0x67<INT,USR,SYS,REA,WRI>

but with this patch:

[335] hwpmc: SOFT/16/64/0x67<INT,USR,SYS,REA,WRI> TSC/1/64/0x20<REA> IAP/4/48/0x3ff<INT,USR,SYS,EDG,THR,REA,WRI,INV,QUA,PRC> IAF/3/48/0x67<INT,USR,SYS,REA,WRI>

and the hwpmc is fully functional.

Obtained-from: opBSD

Test Plan

0. get a skylake cpu based system

apply the patch
recompile the hwpmc module
kldload hwpmc
pmcstat -T -S instructions

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

op updated this revision to Diff 23586.Jan 3 2017, 11:25 PM

op retitled this revision from to bump check for PMC architecture check in hwpmc core.

op updated this object.

op edited the test plan for this revision. (Show Details)

op added reviewers: rrs, kib, jhb.

op set the repository for this revision to rS FreeBSD src repository - subversion.

Herald added subscribers: gnn, imp. · View Herald TranscriptJan 3 2017, 11:25 PM

(When the diff got a positive review, please commit them.)

Closed by commit rS311224: Fix PMC architecture check to handle later IPAs including Skylake (authored by gnn). · Explain WhyJan 4 2017, 2:15 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

head/

sys/

dev/

hwpmc/

hwpmc_core.c

2 lines

Diff 23590

View Options

head/sys/dev/hwpmc/hwpmc_core.c

bump check for PMC architecture in hwpmc coreClosedPublicActions