simplify the motd updating script
Needs ReviewPublic
Actions

Authored by op on Oct 2 2015, 11:53 AM.

Details

Reviewers

swills
bdrewery

Summary

Test Plan

Change your /etc/motd's first line to not begin with FreeBSD word, and run the script two times.

Lint

Lint Skipped

Unit

Tests Skipped

op retitled this revision from to simplify the motd updating script.

op updated this object.

op edited the test plan for this revision. (Show Details)

op added reviewers: bdrewery, swills, pfg.

op set the repository for this revision to rS FreeBSD src repository - subversion.

update one missing place

etc/rc.d/motd
18	What benefit is there to this? Is it solving something you ran into?

op added inline comments.Oct 2 2015, 4:24 PM

etc/rc.d/motd
18	Just a refactor.

etc/rc.d/motd
18	Line 32 missed ${MOTD_FILE}. I don't really see the benefit in changing this; I don't like changing things for no good reason. If MOTD_FILE was in etc/defaults/rc.conf and had some reason to be moved I would be more inclined to consider this, but I don't see a great benefit in that either.

pfg resigned from this revision.May 2 2016, 7:24 PM

pfg removed a reviewer: pfg.

Path

Size

etc/

rc.d/

18 lines