Ask SPMC for D-state in s2idle instead of _S255D

is there any concern for breaking existing m4 programs?

kind of dirty, but ig you could have another function for generating these testcases using eval:

Does this mean all TB3 support will be removed?

This makes sense, but do note that light ridge is not currently in tb_pcib_identifiers and probably won't be supported any time soon (if ever) due to it I'd assume using an internal connection manager

Don't need to check for NULL if EVENTHANDLER_REGISTER never returns it anyway.

Don't need to check for NULL if EVENTHANDLER_REGISTER never returns it anyway.

Rename hooks again + don't check EVENTHANDLER_REGISTER

Rename hooks again + don't check EVENTHANDLER_REGISTER

Oops

Oops

Use acpi_pmc_suspend/acpi_pmc_resume to acpi_late_suspend/acpi_early_resume respectively (at request of olce@).

Rename acpi_pmc_suspend/acpi_pmc_resume to acpi_late_suspend/acpi_early_resume respectively (at request of olce@).

accepting so I can close this again manually

Small style changes.

Remove dev/acpica/acpi_pmc_if.m from sys/conf/files

oops, wrong revision

Use eventhandler hooks instead of new acpi_pmc interface

Use eventhandler hooks instead of new acpi_pmc interface

Use eventhandler hooks instead of acpi_pmc interface.

thanks for pointing this out. Have a fix, just building with ACPI_DEBUG to make sure everything is fixed...

will fix trailing whitespaces on commit

Cool that someone is working on an intel PMC driver!

Include opt_acpi.h for DEV_ACPI

Use new acpi_pmc interface (see D48735) instead of new methods on device interface, and generally simplify how this is being called in acpi_EnterSleepState().

Add acpi_pmc interface, which acpi_EnterSleepState() calls the suspend and resume methods of during late suspend and early resume.

once added in D48735, this should use the PMC interface too

Typo in comments

Newline after DSM set unexpected enum functions warning messages + fix DSM revision sysctl default values.

Align declarations.

acpi_spmc_check_dsm_set() function which enables DSM set so long as enum functions DSM is supported (bit 1), but warns if incomplete vs what we expect.

• Add dsms_needed mask to each DSM set definition to check the result of enum functions (acpi_DSMQuery()) against.
• Default AMD DSM set revision ID to 2 as my ASL suggests it should be.
• Add debug.acpi.spmc.amd_dsm_revision sysctl so we can easily test emulating Linux's behaviour of using revision ID 0 (probably won't make a different irl - at least my ASL doesn't ever check for revision ID in DSM implementations).
• Return 0 in probe instead of BUS_PROBE_DEFAULT.
• Fix style/comment placement.

thanks for the review!

Make hw.acpi.spmc.intel_dsm_revision sysctl operate directly on Intel DSM set struct.

Make sched_preempt_locked entirely responsible for releasing thread lock and style change.

looks good!

Don't ever use Microsoft DSM UUID for getting constraints, as this isn't supported (checked on Intel acpidump).

Comment about changing sc->constraint_count and more style(9) improvements.

Remove struct acpi_spmc_private and just set DSM set flags directly on softc + style(9) improvements.

See changes/comments in D48387, but will add an interface for PMC suspend and resume which this will use.

Which kind of interrupts do you still see that prevent staying in S0ix? I think you mentioned some IPIs at some point, but which ones? Can we determine their cause?

Remove SPMC callbacks on struct acpi_softc. I will replace them with new pmc_suspend and pmc_resume methods in another revision. This leaves the acpi_spmc_suspend and acpi_spmc_resume (renamed from acpi_spmc_enter/exit) functions unused at the moment. Lmk if this is okay or if you'd rather I add these in a different revision too.

fixed most of the issues highlighted. Will address the allocating-memory-in-probe-function pattern and add an interface for late suspend/early resume (or maybe call this something like pmc_enter and pmc_exit? then again maybe on some platforms the PMC isn't necessarily intended to be called after device suspend) in the future.