ack your review comments, I have a couple changes I need to bring out of a stash commit before I address your comments. My local commit log is getting pretty messy from all the suspend debugging stuff I'm trying ;)

Fix DSM call ordering

thanks for taking a look at this!

Remove previous IDs.

In D53201#1215648, @jhb wrote:

This fixes a panic when devmatch autoloads on my laptop.

tested it out on my machine and all is good

In D51591#1208761, @bz wrote:

I might go as far as splitting this into (a) the general event handler update and (b) improving linuxkpi?

Superseded by D52861 and D52862

thanks for doing this work!

rebase

More typo fixes and drop __FBSDID tags

Roll typo fixes into this revision

rebase

rebase

thanks for your review!

Remove nhi_compat.h, typo

rebase

Fix S3 suspend.

Rebase on top of D52705.

fixes from review comment in D52598

these changes have been rolled into D52705 because the original commit that had these changes had to be reverted anyways.

In D52598#1201481, @madpilot wrote:

I finally tested this and works fine for me.

I'm sorry I was unable to test it earlier!

In D52598#1201370, @zarychtam_plan-b.pwste.edu.pl wrote:

This patch fixes panic. Please push it when it's ready.

Edit: Unfortunately, suspend is still broken, PC wakes up immediately.

Move struct acpi_wake_prep_context out of acpivar.h

In D52600#1201315, @cy wrote:

This patch fails to address the regression.

Do this correctly.

yeah you're absolutely right, I thought acpi_shutdown's dev was a device but its the actual bus of course so this is easy. Will do that in a minute

Abandoned in favour of the D52036, D52043, D52036 stack.