User Details
User Details
- User Since
- Jul 12 2022, 11:32 AM (189 w, 19 h)
Yesterday
Yesterday
obiwac added a comment to D55472: appleir: Add Apple IR receiver driver.
haven't done a hugely in-depth review yet. Overall looks pretty good!
Mon, Feb 23
Mon, Feb 23
obiwac added inline comments to D55463: mpool/mpool_get.c: Avoid clobbering 'errno' when handling 'pread' errors.
obiwac committed rG16822dac32ab: acpi_panasonic: Clear wireless RF_KILL on boot and resume (authored by guest-seuros).
acpi_panasonic: Clear wireless RF_KILL on boot and resume
Sat, Feb 21
Sat, Feb 21
obiwac committed rG98ffaae49fea: libc: Roll {l,ll,imax}abs(3) manpages into just abs(3) (authored by obiwac).
libc: Roll {l,ll,imax}abs(3) manpages into just abs(3)
stdckdint.3: Fix standard in comment
obiwac committed rGc242bf1b7079: libc: Roll {l,ll,imax}div(3) manpages into just div(3) (authored by obiwac).
libc: Roll {l,ll,imax}div(3) manpages into just div(3)
obiwac added inline comments to D55360: libc: Roll {l,ll,imax}div(3) manpages into just div(3).
obiwac updated the test plan for D55361: libc: Roll {l,ll,imax}abs(3) manpages into just abs(3).
obiwac updated the diff for D55360: libc: Roll {l,ll,imax}div(3) manpages into just div(3).
update names
obiwac updated the diff for D55361: libc: Roll {l,ll,imax}abs(3) manpages into just abs(3).
update HISTORY & names
obiwac updated the test plan for D55360: libc: Roll {l,ll,imax}div(3) manpages into just div(3).
obiwac added inline comments to D55360: libc: Roll {l,ll,imax}div(3) manpages into just div(3).
obiwac updated the diff for D55360: libc: Roll {l,ll,imax}div(3) manpages into just div(3).
update history section
Fri, Feb 20
Fri, Feb 20
obiwac updated the test plan for D55361: libc: Roll {l,ll,imax}abs(3) manpages into just abs(3).
obiwac updated the test plan for D55360: libc: Roll {l,ll,imax}div(3) manpages into just div(3).
obiwac added inline comments to D55360: libc: Roll {l,ll,imax}div(3) manpages into just div(3).
obiwac updated the diff for D55361: libc: Roll {l,ll,imax}abs(3) manpages into just abs(3).
remove LIBRARY
obiwac updated the diff for D55360: libc: Roll {l,ll,imax}div(3) manpages into just div(3).
remove LIBRARY
Thu, Feb 19
Thu, Feb 19
obiwac added inline comments to D55360: libc: Roll {l,ll,imax}div(3) manpages into just div(3).
obiwac added reviewers for D55360: libc: Roll {l,ll,imax}div(3) manpages into just div(3): Klara, manpages.
obiwac added reviewers for D55361: libc: Roll {l,ll,imax}abs(3) manpages into just abs(3): Klara, manpages.
obiwac added inline comments to D55360: libc: Roll {l,ll,imax}div(3) manpages into just div(3).
obiwac updated the diff for D55361: libc: Roll {l,ll,imax}abs(3) manpages into just abs(3).
use posix 2024 as standard
obiwac updated the diff for D55360: libc: Roll {l,ll,imax}div(3) manpages into just div(3).
use posix 2024 as standard
obiwac added a reviewer for D55370: alloca.3: Add entry about defining VLAs in same block as alloca() to BUGS: Klara.
obiwac added reviewers for D55370: alloca.3: Add entry about defining VLAs in same block as alloca() to BUGS: bnovkov, kevans.
obiwac updated the diff for D55370: alloca.3: Add entry about defining VLAs in same block as alloca() to BUGS.
Comments to clarify example code.
obiwac requested review of D55370: alloca.3: Add entry about defining VLAs in same block as alloca() to BUGS.
obiwac requested review of D55361: libc: Roll {l,ll,imax}abs(3) manpages into just abs(3).
obiwac updated the diff for D55360: libc: Roll {l,ll,imax}div(3) manpages into just div(3).
oops wrong diff :P
obiwac updated the diff for D55360: libc: Roll {l,ll,imax}div(3) manpages into just div(3).
respond to des@'s review comments
obiwac updated the test plan for D55360: libc: Roll {l,ll,imax}div(3) manpages into just div(3).
obiwac updated the summary of D55360: libc: Roll {l,ll,imax}div(3) manpages into just div(3).
Wed, Feb 18
Wed, Feb 18
obiwac added inline comments to D55360: libc: Roll {l,ll,imax}div(3) manpages into just div(3).
obiwac updated the test plan for D55360: libc: Roll {l,ll,imax}div(3) manpages into just div(3).
obiwac requested review of D55360: libc: Roll {l,ll,imax}div(3) manpages into just div(3).
tested, all works. just style to improve but can be done on commit/later
Tue, Feb 17
Tue, Feb 17
obiwac updated the diff for D55118: acpi: Ask SPMC for D-state in s2idle instead of _S255D.
Fix passing dev instead of handle to acpi_device_pwr_for_sleep_sxd
obiwac added a comment to D55226: acpi: Factor out the power off code into acpi_poweroff().
nit: acpi_poweroff generally has kind of a mix of styles. It would be good to have just tabs to completely match FreeBSD style.
libc: Improve {,l,ll,imax}div(3) manpages
obiwac committed rG69a3d9ab8019: touch: Fix setting time of created file if fstat() fails (authored by obiwac).
touch: Fix setting time of created file if fstat() fails
obiwac committed rGd93f337357a8: EVENTHANDLER.9: EVENTHANDLER_REGISTER never fails (authored by obiwac).
EVENTHANDLER.9: EVENTHANDLER_REGISTER never fails
Mon, Feb 16
Mon, Feb 16
obiwac added a comment to D55265: acpi_panasonic: Clear wireless RF_KILL on boot and resume.
if we want similar functionality to rfkill on Linux (i.e. user events for rfkill hard block state change), then it probably makes sense for us also to have a rfkill devnode we can register kevents on. Then ioctls for soft block state change/hard block query maybe instead of sysctls
Fri, Feb 13
Fri, Feb 13
obiwac added inline comments to D55265: acpi_panasonic: Clear wireless RF_KILL on boot and resume.
Thu, Feb 12
Thu, Feb 12
libc: Improve {,l,ll,imax}div(3) manpages
libc: Remove leftover comments
Sat, Feb 7
Sat, Feb 7
obiwac added inline comments to D54410: acpi: Implement s2idle loop.
obiwac added a reverting change for rGc0df8f6f0e6a: acpi: Make taskqueue only run on BSP: rGf3e9c94bc5e6: Revert "acpi: Make taskqueue only run on BSP".
obiwac committed rGf3e9c94bc5e6: Revert "acpi: Make taskqueue only run on BSP" (authored by obiwac).
Revert "acpi: Make taskqueue only run on BSP"
obiwac added a reverting change for D54406: acpi: Make taskqueue only run on BSP: rGf3e9c94bc5e6: Revert "acpi: Make taskqueue only run on BSP".
Fri, Feb 6
Fri, Feb 6
obiwac retitled D55118: acpi: Ask SPMC for D-state in s2idle instead of _S255D from acpi: Evaluate _S3D instead of _S225D when entering s2idle to acpi: Ask SPMC for D-state in s2idle instead of _S255D.
obiwac updated the diff for D55118: acpi: Ask SPMC for D-state in s2idle instead of _S255D.
Ask SPMC for D-state in s2idle instead of _S255D
obiwac committed rG067ad8b31bf6: thunderbolt: Fix tb_pcib device matching to check PCI class (authored by guest-seuros).
thunderbolt: Fix tb_pcib device matching to check PCI class
obiwac added inline comments to D54881: intel/intel_pmc_core: Add Intel PMC Core driver.
Thu, Feb 5
Thu, Feb 5
sys/power.h: enum power_sstate_transition
acpi: Fix trying to enter NONE state
obiwac added inline comments to D52497: sys/power.h: `enum power_sstate_transition`.
obiwac committed rGb8d55a86995b: touch: Fix setting time of created file if fstat() fails (authored by obiwac).
touch: Fix setting time of created file if fstat() fails
obiwac updated the summary of D55119: acpi: Fix trying to enter NONE state.
obiwac requested review of D55119: acpi: Fix trying to enter NONE state.
is there any concern for breaking existing m4 programs?
obiwac added a comment to D55115: m4: Convert tests to ATF.
kind of dirty, but ig you could have another function for generating these testcases using eval:
obiwac updated the summary of D55118: acpi: Ask SPMC for D-state in s2idle instead of _S255D.
obiwac retitled D55118: acpi: Ask SPMC for D-state in s2idle instead of _S255D from acpi: _S225D fix to acpi: Evaluate _S3D instead of _S225D when entering s2idle.
obiwac updated the summary of D55118: acpi: Ask SPMC for D-state in s2idle instead of _S255D.
obiwac requested review of D55118: acpi: Ask SPMC for D-state in s2idle instead of _S255D.
obiwac added a comment to D52861: thunderbolt: Support generic USB4 NHIs.
Does this mean all TB3 support will be removed?
Wed, Feb 4
Wed, Feb 4
obiwac added a reviewer for D55102: thunderbolt: Fix tb_pcib device matching to check PCI class: jhb.
This makes sense, but do note that light ridge is not currently in tb_pcib_identifiers and probably won't be supported any time soon (if ever) due to it I'd assume using an internal connection manager
obiwac requested review of D55117: touch: Fix setting time of created file if fstat() fails.
Tue, Feb 3
Tue, Feb 3
obiwac committed rG9d4bad45e233: EVENTHANDLER.9: EVENTHANDLER_REGISTER never fails (authored by obiwac).
EVENTHANDLER.9: EVENTHANDLER_REGISTER never fails
Mon, Feb 2
Mon, Feb 2
obiwac committed rGfedc9746bd37: acpi_spmc: Register SPMC suspend/resume routines (authored by obiwac).
acpi_spmc: Register SPMC suspend/resume routines
obiwac committed rG4a71fc3b5ceb: acpi: Post/pre device suspend/resume eventhandlers (authored by obiwac).
acpi: Post/pre device suspend/resume eventhandlers
Sun, Feb 1
Sun, Feb 1
obiwac updated the diff for D48721: amdsmu: Sleep entry/exit hints for PMFW.
Don't need to check for NULL if EVENTHANDLER_REGISTER never returns it anyway.
obiwac updated the diff for D48735: acpi: Call SPMC suspend/resume hooks.
Don't need to check for NULL if EVENTHANDLER_REGISTER never returns it anyway.
Sat, Jan 31
Sat, Jan 31
obiwac requested review of D55014: EVENTHANDLER.9: EVENTHANDLER_REGISTER never fails.
obiwac updated the diff for D48735: acpi: Call SPMC suspend/resume hooks.
Rename hooks again + don't check EVENTHANDLER_REGISTER
obiwac updated the diff for D48721: amdsmu: Sleep entry/exit hints for PMFW.
Rename hooks again + don't check EVENTHANDLER_REGISTER
obiwac updated the diff for D48721: amdsmu: Sleep entry/exit hints for PMFW.
Oops
obiwac updated the diff for D48721: amdsmu: Sleep entry/exit hints for PMFW.
Use acpi_pmc_suspend/acpi_pmc_resume to acpi_late_suspend/acpi_early_resume respectively (at request of olce@).
obiwac updated the diff for D48735: acpi: Call SPMC suspend/resume hooks.
Rename acpi_pmc_suspend/acpi_pmc_resume to acpi_late_suspend/acpi_early_resume respectively (at request of olce@).