acpi: Move sysctl tree set up at end of initialization
ClosedPublic
Actions

Authored by olce on Wed, Jan 28, 12:44 PM.

Details

Reviewers

obiwac
jhb
imp

Commits

rG7f031c9f6b9f: acpi: Move sysctl tree set up at end of initialization

Summary

Setting up the sysctl tree later:

Fixes not de-registering sysctl knobs on failure to attach.
Avoids having inconsistent knob values exposed during a brief moment.

MFC after: 2 weeks
Sponsored by: The FreeBSD Foundation

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

olce created this revision.Wed, Jan 28, 12:44 PM

Herald added a subscriber: imp. · View Herald TranscriptWed, Jan 28, 12:44 PM

olce requested review of this revision.Wed, Jan 28, 12:44 PM

Harbormaster completed remote builds in B70183: Diff 170638.Wed, Jan 28, 12:44 PM

olce mentioned this in D54626: acpi: 'hw.acpi.s4bios' sysctl: Change type to bool, expand description.Wed, Jan 28, 12:47 PM

olce added a child revision: D54626: acpi: 'hw.acpi.s4bios' sysctl: Change type to bool, expand description.Wed, Jan 28, 1:36 PM

This move is good

sys/dev/acpica/acpi.c
607–608	Not sure this needs a comment

This revision is now accepted and ready to land.Wed, Jan 28, 2:17 PM

olce marked an inline comment as done.Wed, Jan 28, 4:31 PM

olce added inline comments.

sys/dev/acpica/acpi.c
607–608	Yeah, I'll remove that.

olce marked an inline comment as done.Mon, Feb 2, 8:39 PM

obiwac accepted this revision.Tue, Feb 3, 3:12 PM

Closed by commit rG7f031c9f6b9f: acpi: Move sysctl tree set up at end of initialization (authored by olce). · Explain WhyTue, Feb 3, 5:20 PM

This revision was automatically updated to reflect the committed changes.

olce added a commit: rG7f031c9f6b9f: acpi: Move sysctl tree set up at end of initialization.

Revision Contents
Changeset List

Path

Size

sys/

dev/

acpica/

acpi.c

120 lines

Diff 171087

View Options

acpi: Move sysctl tree set up at end of initializationClosedPublicActions