Page MenuHomeFreeBSD

acpi: 'hw.acpi.s4bios' sysctl: Change type to bool, expand description
Needs ReviewPublic

Authored by olce on Fri, Jan 9, 5:09 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Jan 31, 11:22 PM
Unknown Object (File)
Fri, Jan 30, 11:14 PM
Unknown Object (File)
Fri, Jan 30, 10:55 AM
Unknown Object (File)
Fri, Jan 30, 10:13 AM
Unknown Object (File)
Fri, Jan 30, 9:14 AM
Unknown Object (File)
Wed, Jan 28, 10:54 PM
Unknown Object (File)
Sun, Jan 25, 7:35 AM
Unknown Object (File)
Fri, Jan 23, 7:27 PM
Subscribers

Details

Reviewers
obiwac
jhb
Summary

Another boolean, indicating hardware support, will be introduced in next commit.

Thanks to the previous commit modifying sysctl_handle_bool(), this
change is backwards-compatible with old programs using an integer in and
out of sysctl(3).

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 70187
Build 67070: arc lint + arc unit

Event Timeline

olce requested review of this revision.Fri, Jan 9, 5:09 PM

I'm not too sure about changing the type of a sysctl knob that has existed for a long time. The only compatibility problem that I can see doing this is potentially breaking reporting in an application that would call sysctl(3) (or sysctlbyname(3)) directly, passing an unitialized integer and then reading from it, as only the first byte would have been filled. Setting the boolean would still work (except on big-endian arches). The use of an old sysctl(8) utility is not affected.

If you feel that's not OK, I could change that part of the commit if necessary, introducing a specific handler to paper over the difference between the sysctl knob type and the field's one.

Accepting assuming no one has objections about changing the size of the sysctl

This revision is now accepted and ready to land.Fri, Jan 9, 7:19 PM
  • Impacts of new prerequisite (D54926)
  • Slightly tweak the description of 'hw.acpi.s4bios'
This revision now requires review to proceed.Wed, Jan 28, 12:47 PM
olce edited the summary of this revision. (Show Details)

Update commit message