acpi: Factor out the power off code into acpi_poweroff()
ClosedPublic
Actions

Authored by olce on Tue, Feb 10, 4:59 PM.

Details

Reviewers

obiwac
jhb

Commits

rGffdfca5982b6: acpi: Factor out the power off code into acpi_poweroff()

Summary

While here, make it print that we are trying to power off upfront, not
really treating differently power off preparation via
acpi_EnterSleepStatePrep() and actual power off via
AcpiEnterSleepState(), which the user does not care about.

While here, capitalize the messages.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

olce created this revision.Tue, Feb 10, 4:59 PM

Herald added a subscriber: imp. · View Herald TranscriptTue, Feb 10, 4:59 PM

olce requested review of this revision.Tue, Feb 10, 4:59 PM

Harbormaster completed remote builds in B70586: Diff 171680.Tue, Feb 10, 4:59 PM

olce added a parent revision: D55225: acpi: Factor out message printing on failure of AcpiEnterSleepStatePrep().Tue, Feb 10, 5:00 PM

nit: acpi_poweroff generally has kind of a mix of styles. It would be good to have just tabs to completely match FreeBSD style.

tested, all works. just style to improve but can be done on commit/later

This revision is now accepted and ready to land.Wed, Feb 18, 2:27 AM

Oh, that was unintended. Already fixed it locally but forgot to update the diff here.

Closed by commit rGffdfca5982b6: acpi: Factor out the power off code into acpi_poweroff() (authored by olce). · Explain WhyThu, Feb 19, 10:30 AM

This revision was automatically updated to reflect the committed changes.

olce added a commit: rGffdfca5982b6: acpi: Factor out the power off code into acpi_poweroff().

Revision Contents
Changeset List

Path

Size

sys/

dev/

acpica/

acpi.c

47 lines

Diff 172217

View Options

acpi: Factor out the power off code into acpi_poweroff()ClosedPublicActions