User Details
- User Since
- Dec 7 2017, 1:03 PM (366 w, 5 d)
Nov 6 2024
Nov 4 2024
Oct 13 2024
Oct 6 2024
Jun 26 2024
Jun 16 2024
Jun 10 2024
Jun 9 2024
Testing with an unmodified Linux nvme-cli fails without the noted change masking cmd. Fix that, and this LGTM. Thanks for all the integration!
Testing with an unmodified Linux nvme-cli looks good using this patch rebased on top of my device alias changes.
Jun 1 2024
May 30 2024
May 23 2024
Apr 25 2024
LGTM
This looks good and helps explain (with examples) a common NVMe stumbling block.
Apr 18 2024
Apr 17 2024
Handful of nits, but overall, LGTM!
Apr 10 2024
Apr 8 2024
amazeballs!
Mar 7 2024
Feb 28 2024
LGTM
Jan 29 2024
Jan 28 2024
Oct 30 2023
Not familiar with this driver, but the changes look OK to me.
Oct 16 2023
LGTM, but I'll give other folks a chance to peek
Oct 12 2023
Oct 11 2023
Updated per review comments
Oct 4 2023
Oct 2 2023
Aug 17 2023
Aug 15 2023
Aug 6 2023
When nda turns off reporting, how are pass-through commands treated? Will this change suppress errors from those commands as well?
If you are looking to add more flag values, I'd move this to after retries and change the type to uint32_t or uint16_t if you think more might be needed in the future.
I like @jhb 's table approach but would prefer the shorter string (i.e., RESERVATION REGISTER vs NVME_OPC_RESERVATION_REGISTER
Jul 21 2023
Tested with smart(8) and all looks good:
# ./smart -d nda0 Critical Warning 0 0 Composite Temperature 1 316 Available Spare 3 100 Available Spare Threshold 4 5 Percentage Used 5 0 Data Units Read 32 1524527 Data Units Written 48 2582739 Host Read Commands 64 22258691 Host Write Commands 80 26153957 Controller Busy Time 96 36 Power Cycles 112 483 Power On Hours 128 2564 Unsafe Shutdowns 144 242 Media and Data Integrity Errors 160 0 Number of Error Information Log Entries 176 373 #
Jul 20 2023
Jul 19 2023
Jun 27 2023
FWIW, I was able to boot an Alma Linux VM with this change
Jun 20 2023
If the transport variable mirrors the Fabric types (i.e., PCIe, RDMA, TCP, FC), this makes sense to me as there are differences (like shown here with the PCIe lane count / speeds) between the -oF transports.
Jun 2 2023
May 17 2023
Feb 25 2023
Other than minor nit, LGTM
Dec 10 2022
Dec 9 2022
Nov 25 2022
LGTM but I'm also curious if @corvink suggestion of %u helps
These changes are good but not really necessary from a functionality point of view. In both cases, the emulation is returning an error, making the LID undefined from the guest's perspective. But I'm all for good hygiene.
LGTM