bhyve nvme: Add NQN value

[chuck]

Summary

Add a NVMe Qualified Name (NQN) to the Controller Data structure using
the "first format" (i.e., "... used by any organization that owns a
domain name" Section 7.9 NVM-Express 1.4c 2021.06.28 Ratified).

This avoids a Linux kernel warning about a missing or invalid NQN.

[jhb]

usr.sbin/bhyve/pci_nvme.c

592

This is a buffer overflow (can read off the end of data), you would need strncpy or the like instead. A direct snprintf is probably simpler.

593

Could you just snprintf(cd->subnqn, sizeof(cd->subnqn), "... and avoid the allocation?

[chuck]

Updated per review comments

[jhb]

usr.sbin/bhyve/pci_nvme.c

588–591

style(9) is a 4 space indent for continuations, you can just fix it as part of the commit though, no need to update the review