Page MenuHomeFreeBSD
Differential D42058

bhyve nvme: Add NQN value
ClosedPublic
Actions

Authored by chuck on Oct 2 2023, 11:01 PM.
Tags
None
Referenced Files
F83966760: D42058.diff
Fri, May 17, 12:57 PM
Unknown Object (File)
Thu, May 9, 9:03 AM
Unknown Object (File)
Tue, Apr 30, 4:17 PM
Unknown Object (File)
Tue, Apr 30, 4:11 PM
Unknown Object (File)
Tue, Apr 30, 4:07 PM
Unknown Object (File)
Tue, Apr 30, 4:07 PM
Unknown Object (File)
Tue, Apr 30, 9:07 AM
Unknown Object (File)
Tue, Apr 23, 8:21 PM
View All 17 Files
Subscribers
bcran
dab
rgrimes

Details

Reviewers
jhb
imp
corvink
Group Reviewers
bhyve
Commits
rG32557d16e2c3: bhyve nvme: Add NQN value
Summary

Add a NVMe Qualified Name (NQN) to the Controller Data structure using
the "first format" (i.e., "... used by any organization that owns a
domain name" Section 7.9 NVM-Express 1.4c 2021.06.28 Ratified).

This avoids a Linux kernel warning about a missing or invalid NQN.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 53926
Build 50816: arc lint + arc unit

Event Timeline

chuck created this revision.Oct 2 2023, 11:01 PM
Herald added a reviewer: bhyve. · View Herald TranscriptOct 2 2023, 11:01 PM
Herald added subscribers: dab, bcran, rgrimes. · View Herald Transcript
chuck requested review of this revision.Oct 2 2023, 11:01 PM
Harbormaster completed remote builds in B53804: Diff 128131.Oct 2 2023, 11:01 PM
jhb accepted this revision.Oct 10 2023, 4:40 PM
jhb added inline comments.
usr.sbin/bhyve/pci_nvme.c
592

This is a buffer overflow (can read off the end of data), you would need strncpy or the like instead. A direct snprintf is probably simpler.

593

Could you just snprintf(cd->subnqn, sizeof(cd->subnqn), "... and avoid the allocation?

This revision is now accepted and ready to land.Oct 10 2023, 4:40 PM
chuck updated this revision to Diff 128581.Oct 11 2023, 4:33 PM

Updated per review comments

This revision now requires review to proceed.Oct 11 2023, 4:33 PM
Harbormaster completed remote builds in B53926: Diff 128581.Oct 11 2023, 4:33 PM
jhb accepted this revision.Oct 12 2023, 5:11 PM
jhb added inline comments.
usr.sbin/bhyve/pci_nvme.c
588–591

style(9) is a 4 space indent for continuations, you can just fix it as part of the commit though, no need to update the review

This revision is now accepted and ready to land.Oct 12 2023, 5:11 PM
Closed by commit rG32557d16e2c3: bhyve nvme: Add NQN value (authored by chuck). · Explain WhyOct 12 2023, 11:48 PM
This revision was automatically updated to reflect the committed changes.
chuck added a commit: rG32557d16e2c3: bhyve nvme: Add NQN value.

Revision Contents
Changeset List

PathSize
usr.sbin/
bhyve/
9 lines

Diff 128581

View Options

usr.sbin/bhyve/pci_nvme.c

Loading...