Page MenuHomeFreeBSD

bhyve: Clear lid to 0 for internal device errors for NVMe AENs.
ClosedPublic

Authored by jhb on Wed, Nov 23, 11:16 PM.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

jhb requested review of this revision.Wed, Nov 23, 11:16 PM
This revision is now accepted and ready to land.Thu, Nov 24, 6:32 AM

These changes are good but not really necessary from a functionality point of view. In both cases, the emulation is returning an error, making the LID undefined from the guest's perspective. But I'm all for good hygiene.

+1 on chuck's results. This can be anything.... but unassigned variables are allowed to have any behavior when accessing them now (well, always, but usually it was just some random value)... So I'm good with the change. It might be simpler to assign lid=0 before the case statement, though.

I think the real issue here is avoiding leaking host hypervisor stack memory to a guest, not if NVMe clients care about the value of lid for these specific cases.