bhyve: Avoid passing a possible garbage pointer to free().
ClosedPublic
Actions

Authored by jhb on Nov 23 2022, 11:16 PM.

Details

Reviewers

markj
corvink

Group Reviewers

bhyve

Commits

rG225443828ec6: bhyve: Avoid passing a possible garbage pointer to free().
rGbc928800723b: bhyve: Avoid passing a possible garbage pointer to free().

Summary

All of the error paths in pci_vtcon_sock_add free the sock pointer.
However, sock is not initialized until part way through the function.
An early error would pass stack garbage to free().

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

jhb created this revision.Nov 23 2022, 11:16 PM

Herald added a reviewer: bhyve. · View Herald TranscriptNov 23 2022, 11:16 PM

Herald added subscribers: bcran, rgrimes, imp. · View Herald Transcript

jhb requested review of this revision.Nov 23 2022, 11:16 PM

Harbormaster completed remote builds in B48482: Diff 113472.Nov 23 2022, 11:17 PM

jhb added a parent revision: D37490: bhyve: Appease warning about a potentially unaligned pointer..Nov 23 2022, 11:17 PM

corvink accepted this revision.Nov 24 2022, 6:39 AM

This revision is now accepted and ready to land.Nov 24 2022, 6:39 AM

markj accepted this revision as: markj.Nov 28 2022, 2:54 PM

Closed by commit rGbc928800723b: bhyve: Avoid passing a possible garbage pointer to free(). (authored by jhb). · Explain WhyNov 29 2022, 1:12 AM

This revision was automatically updated to reflect the committed changes.

jhb added a commit: rGbc928800723b: bhyve: Avoid passing a possible garbage pointer to free()..

jhb added a commit: rG225443828ec6: bhyve: Avoid passing a possible garbage pointer to free()..Jan 26 2023, 8:28 PM

Revision Contents
Changeset List

Path

Size

usr.sbin/

bhyve/

pci_virtio_console.c

2 lines

Diff 113593

View Options

usr.sbin/bhyve/pci_virtio_console.c

bhyve: Avoid passing a possible garbage pointer to free().ClosedPublicActions