Page MenuHomeFreeBSD

bhyve: Don't leak uninitialized bits in NVMe completion statuses.
ClosedPublic

Authored by jhb on Nov 23 2022, 11:16 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Oct 14, 4:34 PM
Unknown Object (File)
Mon, Oct 13, 3:53 PM
Unknown Object (File)
Mon, Oct 13, 12:18 PM
Unknown Object (File)
Mon, Oct 13, 2:51 AM
Unknown Object (File)
Sun, Oct 12, 2:59 PM
Unknown Object (File)
Sun, Oct 12, 3:50 AM
Unknown Object (File)
Wed, Sep 24, 2:49 AM
Unknown Object (File)
Tue, Sep 23, 11:09 PM

Details

Summary

In some cases, some bits in the 16-bit status word were never
initialized.

Reported by: GCC

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

jhb requested review of this revision.Nov 23 2022, 11:16 PM
This revision is now accepted and ready to land.Nov 24 2022, 6:31 AM

I'm surprised that clang didn't flag these. I've noticed it has trouble detecting uninitialized variable use in functions containing gotos, but that doesn't apply here.