Differential D37486

bhyve: Don't leak uninitialized bits in NVMe completion statuses.
ClosedPublic
Actions

Authored by jhb on Nov 23 2022, 11:16 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Thu, Dec 18, 11:46 PM

	Unknown Object (File)
	Fri, Dec 5, 9:08 PM

	Unknown Object (File)
	Tue, Dec 2, 11:22 AM

	Unknown Object (File)
	Wed, Nov 26, 3:44 AM

	Unknown Object (File)
	Tue, Nov 25, 11:16 AM

	Unknown Object (File)
	Tue, Nov 25, 1:00 AM

	Unknown Object (File)
	Mon, Nov 24, 8:06 PM

	Unknown Object (File)
	Mon, Nov 24, 12:46 PM

Subscribers

Details

Reviewers

markj
corvink
chuck

Group Reviewers

Commits

rG3b700550004c: bhyve: Don't leak uninitialized bits in NVMe completion statuses.
rG1d9e8a9e6095: bhyve: Don't leak uninitialized bits in NVMe completion statuses.

Summary

In some cases, some bits in the 16-bit status word were never
initialized.

Reported by: GCC

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

jhb created this revision.Nov 23 2022, 11:16 PM

Herald added a reviewer: bhyve. · View Herald TranscriptNov 23 2022, 11:16 PM

Herald added subscribers: dab, bcran, rgrimes, imp. · View Herald Transcript

jhb requested review of this revision.Nov 23 2022, 11:16 PM

Harbormaster completed remote builds in B48477: Diff 113467.Nov 23 2022, 11:16 PM

jhb added a parent revision: D37485: bhyve: Fix sign compare warnings in the e1000 device model..Nov 23 2022, 11:16 PM

jhb added a child revision: D37487: bhyve: Clear lid to 0 for internal device errors for NVMe AENs..

corvink accepted this revision.Nov 24 2022, 6:31 AM

This revision is now accepted and ready to land.Nov 24 2022, 6:31 AM

jhb added a reviewer: chuck.Nov 24 2022, 5:24 PM

LGTM

I'm surprised that clang didn't flag these. I've noticed it has trouble detecting uninitialized variable use in functions containing gotos, but that doesn't apply here.

Closed by commit rG1d9e8a9e6095: bhyve: Don't leak uninitialized bits in NVMe completion statuses. (authored by jhb). · Explain WhyNov 29 2022, 1:11 AM

This revision was automatically updated to reflect the committed changes.

jhb added a commit: rG1d9e8a9e6095: bhyve: Don't leak uninitialized bits in NVMe completion statuses..

jhb added a commit: rG3b700550004c: bhyve: Don't leak uninitialized bits in NVMe completion statuses..Jan 26 2023, 8:28 PM

Revision Contents
Changeset List

Path

Size

usr.sbin/

bhyve/

4 lines

Diff 113588

usr.sbin/bhyve/pci_nvme.c

Loading...