Page MenuHomeFreeBSD

bhyve: Don't leak uninitialized bits in NVMe completion statuses.
ClosedPublic

Authored by jhb on Wed, Nov 23, 11:16 PM.

Details

Summary

In some cases, some bits in the 16-bit status word were never
initialized.

Reported by: GCC

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

jhb requested review of this revision.Wed, Nov 23, 11:16 PM
This revision is now accepted and ready to land.Thu, Nov 24, 6:31 AM

I'm surprised that clang didn't flag these. I've noticed it has trouble detecting uninitialized variable use in functions containing gotos, but that doesn't apply here.