bhyve: Fix sign compare warnings in the e1000 device model.
ClosedPublic
Actions

Authored by jhb on Nov 23 2022, 11:16 PM.

Details

Reviewers

markj
corvink

Group Reviewers

bhyve

Commits

rGa4d4176aae92: bhyve: Fix sign compare warnings in the e1000 device model.
rGe7cd5ffff88f: bhyve: Fix sign compare warnings in the e1000 device model.

Summary

Adding a bare constant to a uint16_t promotes to a signed int which
triggers these warnings. Changing the constant to be explicitly
unsigned instead promotes the expression to unsigned int.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

jhb created this revision.Nov 23 2022, 11:16 PM

Herald added a reviewer: bhyve. · View Herald TranscriptNov 23 2022, 11:16 PM

Herald added subscribers: bcran, rgrimes, imp. · View Herald Transcript

jhb requested review of this revision.Nov 23 2022, 11:16 PM

Harbormaster completed remote builds in B48476: Diff 113466.Nov 23 2022, 11:16 PM

jhb added a parent revision: D37484: bhyve basl: Use GCC pragmas..Nov 23 2022, 11:16 PM

jhb added a child revision: D37486: bhyve: Don't leak uninitialized bits in NVMe completion statuses..

corvink accepted this revision.Nov 24 2022, 6:30 AM

This revision is now accepted and ready to land.Nov 24 2022, 6:30 AM

markj accepted this revision as: markj.Nov 28 2022, 2:56 PM

Closed by commit rGe7cd5ffff88f: bhyve: Fix sign compare warnings in the e1000 device model. (authored by jhb). · Explain WhyNov 29 2022, 1:11 AM

This revision was automatically updated to reflect the committed changes.

jhb added a commit: rGe7cd5ffff88f: bhyve: Fix sign compare warnings in the e1000 device model..

jhb added a commit: rGa4d4176aae92: bhyve: Fix sign compare warnings in the e1000 device model..Jan 26 2023, 8:28 PM

Revision Contents
Changeset List

Path

Size

usr.sbin/

bhyve/

pci_e82545.c

16 lines

Diff 113587

View Options

usr.sbin/bhyve/pci_e82545.c

bhyve: Fix sign compare warnings in the e1000 device model.ClosedPublicActions