Page MenuHomeFreeBSD

nvmecontrol: Fix IEEE OUI Identifier output.
ClosedPublic

Authored by wanpengqian_gmail.com on Jan 12 2022, 2:55 AM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Apr 9, 9:34 PM
Unknown Object (File)
Jan 18 2024, 3:11 AM
Unknown Object (File)
Jan 6 2024, 11:51 AM
Unknown Object (File)
Jan 4 2024, 9:02 PM
Unknown Object (File)
Jan 4 2024, 9:02 PM
Unknown Object (File)
Jan 4 2024, 6:23 AM
Unknown Object (File)
Dec 23 2023, 10:32 AM
Unknown Object (File)
Dec 10 2023, 5:57 PM
Subscribers

Details

Summary

Current sequence of IEEE OUI Identifier output is wrong.

For Intel, current output is e4 d2 5c, specification is 5CD2E4h
For Samsung, current output is 38 25 00, specification is 002538h
also check with Linux nvme-cli. related code is

printf("ieee      : %02x%02x%02x\n",
	ctrl->ieee[2], ctrl->ieee[1], ctrl->ieee[0]);
Test Plan

tested on Intel/Samsung SSDs.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Here is the compare result with smartctl, for a intel optane 16GB nvme drive

root@szhost:~ # nvmecontrol identify nvme0 | grep e4
IEEE OUI Identifier:         e4 d2 5c
root@szhost:~ # smartctl -a /dev/nvme0 | grep e4
IEEE OUI Identifier:                0x5cd2e4
This revision is now accepted and ready to land.Aug 31 2022, 12:24 AM
This revision was automatically updated to reflect the committed changes.