bhyve: Store the FreeBSD OUI in little-endian in the controller data
ClosedPublic
Actions

Authored by jhb on Aug 17 2023, 1:12 AM.

Details

Reviewers

chuck
imp
corvink

Group Reviewers

bhyve

Commits

rGa11b9463ff58: bhyve: Store the FreeBSD OUI in little-endian in the controller data
rG18974bd616ae: bhyve: Store the FreeBSD OUI in little-endian in the controller data

Summary

Section 7.10.3 of the NVME 1.4b specification states that the IEEE OUI
in the identify controller structure is stored in little-endian format
(unlike the embedded OUI in EUI64 identifiers).

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

jhb created this revision.Aug 17 2023, 1:12 AM

Herald added a reviewer: bhyve. · View Herald TranscriptAug 17 2023, 1:12 AM

Herald added subscribers: dab, bcran, rgrimes. · View Herald Transcript

jhb requested review of this revision.Aug 17 2023, 1:12 AM

Harbormaster completed remote builds in B53145: Diff 126105.Aug 17 2023, 1:12 AM

imp accepted this revision.Aug 17 2023, 1:51 AM

This revision is now accepted and ready to land.Aug 17 2023, 1:51 AM

corvink accepted this revision.Aug 17 2023, 6:09 AM

chuck accepted this revision.Aug 17 2023, 1:31 PM

Closed by commit rG18974bd616ae: bhyve: Store the FreeBSD OUI in little-endian in the controller data (authored by jhb). · Explain WhyAug 17 2023, 6:32 PM

This revision was automatically updated to reflect the committed changes.

jhb added a commit: rG18974bd616ae: bhyve: Store the FreeBSD OUI in little-endian in the controller data.

jhb added a commit: rGa11b9463ff58: bhyve: Store the FreeBSD OUI in little-endian in the controller data.Sep 6 2023, 9:58 PM

Revision Contents
Changeset List

Path

Size

usr.sbin/

bhyve/

pci_nvme.c

4 lines

Diff 126142

View Options

bhyve: Store the FreeBSD OUI in little-endian in the controller dataClosedPublicActions