In D12339#255993, @cem wrote:Er, why is rename / renameat with AT_FDCWD not allowed in capability mode?
- Queries
- All Stories
- Search
- Advanced Search
- Transactions
- Transaction Logs
Feed Advanced Search
Advanced Search
Advanced Search
Sep 15 2017
Sep 15 2017
Sep 9 2017
Sep 9 2017
Ok, I think that addresses the last of the reviewer comments?
Ok, I think that's everything now?
- Move USES above USE_GITHUB.
- Merge 'origin/master' into llbuild
Remove redundant source and object files.
Sep 1 2017
Sep 1 2017
- New port: devel/llbuild
- Change post-stage to post-install for docs.
- Fix typo: "swift-llbuild", not "switch-llbuild"!
- Add the llbuild binary to the build and plist.
- Fix licensing: use ports' multi-license support.
- Fix license: ports tree calls "LLVM" "NCSA".
- Update to use lit from llvm-devel
In this case, LICENSE_FILE describes the Apache license but it also describes which bits of the sources fall under different licenses. Under those conditions, does it make sense to keep?
No, sometimes the device use 0xff for some ID fields which means propritary driver. It might be better to match that than vendor/product.
- Change an unnecessary '?=' to '='.
- Uncomment PKGNAMEPREFIX as requested by sunpoet.
- Update py-cdg to HEAD
jonathan added reviewers for D12208: Remove redundant source, object files.: ngie, bdrewery, dim, peter.
Add reviewers who have touched these makefiles recently
Aug 11 2017
Aug 11 2017
Thanks very much: I've committed the patch as approved/accepted, but would certainly be happy to discuss the relative merits of moving things around (perhaps as a separate action?). I think there will be a tension between the "FreeBSD way" and the "Neo4j way", but... well, perhaps that's a conversation for another day/diff/review. :)
- New port: devel/py-cdg
- Address comments in Phab review
Thanks very much for the feedback: I learned a lot about Python packaging!
Aug 9 2017
Aug 9 2017
Add birthday information for jonathan@.
Jul 20 2017
Jul 20 2017
Jul 5 2017
Jul 5 2017
- Align neo4j.conf patch with previous patch.
- Put databases in /var/db instead of $PREFIX/share.
Jul 4 2017
Jul 4 2017
- Update to use ${PREFIX}/etc as requested.
Ok, that's fair enough: I'll check to make sure that this will work with config files in ${PREFIX}/etc. What is your view on the weird ${PREFIX}/libexec/bin/neo4j-* path with symlinks to /usr/local/bin? My patch (or at least my local version that I've since hacked up some more!) puts cypher-shell, neo4j-admin, etc., into ${PREFIX}/bin and avoids the symlinks entirely. I think this sounds compatible with your view?
Jul 2 2017
Jul 2 2017
Actually, we can simplify a lot of this patching if we follow the Neo4j convention of putting config stuff in somewhere like /usr/local/neo4j/conf instead of /usr/local/etc... thoughts?
Jun 7 2017
Jun 7 2017
May 29 2017
May 29 2017
May 28 2017
May 28 2017
Some very small nits on which I would happily defer (well, except for the spelling one). Otherwise LGTM.
May 18 2017
May 18 2017
Fix some nroff syntax in rtld.1.
May 17 2017
May 17 2017
Allow rtld direct-exec to take a file descriptor.
- Restore tabs to print_args().
In D10751#223329, @kib wrote:For new functions in rtld, I use normal style(9), so rtld slowly migrates to proper indentation. For smaller changes to existing functions I do follow existing style of 4 spaces indent/2 spaces continuation.
- Add a missing rtld_strerror()
- Convert some _rtld_error() calls to rtld_printf().
- Use four spaces for second-level indent.
- Be clear about user- vs path-derived descriptor.
- Remove some superfluous parentheses.
- Remove redundant fstat(2) call.
LGTM. I'm also happy to fix this upstream: what should the Python shebang line be instead of #!/usr/bin/env python?
Ok, I think I've addressed all of these points now. I suppose that my use of strncmp comes from... my fingers just don't want to type functions that start with strc? :) Anyhow, I've changed all of the strncmp to strcmp and strnlen to strlen as you've asked.
- Address comments in kib's review.
- Fix argv/environ/aux shift calculations.
May 16 2017
May 16 2017
- Drop unnecessary defensive braces.
In D10751#222929, @jonathan wrote:
- Merge 'origin/master' into arcpatch-D10751
- Merge 'origin/master' into arcpatch-D10751
- Apply a style(9) fix.
- Remove a stray (debug) utrace(2) invocation.
- Add more explicit argument parsing to rtld.
- Merge remote-tracking branch 'origin/master' into arcpatch-D10751
Rename rtld's parse_libdir to parse_integer.
In D10751#222729, @kib wrote:I do not like these argv0 tricks, I intend to implement normal options parsing for the direct mode. One of the options would take the file descriptor number and do what your trick does. I think that this is better than the trick since it allows to easily invoke and test the functionality from the shell.
May 15 2017
May 15 2017
In D9030#222200, @kib wrote:But important point is that new syscall extends kernel ABI, and by its nature, this change is with us forever. If we start consider the approach wrong and better approach emerges, we still must maintain the syscall, due to the backward compatibility guarantees.
May 13 2017
May 13 2017
In D9030#221824, @kib wrote:What is slightly less obvious is how to pass the binary to ld.so, but: ELF format specified a way to run binaries by filedescriptor for long time. Look at the AT_EXECFD aux vector, we still have this code in rtld.c (it might somewhat rotten, but this is easily fixable). Then the standalone-runnable ld.so only needs to grow an option to specify which fd points to the binary, in addition to AT_EXECFD.
- Don't honour setuid/setgid with custom interpreter.
- Don't honour setuid/setgid with custom interpreter.
In D9030#221740, @kib wrote:Let's split two things. I thought that your issue at hand was the conflict between the nature of capability mode disallowing implicit root and absolute lookups, badly interfering with the typical absolute path specification for ELF interpreters.
May 12 2017
May 12 2017
In D9030#221707, @kib wrote:As is, the thing is unbelievable security hole. Unprivileged user can execute suid binary with arbitrary code injected instead of official interpreter. Even for the static suid binary, it seems. Please correct me.
In D9030#221693, @brooks wrote:FWIW, I'm not a fan of the NULL terminated argv and envv arguments as they make argument validation in CheriABI harder, but I mostly think that ship has sailed. If I were to fix it I'd make the syscall a into a __ffexecve() that takes lengths and have ffexecve() be a user space wrapper that counts the lengths of the vectors and passes them down.
May 11 2017
May 11 2017
- Disable ffexecve(2) with non-ELF image activators.
jonathan retitled D9030: Create new fexecve() variant with explicit interpreter from First attempt at a new fexecve() variant that allows the interpreter to be
specified explicitly with a file descriptor. to Create new fexecve() variant with explicit interpreter.
- Merge 'origin/master' into arcpatch-D9030
- Add !have_interp for consistency.
- Rename fldexec to ffexecve.
- Add ffexecve to execve(2) man page.
Mar 29 2017
Mar 29 2017
Some of these questions may not make sense to those thoroughly versed in DTrace, but I'm new in this corner of the world. :)
Mar 17 2017
Mar 17 2017
- Fix MLINKS for fldexec.
Rebase onto -CURRENT
- Remove auto-generated files from diff.
Mar 11 2017
Mar 11 2017
Jan 3 2017
Jan 3 2017
jonathan retitled D9030: Create new fexecve() variant with explicit interpreter from to First attempt at a new fexecve() variant that allows the interpreter to be
specified explicitly with a file descriptor..
Nov 22 2016
Nov 22 2016
usbconfig output is here: http://pastebin.com/iqJix3h2
I think this might address all of the comments properly now?
- New port: devel/llbuild
- Change post-stage to post-install for docs.
- Fix typo: "swift-llbuild", not "switch-llbuild"!
- Add the llbuild binary to the build and plist.
- Fix licensing: use ports' multi-license support.
Nov 10 2016
Nov 10 2016
Nov 5 2016
Nov 5 2016
- Fix typo: "swift-llbuild", not "switch-llbuild"!
- Change post-stage to post-install for docs.
Nov 4 2016
Nov 4 2016
Nov 1 2016
Nov 1 2016
Add rules to build LLVM IR binaries and libraries.
Thanks for the comments: I think I've managed to address them.
- Add {BC,LL}OBJS to bsd.lib.mk's CLEANFILES.
- Remove redundant C++/non-C++ logic.
- Improve whitespace consistency.
Oct 31 2016
Oct 31 2016
jonathan retitled D8397: Add devd rule for Elantech touchscreens. from to Add devd rule for Elantech touchscreens..
jonathan retitled D8388: Add rules to build LLVM IR binaries and libraries. from to Add rules to build LLVM IR binaries and libraries..
Oct 24 2016
Oct 24 2016
The distinction between .bc and .bco was actually purposeful. The next step in the process is to add IR build rules for whole programs, and then we might end up with conflicts between the IR file that's analogous to cp.o and the IR file that's analogous to the cp binary (i.e., the result of llvm-link). So, we used .bco as the bitcode suffix that's analogous to .o (much like .pico is the PIC suffix for .o files).
Oct 20 2016
Oct 20 2016
Add make rules to build LLVM IR from C/C++ sources.
Oct 19 2016
Oct 19 2016
This is a much simpler change after rS307075. How does it look to everyone now?
Oct 12 2016
Oct 12 2016
Looks like a good idea to me. Perhaps it's worthy of a comment explaining why we use abort() within a library? It could contain the same text as at the top of this review, but it might be a slightly surprising thing to discover if you haven't been party to the review.
Rework this change based on rS307075 (suffix rule files).
Extract suffix rules into bsd.suffixes[-posix].mk.
Oct 11 2016
Oct 11 2016
- Merge 'origin/master' into arcpatch-D6805
Oct 7 2016
Oct 7 2016
A fairly cursory look didn't turn up any obvious problems for me, but I would like to take a deeper look over the next few days.
Thanks for responding... sounds like a tough problem until we make the leap to Python 3.
Oct 6 2016
Oct 6 2016
Indeed, I did have that exp-run done:
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=210331
Not that we're well clear of code freezes on -CURRENT (and I think that I've addressed @bdrewery's comments), are folks ok with me committing this?
Oct 3 2016
Oct 3 2016